[Bug 26327] New: Include transacting library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Bug ID: 26327 Summary: Include transacting library in fines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Bug 15985 got lengthy and the patchset got over-complicated on the QA process and the guidelines changes in between. I propose a fresh restart here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- *** Bug 15985 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com, | |jrobb@sekls.org, | |katrin.fischer@bsz-bw.de, | |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109376&action=edit Bug 26327: Add ->library method to Koha::*Checkout This patch adds a 'library' relationship to the Issue and OldIssue resultsets, to be used in the Koha::*Checkout classes corresponding accessors. This way we will be able to eventually embed and filter on library fields on the API. The ->library method is then added to the classes- To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old.t t/db_dependent/Koha/Checkout.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
UPDATE old_issues SET branchcode='TOM' WHERE issue_id=11; (i.e. set the branchcode to an invalid value, to emulate a deleted branch).
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109377&action=edit Bug 26327: Include transacting library in fines This patch introduces a new column on the fines table to display the checkout library when the fine is tied to a checkout. To test: 1. Have an overdue item that generated a fee 2. Look at the 'Accounting' tab, 'Make a payment' => FAIL: There's no information about the library 3. Apply this patch 4. Restart all 5. Reload and repeat 2 => SUCCESS: There's a column with the library name! 6. Identify the issue_id for the mentioned checkout and: $ koha-mysql kohadev 7. Reload => SUCCESS: It doesn't explode, it doesn't display a library name. 8. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109378&action=edit Bug 26327: Add to columns settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109376|0 |1 is obsolete| | Attachment #109377|0 |1 is obsolete| | Attachment #109378|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109505&action=edit Bug 26327: Add ->library method to Koha::*Checkout This patch adds a 'library' relationship to the Issue and OldIssue resultsets, to be used in the Koha::*Checkout classes corresponding accessors. This way we will be able to eventually embed and filter on library fields on the API. The ->library method is then added to the classes- To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old.t t/db_dependent/Koha/Checkout.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
UPDATE old_issues SET branchcode='TOM' WHERE issue_id=11; (i.e. set the branchcode to an invalid value, to emulate a deleted branch).
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109506&action=edit Bug 26327: Include transacting library in fines This patch introduces a new column on the fines table to display the checkout library when the fine is tied to a checkout. To test: 1. Have an overdue item that generated a fee 2. Look at the 'Accounting' tab, 'Make a payment' => FAIL: There's no information about the library 3. Apply this patch 4. Restart all 5. Reload and repeat 2 => SUCCESS: There's a column with the library name! 6. Identify the issue_id for the mentioned checkout and: $ koha-mysql kohadev 7. Reload => SUCCESS: It doesn't explode, it doesn't display a library name. 8. Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109507&action=edit Bug 26327: Add to columns settings Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Looks good! Wondering if we should include the column in boraccount.pl as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Kyle M Hall from comment #8)
Looks good! Wondering if we should include the column in boraccount.pl as well.
That's a great idea, Kyle. I'm submitting a follow-up. Can you review it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109531&action=edit Bug 26327: (follow-up) Add transacting library to the transactions tab Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I have one doubt about this patches that add new columns to existing tables: should we make the new columns hidden by default? It is a trivial follow-up patch but I was wondering if we had a policy for this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #11)
I have one doubt about this patches that add new columns to existing tables: should we make the new columns hidden by default? It is a trivial follow-up patch but I was wondering if we had a policy for this.
I feel like it might be beneficial to show it - it's easy to hide and it hightlights a change. In the past, we didn't have the table configuration and new columns always showed up... so maybe it's not that much of a change. I can see why we would want to hide it too - maybe need more opinions, but don't see this as a blocker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #12)
(In reply to Tomás Cohen Arazi from comment #11)
I have one doubt about this patches that add new columns to existing tables: should we make the new columns hidden by default? It is a trivial follow-up patch but I was wondering if we had a policy for this.
I feel like it might be beneficial to show it - it's easy to hide and it hightlights a change. In the past, we didn't have the table configuration and new columns always showed up... so maybe it's not that much of a change.
I can see why we would want to hide it too - maybe need more opinions, but don't see this as a blocker.
Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is a display issue in that the total due line (last line of the table) is now "too short". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 110412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110412&action=edit Bug 26327: (QA follow-up) Fix colspan in boraccount.tt Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #14)
There is a display issue in that the total due line (last line of the table) is now "too short".
Thanks for pointing it out, and to Owen for clarifying on IRC. My brain is malfunctioning it seems. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #16)
(In reply to Katrin Fischer from comment #14)
There is a display issue in that the total due line (last line of the table) is now "too short".
Thanks for pointing it out, and to Owen for clarifying on IRC. My brain is malfunctioning it seems.
I was struggling a bit to describe it - but I think you can tell that I tried :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Include transacting library |Include checkout library in |in fines |fines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109505|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110421&action=edit Bug 26327: Add ->library method to Koha::*Checkout This patch adds a 'library' relationship to the Issue and OldIssue resultsets, to be used in the Koha::*Checkout classes corresponding accessors. This way we will be able to eventually embed and filter on library fields on the API. The ->library method is then added to the classes- To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old.t t/db_dependent/Koha/Checkout.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
UPDATE old_issues SET branchcode='TOM' WHERE issue_id=11; (i.e. set the branchcode to an invalid value, to emulate a deleted branch).
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109506|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110422&action=edit Bug 26327: Include transacting library in fines This patch introduces a new column on the fines table to display the checkout library when the fine is tied to a checkout. To test: 1. Have an overdue item that generated a fee 2. Look at the 'Accounting' tab, 'Make a payment' => FAIL: There's no information about the library 3. Apply this patch 4. Restart all 5. Reload and repeat 2 => SUCCESS: There's a column with the library name! 6. Identify the issue_id for the mentioned checkout and: $ koha-mysql kohadev 7. Reload => SUCCESS: It doesn't explode, it doesn't display a library name. 8. Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109507|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110423&action=edit Bug 26327: Add to columns settings Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109531|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110424&action=edit Bug 26327: (follow-up) Add transacting library to the transactions tab Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110412|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110425&action=edit Bug 26327: (QA follow-up) Fix colspan in boraccount.tt Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Can you rebase please? Applying: Bug 26327: (follow-up) Add transacting library to the transactions tab error: sha1 information is lacking or useless (admin/columns_settings.yml). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #23)
Can you rebase please?
Applying: Bug 26327: (follow-up) Add transacting library to the transactions tab error: sha1 information is lacking or useless (admin/columns_settings.yml).
What git version are you using? Mine gave me a really trivial merge conflict: $ git --version git version 2.28.0 $ git diff diff --cc admin/columns_settings.yml index 9400dcf3691,3f1d19ee79d..00000000000 --- a/admin/columns_settings.yml +++ b/admin/columns_settings.yml @@@ -666,7 -666,7 +666,11 @@@ modules - columnname: issuedate - ++<<<<<<< HEAD + columnname: home_library ++======= + columnname: checked_out_from ++>>>>>>> Bug 26327: (follow-up) Add transacting library to the transactions tab - columnname: note - -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110423|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 111417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111417&action=edit Bug 26327: Add to columns settings Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110424|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110425|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110421|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110422|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111417|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 111420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111420&action=edit Bug 26327: Add ->library method to Koha::*Checkout This patch adds a 'library' relationship to the Issue and OldIssue resultsets, to be used in the Koha::*Checkout classes corresponding accessors. This way we will be able to eventually embed and filter on library fields on the API. The ->library method is then added to the classes- To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old.t t/db_dependent/Koha/Checkout.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
UPDATE old_issues SET branchcode='TOM' WHERE issue_id=11; (i.e. set the branchcode to an invalid value, to emulate a deleted branch).
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 111421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111421&action=edit Bug 26327: Include transacting library in fines This patch introduces a new column on the fines table to display the checkout library when the fine is tied to a checkout. To test: 1. Have an overdue item that generated a fee 2. Look at the 'Accounting' tab, 'Make a payment' => FAIL: There's no information about the library 3. Apply this patch 4. Restart all 5. Reload and repeat 2 => SUCCESS: There's a column with the library name! 6. Identify the issue_id for the mentioned checkout and: $ koha-mysql kohadev 7. Reload => SUCCESS: It doesn't explode, it doesn't display a library name. 8. Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 111422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111422&action=edit Bug 26327: Add to columns settings Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 111423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111423&action=edit Bug 26327: (follow-up) Add transacting library to the transactions tab Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 111424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111424&action=edit Bug 26327: (QA follow-up) Fix colspan in boraccount.tt Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds the release notes| |transacting library in | |fines that are linked to | |checkouts in the accounting | |section for the patron. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, either the bug title or the bug description are wrong - it's either transacting library or checkout library, but both are not the same necessarily? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #31)
Hm, either the bug title or the bug description are wrong - it's either transacting library or checkout library, but both are not the same necessarily?
The description links transacting+checkouts, that's why I thought it was correct. Feel free to adjust it as I'm not attached to that description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not the patch author :) My thought: the checkout library is the library an item was checked out from. A transacting library for a fine would be the one where it was created manually or if item related it might depend on which library was used for creating the fine (thinking about CircControl) or for payments where it was paid at. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch adds the |This patch adds a new release notes|transacting library in |column in the accounting |fines that are linked to |tables for a patron. The |checkouts in the accounting |column will show the |section for the patron. |checkout library for | |charges that are tied to | |circulation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 111586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111586&action=edit Bug 26327: Add exec flag on .t file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #37 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org