[Bug 21709] New: Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Bug ID: 21709 Summary: Addbiblio shows tag editor icons which do nothing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@joensuu.fi QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Addbiblio can show a tag editor icon after the field which does nothing. The icon will have the "No popup" title and clicking on it does nothing. There should be no icon shown, if there is no editor attached to it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please add more details how to reproduce. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #2 from paxed <pasi.kallinen@joensuu.fi> --- (In reply to Marcel de Rooy from comment #1)
Please add more details how to reproduce.
Install master with defaults, go to Cataloging > New record > Default framework, try to click on the 003 or 005 tag editor icon. Contrast that with the tag editor icons of 000, 007, or 008. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think they work when clicking in the field, not all have a pop-up. Similar to the one behind dateacessioned or autobarode. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- So they icon can indicate extra functionality that is linked to the field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #5 from paxed <pasi.kallinen@joensuu.fi> --- But in these cases, the icon is clickable, it just does nothing. If it did the same as clicking on the field (autofilling the data), then it would be OK. If the icon wasn't clickable, it would be OK. (Although I'd still want a visual indication without needing to move the mouse over it) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81832&action=edit Bug 21709: Replace 'no popup' plugin links with a span -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Like that? Also I am wondering if we should not remove some classes, I do not know what is the purpose of .buttonDot -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- <span class="buttonDot tag_editor disabled" tabindex="-1" title="Field autofilled by plugin"></a> This seems to be invalid HTML :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #7)
Like that? Also I am wondering if we should not remove some classes, I do not know what is the purpose of .buttonDot
This makes no actual difference. I still see a button that does not respond to clicks. But this is the actual design: if you do not explicitly assign a click event, it should not respond to click. (The only problem is that we have been used to some buttons that translated click to focus events.) I agree with paxed that we should see the difference right away: have a visual distinction between a real popup and just a focus action (there may be a report already for that). Only removing the button is not the solution, since we still want to alert on the focus action. It should not be that hard to define a separate class and add some css associated to it to achieve our goal. On the other hand, when we really want click to translate to focus, add three lines in the popup script. For instance for 003 in marc21_orgcode.pl: function Click$params->{id}(event) { \$('#'+event.data.id).focus(); } And now it responds to click and triggers focus.. (I still think though that it should not be the default.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The buttondot class indeed seems to be unneeded ballast. Note that we do need the buttonDot_ id. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81832|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89379&action=edit Bug 21709: Replace 'no popup' plugin links with a span Test plan: Edit a bibliographic record Notice that the icons next to fields linked with a plugin can be a link or not. The browser displays a pointer or not. It will remove the ambiguity to display an icon that is clickable but does nothing when clicked. We could also have another icon to disociate both behaviors. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #9)
(In reply to Jonathan Druart from comment #7)
Like that? Also I am wondering if we should not remove some classes, I do not know what is the purpose of .buttonDot
This makes no actual difference. I still see a button that does not respond to clicks.
To me it's an improvement, the link is removed if no popup will be opened. So there is an icon but nothing to tell you it's clickable (pointer will be different). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Addbiblio shows tag editor |Addbiblio shows clickable |icons which do nothing |tag editor icons which do | |nothing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89379|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89390&action=edit Bug 21709: Replace 'no popup' plugin links with a span Test plan: Edit a bibliographic record Notice that the icons next to fields linked with a plugin can be a link or not. The browser displays a pointer or not. It will remove the ambiguity to display an icon that is clickable but does nothing when clicked. We could also have another icon to disociate both behaviors. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89390|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 89524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89524&action=edit Bug 21709: Replace 'no popup' plugin links with a span Test plan: Edit a bibliographic record Notice that the icons next to fields linked with a plugin can be a link or not. The browser displays a pointer or not. It will remove the ambiguity to display an icon that is clickable but does nothing when clicked. We could also have another icon to disociate both behaviors. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.06 released in| | Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org