[Bug 19520] New: Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 Bug ID: 19520 Summary: Show more information about rotating collections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org On colections list and detail: - Number of items in collection - Number of transferred/untransferred items - Librarian who created the collection - Date of creation - Date of last transfer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19519 Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19519 [Bug 19519] Ability to bind the rotating collection with branch during creating -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 72819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72819&action=edit Bug 19520: Update database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 72820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72820&action=edit Bug 19520: Update databse schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 72821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72821&action=edit Bug 19520: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 72822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72822&action=edit Bug 19520: Add more information about rotating collections Test plan: 1) Apply the patch 2) Update database 3) ) prove t/db_dependent/Koha/RotatingCollections.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 72819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72819 Bug 19520: Update database Review of attachment 72819: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19520&attachment=72819) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/Bug19520_Add_more_information_to_rotating_collections.perl @@ +5,5 @@
+ $dbh->do( "ALTER TABLE collections ADD CONSTRAINT `collections_ibfk_2` FOREIGN KEY (`createdBy`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE"); + + $dbh->do( "ALTER TABLE collections ADD COLUMN createdOn datetime default NULL AFTER createdBy" ); + + $dbh->do( "ALTER TABLE collections ADD COLUMN lastTransferredOn datetime default NULL AFTER createdOn" );
These 4 do's should be encapsulated by !column_exists checks. @@ +10,5 @@
+ + # or perform some test and warn + # if( !column_exists( 'biblio', 'biblionumber' ) ) { + # warn "There is something wrong"; + # }
And you don't need comments. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72819|0 |1 is obsolete| | Attachment #72820|0 |1 is obsolete| | Attachment #72821|0 |1 is obsolete| | Attachment #72822|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73260&action=edit Bug 19520: Update database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73261&action=edit Bug 19520: Update databse schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73262&action=edit Bug 19520: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73263&action=edit Bug 19520: Add more information about rotating collections Test plan: 1) Apply the patch 2) Update database 3) prove t/db_dependent/Koha/RotatingCollections.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #10 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to M. Tompsett from comment #5)
Comment on attachment 72819 [details] [review] Bug 19520: Update database
Review of attachment 72819 [details] [review]: -----------------------------------------------------------------
::: installer/data/mysql/atomicupdate/ Bug19520_Add_more_information_to_rotating_collections.perl @@ +5,5 @@
+ $dbh->do( "ALTER TABLE collections ADD CONSTRAINT `collections_ibfk_2` FOREIGN KEY (`createdBy`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE"); + + $dbh->do( "ALTER TABLE collections ADD COLUMN createdOn datetime default NULL AFTER createdBy" ); + + $dbh->do( "ALTER TABLE collections ADD COLUMN lastTransferredOn datetime default NULL AFTER createdOn" );
These 4 do's should be encapsulated by !column_exists checks.
@@ +10,5 @@
+ + # or perform some test and warn + # if( !column_exists( 'biblio', 'biblionumber' ) ) { + # warn "There is something wrong"; + # }
And you don't need comments. :)
Done, thanks ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73260|0 |1 is obsolete| | Attachment #73261|0 |1 is obsolete| | Attachment #73262|0 |1 is obsolete| | Attachment #73263|0 |1 is obsolete| | --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73394&action=edit Bug 19520: Update database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73395&action=edit Bug 19520: Update databse schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73396&action=edit Bug 19520: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73397&action=edit Bug 19520: Add more information about rotating collections Test plan: 1) Apply the patch 2) Update database 3) prove t/db_dependent/Koha/RotatingCollections.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #15 from Michal Denar <black23@gmail.com> --- Josef, can You rebase this bug? Thank You Mike -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org