[Bug 18780] New: Translatability: Get rid of exposed tt directive in masthead-langmenu.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18780 Bug ID: 18780 Summary: Translatability: Get rid of exposed tt directive in masthead-langmenu.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr The file opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc exposes following tt directive to translators: "[%% IF ( ( opaclanguagesdisplay ) && ( ! one_language_enabled ) && " "( languages_loop ) && ( OpacLangSelectorMode == 'both' || " "OpacLangSelectorMode == 'top') ) %%] " -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18780 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18780 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 64191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64191&action=edit Bug 18780: Translatability: Get rid of exposed tt directive in masthead-langmenu.inc The file opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc exposes following tt directive to translators: "[%% IF ( ( opaclanguagesdisplay ) && ( ! one_language_enabled ) && " "( languages_loop ) && ( OpacLangSelectorMode == 'both' || " "OpacLangSelectorMode == 'top') ) %%] " This patch fixes it. To test: - Apply patch - Verify that language selector in OPAC (top of the page) works as expected - Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18780 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18780 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18780 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64191|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 64737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64737&action=edit [SIGNED-OFF] Bug 18780: Translatability: Get rid of exposed tt directive in masthead-langmenu.inc The file opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc exposes following tt directive to translators: "[%% IF ( ( opaclanguagesdisplay ) && ( ! one_language_enabled ) && " "( languages_loop ) && ( OpacLangSelectorMode == 'both' || " "OpacLangSelectorMode == 'top') ) %%] " This patch fixes it. To test: - Apply patch - Verify that language selector in OPAC (top of the page) works as expected - Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po NOTE: Followed a test plan similar to bug 18776 comment 3 Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18780 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18780 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64737|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66644&action=edit Bug 18780: Translatability: Get rid of exposed tt directive in masthead-langmenu.inc The file opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc exposes following tt directive to translators: "[%% IF ( ( opaclanguagesdisplay ) && ( ! one_language_enabled ) && " "( languages_loop ) && ( OpacLangSelectorMode == 'both' || " "OpacLangSelectorMode == 'top') ) %%] " This patch fixes it. To test: - Apply patch - Verify that language selector in OPAC (top of the page) works as expected - Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po NOTE: Followed a test plan similar to bug 18776 comment 3 Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18780 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18780 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18780 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18780 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #7 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.18 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org