[Bug 18779] New: Translatability: Get rid of exposed tt directives in authorities-search-results.inc (OPAC)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779 Bug ID: 18779 Summary: Translatability: Get rid of exposed tt directives in authorities-search-results.inc (OPAC) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr The file opac-tmpl/bootstrap/en/includes/authorities-search-results.inc exposes template directives to translation where translators should not be confronted with. Example: "[%% PROCESS showreference heading=seeals.heading linkType='seealso' " "type=seeals.type authid=seeals.authid %%] " -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 64190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64190&action=edit Bug 18779: Translatability: Get rid of exposed tt directives in authorities-search-results.inc (OPAC) The file opac-tmpl/bootstrap/en/includes/authorities-search-results.inc exposes template directives to translation where translators should not be confronted with. Example: "[%% PROCESS showreference heading=seeals.heading linkType='seealso' " "type=seeals.type authid=seeals.authid %%] " To test: - Apply patch - Verify that Authority search in OPAC works as before - Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, could we generally exclude every element starting with [%% instead of doing those one by one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779 --- Comment #3 from Marc Véron <veron@veron.ch> --- (In reply to Katrin Fischer from comment #2)
Hm, could we generally exclude every element starting with [%% instead of doing those one by one?
Line breaks inside template directives are not easy to cover by the translation process. You can not skip them because they can contain particles that should be translated. See following comment: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16559#c1 Jonathan recently added a test to QA tools. The newest version checks for line breaks inside tt directives. It makes sense to weed out such tt directives because translators should not be exposed to such code internals. BTW: For OPAC, all occurences of "[%%" are fixed with my series of patches (search for: translatability). For staff, most work is done as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779 --- Comment #4 from Marc Véron <veron@veron.ch> --- Still applies on current master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64190|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 65398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65398&action=edit [SIGNED-OFF] Bug 18779: Translatability: Get rid of exposed tt directives in authorities-search-results.inc (OPAC) The file opac-tmpl/bootstrap/en/includes/authorities-search-results.inc exposes template directives to translation where translators should not be confronted with. Example: "[%% PROCESS showreference heading=seeals.heading linkType='seealso' " "type=seeals.type authid=seeals.authid %%] " To test: - Apply patch - Verify that Authority search in OPAC works as before - Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65398|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66642&action=edit Bug 18779: Translatability: Get rid of exposed tt directives in authorities-search-results.inc (OPAC) The file opac-tmpl/bootstrap/en/includes/authorities-search-results.inc exposes template directives to translation where translators should not be confronted with. Example: "[%% PROCESS showreference heading=seeals.heading linkType='seealso' " "type=seeals.type authid=seeals.authid %%] " To test: - Apply patch - Verify that Authority search in OPAC works as before - Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.18 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org