[Bug 26760] New: Redirect to paycollect.pl when clicking on "Save and pay"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Bug ID: 26760 Summary: Redirect to paycollect.pl when clicking on "Save and pay" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org Depends on: 14898 Bug 14898 added the "Save and pay" button that redirects to "Make a payment" tab after creating a manual invoice This requires the user to click on another "Pay" button before being taken to the real payment form. By redirecting directly to paycollect.pl, this useless step will no longer be needed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 [Bug 14898] Add 'Save and pay' button to use after adding a manual invoice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 112093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112093&action=edit Bug 26760: Redirect to paycollect.pl when clicking on "Save and pay" Bug 14898 added the "Save and pay" button that redirects to "Make a payment" tab after creating a manual invoice This requires the user to click on another "Pay" button before being taken to the real payment form. By redirecting directly to paycollect.pl, this useless step will no longer be needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Test plan: 1. Create a manual invoice for any patron and click on "Save and pay", you should be redirected to the payment form 2. Confirm the payment, make sure it appears in the transactions tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112093|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 112313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112313&action=edit Bug 26760: Redirect to paycollect.pl when clicking on "Save and pay" Bug 14898 added the "Save and pay" button that redirects to "Make a payment" tab after creating a manual invoice This requires the user to click on another "Pay" button before being taken to the real payment form. By redirecting directly to paycollect.pl, this useless step will no longer be needed. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112313|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 112351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112351&action=edit Bug 26760: Redirect to paycollect.pl when clicking on "Save and pay" Bug 14898 added the "Save and pay" button that redirects to "Make a payment" tab after creating a manual invoice This requires the user to click on another "Pay" button before being taken to the real payment form. By redirecting directly to paycollect.pl, this useless step will no longer be needed. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. Parameter needs to be URI escaped, at least the description 2. Why the sprintf? I am expecting the formatting to be template side? Failing QA for 1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 120856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120856&action=edit Bug 26760: Escape URI parameters in redirect URI to paycollect.pl Also remove useless '%.2f' formatting of amount and amountoutstanding -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #5)
1. Parameter needs to be URI escaped, at least the description Fixed
2. Why the sprintf? I am expecting the formatting to be template side? If you're talking about sprintf('%.2f', ...) I don't remember why I added this, and it seems useless, so I removed it.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112351|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 122577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122577&action=edit Bug 26760: Redirect to paycollect.pl when clicking on "Save and pay" Bug 14898 added the "Save and pay" button that redirects to "Make a payment" tab after creating a manual invoice This requires the user to click on another "Pay" button before being taken to the real payment form. By redirecting directly to paycollect.pl, this useless step will no longer be needed. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120856|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 122578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122578&action=edit Bug 26760: Escape URI parameters in redirect URI to paycollect.pl Also remove useless '%.2f' formatting of amount and amountoutstanding Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.02 released in| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- I propose we do not impact older versions behavior. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org