[Bug 28597] New: Opac suggestions do not display news for logged in branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 Bug ID: 28597 Summary: Opac suggestions do not display news for logged in branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The parameter 'branchcode' is never set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122133&action=edit Bug 28597: Fetch the logged in branchcode for OpacSuggestioninstructions To test: 1 - Set two news items with location 'OpacSuggestioninstructions' 2 - One should be for all libraries 3 - One should be for a specific library 4 - Sign in to opac with user from the specific library 5 - Add a suggestion 6 - The instructions only show the all libraries item 7 - Apply patch 8 - Reload 9 - All libraries and specific library items are shown 10 - Allow anonymous suggestions: AnonSuggestions - Allow 11 - Sign out of opac 12 - Add a suggestion 13 - Only all librares news is visible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122133|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 122178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122178&action=edit Bug 28597: Fetch the logged in branchcode for OpacSuggestioninstructions To test: 1 - Set two news items with location 'OpacSuggestioninstructions' 2 - One should be for all libraries 3 - One should be for a specific library 4 - Sign in to opac with user from the specific library 5 - Add a suggestion 6 - The instructions only show the all libraries item 7 - Apply patch 8 - Reload 9 - All libraries and specific library items are shown 10 - Allow anonymous suggestions: AnonSuggestions - Allow 11 - Sign out of opac 12 - Add a suggestion 13 - Only all librares news is visible Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28650 CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Incidentally, stumbled over this one too this morning. Bug 28650 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #3)
Incidentally, stumbled over this one too this morning. Bug 28650
And did the same thing on bug 27948 :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122178|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122548&action=edit Bug 28597: Fetch the logged in branchcode for OpacSuggestioninstructions To test: 1 - Set two news items with location 'OpacSuggestioninstructions' 2 - One should be for all libraries 3 - One should be for a specific library 4 - Sign in to opac with user from the specific library 5 - Add a suggestion 6 - The instructions only show the all libraries item 7 - Apply patch 8 - Reload 9 - All libraries and specific library items are shown 10 - Allow anonymous suggestions: AnonSuggestions - Allow 11 - Sign out of opac 12 - Add a suggestion 13 - Only all librares news is visible Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Opac suggestions do not |OPAC suggestions do not |display news for logged in |display news for logged in |branch |branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.02 released in| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26630 CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 26630 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26630 [Bug 26630] Allow custom text for each library on the purchase suggestion page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 26630 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org