http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12703 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12703 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12703 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33655|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 33686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33686&action=edit Bug 12703 - OPAC privacy page still accessible when the feature is turned off If the OPACPrivacy system preference is turned off it is still possible to navigate directly to the OPAC privacy page if you know the URL. This patch adapts the fix for Bug 10595 (OpacTopissue page still accessible when system preference is turned off) for opac-privacy.pl Because the OPACPrivacy preference is irrelevant if opacreadinghistory is not turned on, the patch adds a check for both to determine whether the page should be accessible. Log in to the OPAC and test under the following conditions: - OPACPrivacy is turned off, opacreadinghistory is turned off. Navigate directly to /cgi-bin/koha/opac-privacy.pl. You should get a 404 error. - OPACPrivacy is turned off, opacreadinghistory is turned on. Navigate directly to /cgi-bin/koha/opac-privacy.pl. You should get a 404 error. - OPACPrivacy is turned on, opacreadinghistory is turned off. Navigate directly to /cgi-bin/koha/opac-privacy.pl. You should get a 404 error. - OPACPrivacy is turned on, opacreadinghistory is turned on. A link to both "your reading history" and "your privacy" should appear in the left-hand sidebar menu. Both pages should work. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12703 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33700&action=edit [PASSED QA] Bug 12703 - OPAC privacy page still accessible when the feature is turned off If the OPACPrivacy system preference is turned off it is still possible to navigate directly to the OPAC privacy page if you know the URL. This patch adapts the fix for Bug 10595 (OpacTopissue page still accessible when system preference is turned off) for opac-privacy.pl Because the OPACPrivacy preference is irrelevant if opacreadinghistory is not turned on, the patch adds a check for both to determine whether the page should be accessible. Log in to the OPAC and test under the following conditions: - OPACPrivacy is turned off, opacreadinghistory is turned off. Navigate directly to /cgi-bin/koha/opac-privacy.pl. You should get a 404 error. - OPACPrivacy is turned off, opacreadinghistory is turned on. Navigate directly to /cgi-bin/koha/opac-privacy.pl. You should get a 404 error. - OPACPrivacy is turned on, opacreadinghistory is turned off. Navigate directly to /cgi-bin/koha/opac-privacy.pl. You should get a 404 error. - OPACPrivacy is turned on, opacreadinghistory is turned on. A link to both "your reading history" and "your privacy" should appear in the left-hand sidebar menu. Both pages should work. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and qa script. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33686|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.