[Bug 13289] New: Calendar with weekly repeating holidays completely broken by DataTables upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13289 Bug ID: 13289 Summary: Calendar with weekly repeating holidays completely broken by DataTables upgrade Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Bug 12986 (Upgrade the DataTables jQuery plugin to the latest version (1.10.2)) broke the calendar tool ( Tool -> Calendar ) if weekly repeating holidays are present. When I try to access that page I get a blank screen except for the word "Mondays" (or sometimes "Sundays," or sometimes "MondaysSundays"). Truncating the repeatable_holidays fixes the problem. Adding a new repeatable holiday on a specific date (e.g. December 25) doesn't trigger the problem. Adding a new range of holidays repeating yearly doesn't trigger the problem. Adding a holiday which repeats on the same day every week (e.g. "Closed Sunday") *does* trigger the problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13289 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13289 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33682&action=edit Bug 13289: document.write breaks DataTables The document.write in a td seems to brake the page with a new version of DataTables. This patch replaces a dirty piece of code with another one (but this one works...) Test plan: Create repeatable holidays and verify the page loads correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13289 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13289 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13289 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33682|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 33683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33683&action=edit [SIGNED-OFF] Bug 13289: document.write breaks DataTables The document.write in a td seems to brake the page with a new version of DataTables. This patch replaces a dirty piece of code with another one (but this one works...) Test plan: Create repeatable holidays and verify the page loads correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Works to fix the problem. The code is definitely an improvement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13289 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13289 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33683|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33694&action=edit [PASSED QA] Bug 13289: document.write breaks DataTables The document.write in a td seems to brake the page with a new version of DataTables. This patch replaces a dirty piece of code with another one (but this one works...) Test plan: Create repeatable holidays and verify the page loads correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Works to fix the problem. The code is definitely an improvement. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, fixes critical problem. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13289 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org