[Bug 11880] New: Select the barcode index by default then searching for label items.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Bug ID: 11880 Summary: Select the barcode index by default then searching for label items. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label printing Assignee: cnighswonger@foundations.edu Reporter: fcapovilla@live.ca QA Contact: testopia@bugs.koha-community.org Created attachment 25746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25746&action=edit Select the barcode index by default then searching for label items. Since searching for barcodes should be a lot more frequent when creating item batches, this patch make the barcode index selected by default on the label item search page. Test case: * Go to "Tools -> Label creator -> Manage batches" * Click on the "New batch" button * Click on the "Add item(s)" button * A search window should open. The "Barcode" value should be selected in the the selectbox. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 25820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25820&action=edit [Signed-off] Select the barcode index by default then searching for label items. http://bugs.koha-community.org/show_bug.cgi?id=11880 Test case: * Go to "Tools -> Label creator -> Manage batches" * Click on the "New batch" button * Click on the "Add item(s)" button * A search window should open. The "Barcode" value should be selected in the the selectbox. Followed test case. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25746|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |fcapovilla@live.ca |u | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Frédérick: The patch does: IF selected: select option ELSE: select option It seems it works like that currently but it is definitively not a good way to do. Do you know if the "selected" variable is passed to the template? I don't see any occurrence in the pl script. Maybe could we remove all previous tests and always select the barcode option? Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #3 from Frédérick Capovilla <fcapovilla@live.ca> --- The code in this template seems strange. If (selected==true), it looks like ALL the options of the selectbox be set as selected. Am I right? When we did our patch, we didn't touch the rest of the template because we didn't know why the page was set like that. I need a second opinion before removing the "selected" option, since this fix goes beyond this simple patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Frédérick Capovilla from comment #3)
The code in this template seems strange. If (selected==true), it looks like ALL the options of the selectbox be set as selected. Am I right?
... yes! But I did not find any situation where "selected" is set. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff CC| |simith.doliveira@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Status|Needs Signoff |Failed QA --- Comment #5 from Nicole C. Engard <nengard@gmail.com> --- I'm confused by this. I was going to sign off but see the notes at the bottom so I'm re-marking failed qa. If that's wrong feel free to fix. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |charles.farmer@inlibro.com --- Comment #6 from Charles Farmer <charles.farmer@inlibro.com> --- Despite the ugliness of the template in its present form, the patch works and is a development needed by our client. This patch should be accepted as is. Fixing the template is considerably out of the scope of this development. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |aleishaamohia@hotmail.com --- Comment #7 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Patch applies cleanly, signing off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38475&action=edit Bug 11880: Select what has been selected before The previous patch wants to select the barcode option when the user is on the item search for label, in all cases. So even if 'title' is selected, a search done, and there is no result, the barcode index is selected anyway. In this case, the title option should be kept. Test plan: Confirm that the barcode option is the default choice, but other values are kept is the search does not return any result. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Charles Farmer from comment #6)
Despite the ugliness of the template in its present form, the patch works and is a development needed by our client.
This patch should be accepted as is. Fixing the template is considerably out of the scope of this development.
It's not because it's needed by your client that the patch should be accepted as you have written it... It's your duty to sent clean patches and make the code better, not worst. The patch you have sent does not make any sense and adds misunderstanding to the template. Anyway, here a patch to clean the situation, it took me 5 minutes to write, much more less than argue for hours... Back to needs signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 --- Comment #10 from Marc Véron <veron@veron.ch> --- Created attachment 38479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38479&action=edit [Signed-off] Bug 11880: Select what has been selected before The previous patch wants to select the barcode option when the user is on the item search for label, in all cases. So even if 'title' is selected, a search done, and there is no result, the barcode index is selected anyway. In this case, the title option should be kept. Test plan: Confirm that the barcode option is the default choice, but other values are kept if the search does not return any result. Followed test plan, behaves as expected. Tested with all choices. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38475|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 40774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40774&action=edit Bug 11880: Select the barcode index by default then searching for label items. Test case: * Go to "Tools -> Label creator -> Manage batches" * Click on the "New batch" button * Click on the "Add item(s)" button * A search window should open. The "Barcode" value should be selected in the the selectbox. Followed test case. Patch behaves as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 40775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40775&action=edit Bug 11880: Select what has been selected before The previous patch wants to select the barcode option when the user is on the item search for label, in all cases. So even if 'title' is selected, a search done, and there is no result, the barcode index is selected anyway. In this case, the title option should be kept. Test plan: Confirm that the barcode option is the default choice, but other values are kept if the search does not return any result. Followed test plan, behaves as expected. Tested with all choices. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25820|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38479|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thx for cleaning up, Jonathan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Frederick and Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #15 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.x will be in 3.18.11. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Select the barcode index by |Select the barcode index by |default then searching for |default when searching for |label items. |label items -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org