[Bug 14840] New: Added new cron script send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 Bug ID: 14840 Summary: Added new cron script send membership expiry reminder notices Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt@gmail.com Reporter: amitddng135@gmail.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Added new cron script "send membership expiry reminder notices" in crontab.example file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Added new cron script send |Added new cron script send |membership expiry reminder |membership expiry reminder |notices |notices in crontab.example | |file -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6810 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com --- Comment #1 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 42634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42634&action=edit Bug 14840 Added new cron script send membership expiry reminder notices in crontab.example file Added new cron script send membership expiryreminder notices in crontab.example file -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Robin: This cronjob is actually optional. Should we add it on a commented line to debian/koha-common.cron.daily ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 42651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42651&action=edit Bug 14840 Added new cron script send membership expiry reminder notices in crontab.example file Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42634|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Taking the liberty to move this to the next level right away. Only documentation. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 --- Comment #5 from Robin Sheat <robin@catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #2)
Robin: This cronjob is actually optional. Should we add it on a commented line to debian/koha-common.cron.daily ?
So, in general I'm not a big fan of having people configure things by editing crontab files. In particular, it's hard for shared hosting. The ideal would be that the cronjob always runs and there's something (a syspref or whatever) that determines if it's enabled for a particular instance. However, doing that is clearly out of scope for a simple patch like this, so yeah, a commented out entry in debian/koha-common.cron.daily would be fine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Robin Sheat from comment #5)
(In reply to Marcel de Rooy from comment #2)
Robin: This cronjob is actually optional. Should we add it on a commented line to debian/koha-common.cron.daily ?
So, in general I'm not a big fan of having people configure things by editing crontab files. In particular, it's hard for shared hosting. The ideal would be that the cronjob always runs and there's something (a syspref or whatever) that determines if it's enabled for a particular instance.
However, doing that is clearly out of scope for a simple patch like this, so yeah, a commented out entry in debian/koha-common.cron.daily would be fine.
Thanks, Robin. Amit: If your pref would default to zero and this would mean "do nothing" and a nonzero value would trigger the process, we could just always run the script. What do you think ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42651|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 42701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42701&action=edit Bug 14840 Added new cron script send membership expiry reminder notices in crontab.example file Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended: Added koha-common.cron.daily. Note that the cronjob only does something when the pref is set now. See corresponding change on bug 6810. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6810 CC| |tomascohen@gmail.com See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6810 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 [Bug 6810] Send membership expiry reminder notices -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Amit! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Added new cron script send |Add new cronjob to send |membership expiry reminder |membership expiry reminder |notices in crontab.example |notices in crontab.example |file |file -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org