[Bug 6616] New: Move common table pager markup to include
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6616 Bug #: 6616 Summary: Move common table pager markup to include Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: enhancement Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org The table pager markup used in conjunction with the tablesorter javascript is virtually the same in each template which uses it. I propose a new include file to contain it. We can use T:T's ability to define variables in an [% INCLUDE %] directive to pass the default page size in each case: [% INCLUDE 'table-pager.inc' perpage='20' %] -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6616 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-07-20 18:30:44 UTC --- Created attachment 4686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4686 Proposed fix Unique changes in branch_transfer_limits.tt: - Moved tablesorter configuration out of a loop and changed it to work by class instead of id (less repeated markup). - Corrected an errant TMPL tag. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4686|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-07-20 18:46:18 UTC --- Created attachment 4687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4687 Revised fix Revised fix moves div with "pager" class to the include to allow consistent styling. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4687|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-07-27 20:33:20 UTC --- Created attachment 4757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4757 [SIGNED-OFF] Fix for Bug 6616 - Move common table pager markup to include Created new include for the tablesorter pager markup: [% INCLUDE 'table-pager.inc' perpage='20' %] 'perpage' variable defines the default items per page for the paged table. Unique changes in branch_transfer_limits.tt: - Moved tablesorter configuration out of a loop and changed it to work by class instead of id (less repeated markup). - Corrected an errant TMPL tag. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked: - Home › Administration › Authority MARC Framework: Default Framework - Home › Administration › Authorized values - Home › Administration › Set Library Checkin and Transfer Policy - Home › Administration › Libraries and Groups - Home › Administration › Patron Categories - Home › Administration › Cities - Home › Administration › Item Types Administration - Home › Administration › MARC Frameworks › Default MARC framework - Home › Reports › Guided Reports Wizard › Saved Reports - Home › Patrons › Circulation History for Koha Admin No problems found. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Signed Off --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-07-27 20:36:20 UTC --- Signed off, works as expected. A note: The plugin shows current page/pages total in an input box. You can edit this box and put something else in there. For example, change 1/12 into 3/12. This will not work. Perhaps the styling could be changed so the box shows not as a normal input field that you can edit. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6689 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6616 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-06 12:44:57 UTC --- QA comment Seems there is a problem with the patch: 14:43 ~/koha.dev/koha-community (BZ6616 $%)$ git bz apply 6616 Bug 6616 - Move common table pager markup to include [SIGNED-OFF] Fix for Bug 6616 - Move common table pager markup to include Apply? [yn] y fatal: cannot convert from UTF-8utf-8 to UTF-8 Looking at it, there's something strange: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" the both text/plain strings are probably the cause of the problem.Marking failed QA Otherwise, i had been happy to mark passed QA, it's a html-only patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6616 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4757|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> 2011-10-06 13:22:24 UTC --- Created attachment 5737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5737 Revised fix Looks like a problem in patch formatting. I've rebased the patch against current master and reformatted it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6616 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-06 13:27:51 UTC --- This is probably caused by something in my installation - it only occurs sometimes in not in general. Would appreciate any hints how to fix that. Can we say the sign-off still stands if the only difference between original patch and signed-off is that? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6616 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-06 13:37:30 UTC --- Created attachment 5738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5738 [SIGNED-OFF]Fix for Bug 6616 - Move common table pager markup to include Created new include for the tablesorter pager markup: [% INCLUDE 'table-pager.inc' perpage='20' %] 'perpage' variable defines the default items per page for the paged table. Unique changes in branch_transfer_limits.tt: - Moved tablesorter configuration out of a loop and changed it to work by class instead of id (less repeated markup). - Corrected an errant TMPL tag. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6616 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5737|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6616 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Passed QA --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-06 13:38:22 UTC --- QA comment: patch now applies, template only change, nothing to say from a QA pov -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6616 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com --- Comment #10 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-06 19:13:15 UTC --- Template only change, increases consistency and reusability. Issue with the field being editable, but unusable, can be moved to a separate bug report (solved either by making it work, or making it read only). Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6616 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> 2011-10-06 19:34:44 UTC --- The patch for Bug 6689 will include a cosmetic fix to address the editable field issue. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6616 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-09 07:08:58 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org