[Bug 7330] New: System preferences editor generates errors in the log with each search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7330 Bug #: 7330 Summary: System preferences editor generates errors in the log with each search Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration AssignedTo: paul.poulain@biblibre.com ReportedBy: oleonard@myacpl.org QAContact: ian.walls@bywatersolutions.com CC: gmcharlt@gmail.com When you search system preferences errors are generated in the log: preferences.pl: Use of uninitialized value in pattern match (m//) at /admin/preferences.pl line 219. preferences.pl: Use of uninitialized value $text in pattern match (m//) at /admin/preferences.pl line 252. preferences.pl: Use of uninitialized value $text in pattern match (m//) at /admin/preferences.pl line 252. preferences.pl: Use of uninitialized value $text in pattern match (m//) at /admin/preferences.pl line 252. preferences.pl: Use of uninitialized value in pattern match (m//) at /admin/preferences.pl line 219. preferences.pl: Use of uninitialized value $text in pattern match (m//) at /admin/preferences.pl line 252. preferences.pl: Use of uninitialized value $text in pattern match (m//) at /admin/preferences.pl line 252. preferences.pl: Use of uninitialized value $text in pattern match (m//) at /admin/preferences.pl line 252. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7330 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|paul.poulain@biblibre.com |oleonard@myacpl.org -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7330 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-12-07 15:56:26 UTC --- Created attachment 6638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6638 Proposed fix Adding a check for an empty value in a couple of places which seem to always get one. As far as I can tell these places in the script are looping over ALL the data in the pref files, and sometimes an empty value comes through. I wonder if this is because of a minor syntax error in the pref file? My correction is a stab in the dark since I haven't determined where the empty value is actually coming from. This change quiets the errors in the log and doesn't seem to affect preference search results. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7330 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7330 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6638|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7330 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7330 --- Comment #2 from Liz Rea <wizzyrea@gmail.com> 2011-12-08 20:55:56 UTC --- Created attachment 6680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6680 Bug 7330 - System preferences editor generates errors in the log with each search Adding a check for an empty value in a couple of places which seem to always get one. As far as I can tell these places in the script are looping over ALL the data in the pref files, and sometimes an empty value comes through. I wonder if this is because of a minor syntax error in the pref file? My correction is a stab in the dark since I haven't determined where the empty value is actually coming from. This change quiets the errors in the log and doesn't seem to affect preference search results. Signed-off-by: Liz Rea <wizzyrea@gmail.com> No more messages in the logs. Yay! Ran unit tests on this (t, xt/author, xt, t/db_dependent)- nothing out of the ordinary in any. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7330 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_8 Patch Status|Signed Off |Patch Pushed --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-15 16:37:13 UTC --- QA comment: well I feel I shouldn't accept a patch that says "fixes the problem, but I don't know why"... OTH, preferences.pl is poorly documented, it fixes the problem, and I couldn't find any side effect. I couldn't understand why those empty values are here though. So: passed QA patch pushed, please test chris_n = I would wisely say "don't push this on 3.6. If there is a side effect we couldn't detect, we can hope someone else will spot it in the next 4 months before 3.8 is released" -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7330 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org