http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6695 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-08-10 15:25:05 UTC --- Created attachment 4944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4944 Revised fix The markup for the fields for enrollment period "in months" and "until date" was non-standard I think because the two fields are supposed to be visually and functionally linked (having the same purpose and being mutually exclusive). This patch changes the markup so that the two fields share a fieldset having "choose one" as the legend. The "hint" is now hidden unless it is triggered by the javascript validation on submit. I wanted to trigger the validation of the two fields onblur instead of just onsubmit, but found that the datepicker widget doesn't consistently trigger a change or a blur event on that field. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6695 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4944|Revised fix |Proposed fix description| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6695 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4944|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-11 17:37:45 UTC --- Created attachment 4970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4970 [SIGNED-OFF] Fix for Bug 6695 - Layout of patron category add/edit form slightly broken The markup for the fields for enrollment period "in months" and "until date" was non-standard I think because the two fields are supposed to be visually and functionally linked (having the same purpose and being mutually exclusive). This patch changes the markup so that the two fields share a fieldset having "choose one" as the legend. The "hint" is now hidden unless it is triggered by the javascript validation on submit. I wanted to trigger the validation of the two fields onblur instead of just onsubmit, but found that the datepicker widget doesn't consistently trigger a change or a blur event on that field. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> - Layout problems are fixed - Layout is more clear about choosing either 'In months' or 'Until date' - Clear error message shows when you enter values in both fields -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6695 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #4 from Ian Walls <ian.walls@bywatersolutions.com> 2011-08-25 01:58:28 UTC --- Template only change, easy to read, well tested, marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6695 --- Comment #6 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-10-26 18:02:37 UTC --- The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.