[Bug 6555] New: only 10 lists in pull down when adding from a bib record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6555 Bug #: 6555 Summary: only 10 lists in pull down when adding from a bib record Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: cgi-bin/koha/virtualshelves/addbybiblionumber.pl?bibli onumber=3 OS/Version: All Status: NEW Severity: major Priority: P5 Component: Virtual Shelves AssignedTo: gmcharlt@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org Created attachment 4559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4559 10 lists instead of 12 (or all) I have attached a screenshot of the problem. We currently have 12 public lists (and I have 1 private list) but when I try to add to a list from within a bib record in the staff client, I only get a list of 10...and of course the one I need (Educations & Licensure) is not on it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6555 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |chris@bigballofwax.co.nz Severity|major |normal --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-29 02:29:45 UTC --- Works on OPAC, just not staff side, working on a fix now -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6555 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-29 02:42:44 UTC --- The problem comes from else { # this shelf doesn't already exist. my $limit = 10; Then it calls GetRecentShelves The opac, just calls GetAllShelves with no limit set I can change the intranet to match, would having no limit be a worry to anyone? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6555 --- Comment #3 from Nicole C. Engard <nengard@gmail.com> 2011-08-29 11:02:17 UTC --- If you didn't get all shelves, how would you add to shelves that aren't showing in the pull down - would you have to go to the list and add by barcode instead? I think if it works in the OPAC we should do the same in the staff client so that people can add to lists the same way in both places. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6555 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com --- Comment #4 from Ian Walls <ian.walls@bywatersolutions.com> 2011-08-29 14:04:25 UTC --- I agree with Nicole that the behaviour should be consistent. A more robust solution would be YASP (yet another system preference) to control how many titles are shown on the list. Even more, we could have two, one for OPAC and one for staff client. Not recommending this, just pointing it out as an option. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6555 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-08-29 14:07:10 UTC --- I don't think a system preference would be useful. The problem would remain: there wouldn't be any reasonable way for the user to add a title to one of the lists which wasn't shown. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6555 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-04 23:06:18 UTC --- Righto, ill just make show all for now someone if they feel so moved can do an enchancement to make it show some and then have a show all button if they feel so moved. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6555 --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-04 23:28:10 UTC --- Created attachment 5303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5303 Bug 6555 : only 10 lists show in the staff client -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6555 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6555 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off AssignedTo|gmcharlt@gmail.com |chris@bigballofwax.co.nz --- Comment #8 from Nicole C. Engard <nengard@gmail.com> 2011-09-06 14:42:46 UTC --- this works, however there is still an issue on the search results in the staff client when adding to a list - but this bug didn't mention that. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6555 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5303|0 |1 is obsolete| | --- Comment #9 from Nicole C. Engard <nengard@gmail.com> 2011-09-06 14:43:14 UTC --- Created attachment 5319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5319 [SIGNED-OFF] Bug 6555 : only 10 lists show in the staff client Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6555 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #10 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-06 14:46:53 UTC --- Mostly an SQL change, with some params called differently depending on context. Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6555 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-06 21:07:12 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6555 --- Comment #12 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-10-26 18:02:34 UTC --- The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org