https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 Mehdi Hamidi <mehdi.hamidi@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mehdi.hamidi@inlibro.com Depends on| |17015 Assignee|koha-bugs@lists.koha-commun |mehdi.hamidi@inlibro.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 [Bug 17015] New Koha Calendar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 Mehdi Hamidi <mehdi.hamidi@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 --- Comment #2 from Mehdi Hamidi <mehdi.hamidi@inlibro.com> --- Created attachment 59522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59522&action=edit Bug 17983 - Enabled the use of minutes loan -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 --- Comment #4 from Mehdi Hamidi <mehdi.hamidi@inlibro.com> --- Forget to mention : run Koha tests to make sure everything still works properly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mehdi.hamidi@inlibro.com |david.bourgault@inlibro.com CC| |david.bourgault@inlibro.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59522|0 |1 is obsolete| | --- Comment #6 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 67881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67881&action=edit Bug 17983 - Enabled the use of minutes loan -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 --- Comment #8 from David Bourgault <david.bourgault@inlibro.com> --- A patch correcting errors in Bug 17015 (on which this bug depends) broke this bug. I rebased the patches to correct this, and corrected an error in minutes_loan.t which should now pass OK. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 --- Comment #10 from J Schmidt <jschmidt@switchinc.org> --- -Used sandbox 2 from ByWater. -Went to Koha admin > Added a new item type (EQUIP) -Saved those changes. -Went to Koha admin > Circ and fine rules > Select a library > Betatown. -Added a new loan rule for the Betatown library. -New loan rule was Patron category (All). Item type (EQUIP for Equipment). Current Checkouts allow (10). Current on-site checkouts allowed 10. Loan period 60 minutes. Hard due date skipped. Fine amount is 1.00. Fine charging interval is 60. When to charge. End of interval. Fine grace period is 120. Overdue fines cap is $10. Renewals allowed count is 1. Renewal period is 60. Automatic renewal is no. Holds allowed is 0...nothing else. loan rule saved. -Koha > Cataloging > New Record > Fast Add framework. Filled in minimal fields (245$a... couldn't find 100$a, 008)....Save. -Add item with the new EQUIP item type. Betatown being the permanent and current location....952$d, barcode is 39999000019209, 952$v $50.00, non public note. Click Add item to save the new item -Koha Check out > Test. -Checkout to test patron 29999000001016 using barcode 39999000019209 -Clicked checkout settings in advance of selecting the barcode but I'm not seeing the calendar to set the due date into the past....hmmm. -Having no calendar to set date due in past I click checkout. Equipment piece is due on 11/10/2017. -I go to Koha Set library changing myself to be Betatown. -Koha Tools > Calendar > betatown.... looks to be open for 10/11/17 -Koha Tools > Discrete calendar for betatown has no closed times added.... -Koha Checkin 39999000019209 equipment item. -Koha change test patron to be Betatown patron. -Checkout new piece of equipment 39999000019209 to Betatown test patron but no calendar displays allowing me to set date due in past. no ability to set any sort of hour either. Not able to go further with fines... etc. -Test failed. 10/11/17. jls. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 --- Comment #11 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 67969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67969&action=edit Expected due date entry field Following essentially the same steps as you I went to checkout the item and got the expected result. If I understand correctly, you are saying that under "checkout settings" you do not see a date entry field to set the due date, is that correct? I attached a picture of what it should look like/looks like on my machine. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 --- Comment #12 from J Schmidt <jschmidt@switchinc.org> --- (In reply to David Bourgault from comment #11)

Created attachment 67969 [details] Expected due date entry field

Following essentially the same steps as you I went to checkout the item and got the expected result. If I understand correctly, you are saying that under "checkout settings" you do not see a date entry field to set the due date, is that correct?

I attached a picture of what it should look like/looks like on my machine.

Yes, that is correct. I did not get that calendar shown in your attachment. I'm familiar with that calendar for checkout and the need to set it before actually checking out a specific item by barcode. No clicking I did brought up that calendar. I used Chrome... Sandbox 2.... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 --- Comment #14 from J Schmidt <jschmidt@switchinc.org> --- Hello, Trying this again...cleared browser cache..... --Sandbox3 from ByWater. --Login and set my library to be Betatown. --Go to Koha Admin > IUtem Types. Create a new item type for EQUIPMENT with EQUIP code. --Koha Admin > Circ and fine rules for Betatown. --Created a new loan rule for Library Betatown for all patrons using new EQUIP item type. Current checkouts allowed is 10; Current on-site checkouts allow is 10. Loan period is 60 minutes. No hard due date. Fine amount is 1.00 fine charging interval is 60 minutes. Charged at the END of interval. Fine grace period is 0. Overdue fines cap is $10.00. Renewaks allowed is 0. No automatic renewwal or holds... Saved loan rule. --Search the catalog for a record. Not seeing any records readily. I make a new brief bib on a default framework (filling in required fields like 942, 005, 040, etc.) and item record (952$a, b is betatown, item type is EQUIP, filled in replacement cost, date acquired...). Add item. --item barcode is 39999000019209 --Go to test patron, 29999000001016 to check out above item (Equip)... --Again no calendar to be found... See attached image. --Really do not think it's updated..... Hmmm. jen.s -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 --- Comment #16 from J Schmidt <jschmidt@switchinc.org> --- Created attachment 68017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68017&action=edit Bug 17983 part 2 screen capture, collapsed checkout options This goes with the last attachment. Screen shot for 17983 to show collapsed checkout options at the point of checkout. No calendar window triggered. I almost went into staff client JS to look for anything there.... FYI. jen. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67880|0 |1 is obsolete| | --- Comment #19 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 73353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73353&action=edit Bug 17983 - Add Minutes math to DiscreteCalendar -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67882|0 |1 is obsolete| | --- Comment #21 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 73355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73355&action=edit Bug 17983 - Tests for minutes loan -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73353|0 |1 is obsolete| | Attachment #73354|0 |1 is obsolete| | Attachment #73355|0 |1 is obsolete| | --- Comment #22 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 75480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75480&action=edit Bug 17983: Add minute loans Rebased patch: + Adds minute loans logic to DiscreteCalendar + Enables minutes loans in Koha code + Adds tests for minute loans -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Needs Signoff |BLOCKED --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Marking as BLOCKED because dependency is FQA. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 --- Comment #25 from shi-yao.wang@inLibro.com --- Created attachment 131930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131930&action=edit Bug 17983: Add minutes loan to DiscreteCalendar This is an additional feature to our new Discrete Calendar. Theses patches add the possibility to choose the loan unit as minutes in circulations rules. Test plan: - Apply patch of Bugzilla 17015 - Apply this patch. - Run test t/db_dependent/minutes_loan.t - Create new item type for the new rule. - Create circulation rule and fill the fields, make sure the unit is set to : minutes, choose the item type of the one created above.- - Checkout an item that follow the circulation rule and set due date in the past. - Run fines.pl. - Check if the correct amount was calculated. - Note: make sure to factor in the fine grace period if set and the system preference FinesIncludeGracePeriod.fixed patch tests and minor adjustments -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 shi-yao.wang@inLibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shi-yao.wang@inLibro.com Attachment #75480|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 shi-yao.wang@inLibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131931|0 |1 is obsolete| | --- Comment #27 from shi-yao.wang@inLibro.com --- Created attachment 131932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131932&action=edit Bug 17983: Add minutes loan to DiscreteCalendar This is an additional feature to our new Discrete Calendar. Theses patches add the possibility to choose the loan unit as minutes in circulations rules. Test plan: - Apply patch of Bugzilla 17015 - Apply this patch. - Run test t/db_dependent/minutes_loan.t - Create new item type for the new rule. - Create circulation rule and fill the fields, make sure the unit is set to : minutes, choose the item type of the one created above.- - Checkout an item that follow the circulation rule and set due date in the past. - Run fines.pl. - Check if the correct amount was calculated. - Note: make sure to factor in the fine grace period if set and the system preference FinesIncludeGracePeriod.fixed patch tests and minor adjustments -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131931|0 |1 is obsolete| | Attachment #131932|0 |1 is obsolete| | --- Comment #28 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 136414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136414&action=edit Bug 17983: Add minutes loan to DiscreteCalendar This is an additional feature to our new Discrete Calendar. Theses patches add the possibility to choose the loan unit as minutes in circulations rules. Test plan: - Apply patch of Bugzilla 17015 - Apply this patch. - Run test t/db_dependent/minutes_loan.t - Create new item type for the new rule. - Create circulation rule and fill the fields, make sure the unit is set to : minutes, choose the item type of the one created above.- - Checkout an item that follow the circulation rule and set due date in the past. - Run fines.pl. - Check if the correct amount was calculated. - Note: make sure to factor in the fine grace period if set and the system preference FinesIncludeGracePeriod.fixed patch tests and minor adjustments -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136414|0 |1 is obsolete| | Attachment #136415|0 |1 is obsolete| | --- Comment #30 from Blou <philippe.blouin@inlibro.com> --- Created attachment 139519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139519&action=edit Bug 17983: Add minutes loan to DiscreteCalendar This is an additional feature to our new Discrete Calendar. Theses patches add the possibility to choose the loan unit as minutes in circulations rules. Test plan: - Apply patch of Bugzilla 17015 - Apply this patch. - Run test t/db_dependent/minutes_loan.t - Create new item type for the new rule. - Create circulation rule and fill the fields, make sure the unit is set to : minutes, choose the item type of the one created above.- - Checkout an item that follow the circulation rule and set due date in the past. - Run fines.pl. - Check if the correct amount was calculated. - Note: make sure to factor in the fine grace period if set and the system preference FinesIncludeGracePeriod.fixed patch tests and minor adjustments -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144267|0 |1 is obsolete| | --- Comment #32 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 151452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151452&action=edit Bug 17983: Add minutes loan to DiscreteCalendar This is an additional feature to our new Discrete Calendar. Theses patches add the possibility to choose the loan unit as minutes in circulations rules. Test plan: - Apply patch of Bugzilla 17015 - Apply this patch. - Run test t/db_dependent/minutes_loan.t - Create new item type for the new rule. - Create circulation rule and fill the fields, make sure the unit is set to : minutes, choose the item type of the one created above.- - Checkout an item that follow the circulation rule and set due date in the past. - Run fines.pl. - Check if the correct amount was calculated. - Note: make sure to factor in the fine grace period if set and the system preference FinesIncludeGracePeriod.fixed patch tests and minor adjustments -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167846|0 |1 is obsolete| | --- Comment #34 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 180308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180308&action=edit Bug 17983: Add minutes loan to DiscreteCalendar This is an additional feature to our new Discrete Calendar. Theses patches add the possibility to choose the loan unit as minutes in circulations rules. Test plan: - Apply patch of Bugzilla 17015 - Apply this patch. - Run test t/db_dependent/minutes_loan.t - Create new item type for the new rule. - Create circulation rule and fill the fields, make sure the unit is set to : minutes, choose the item type of the one created above.- - Checkout an item that follow the circulation rule and set due date in the past. - Run fines.pl. - Check if the correct amount was calculated. - Note: make sure to factor in the fine grace period if set and the system preference FinesIncludeGracePeriod.fixed patch tests and minor adjustments -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180308|0 |1 is obsolete| | --- Comment #35 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 185854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185854&action=edit Bug 17983: Add minutes loan to DiscreteCalendar This is an additional feature to our new Discrete Calendar. Theses patches add the possibility to choose the loan unit as minutes in circulations rules. Test plan: - Apply patch of Bugzilla 17015 - Apply this patch. - Run test t/db_dependent/minutes_loan.t - Create new item type for the new rule. - Create circulation rule and fill the fields, make sure the unit is set to : minutes, choose the item type of the one created above.- - Checkout an item that follow the circulation rule and set due date in the past. - Run fines.pl. - Check if the correct amount was calculated. - Note: make sure to factor in the fine grace period if set and the system preference FinesIncludeGracePeriod.fixed patch tests and minor adjustments -- You are receiving this mail because: You are watching all bug changes.