http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9759 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 15927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15927&action=edit Proposed patch See commit message -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9759 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15927|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15985&action=edit Bug 9759: last subfield can be deleted In authorities and biblios editors, a repeatable subfield can be deleted (small icon next to input). Clone subfields are really deleted but last existing subfield is just set empty instead of deleted. But when same field is repeated, the last subfield can be deleted. This patch corrects this, last subfield of a field, even repeated, can not be deleted. Test plan : - Edit a biblio - Choose a repeatable field with a repeatable subfield : ie 600 and $x - Edit 600, enter a text in $x : ie "subA" - Clone $x - Delete second $x => second $x is deleted - Delete first $x => $x is not deleted but set empty - Edit 600, enter a text in $x : ie "subA" - Clone 600 - Edit second 600, enter a text in $x : ie "subB" - Clone $x of second 600 - Delete second $x of second 600 => second $x of second 600 is deleted - Delete first $x of second 600 => with this patch : first $x of second 600 is set empty => without this patch : first $x of second 600 is deleted, second 600 has no $x anymore Perform same test plan on an authority. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9759 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9759 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15985|0 |1 is obsolete| | --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17028&action=edit Bug 9759: last subfield can be deleted In authorities and biblios editors, a repeatable subfield can be deleted (small icon next to input). Clone subfields are really deleted but last existing subfield is just set empty instead of deleted. But when same field is repeated, the last subfield can be deleted. This patch corrects this, last subfield of a field, even repeated, can not be deleted. Test plan : - Edit a biblio - Choose a repeatable field with a repeatable subfield : ie 600 and $x - Edit 600, enter a text in $x : ie "subA" - Clone $x - Delete second $x => second $x is deleted - Delete first $x => $x is not deleted but set empty - Edit 600, enter a text in $x : ie "subA" - Clone 600 - Edit second 600, enter a text in $x : ie "subB" - Clone $x of second 600 - Delete second $x of second 600 => second $x of second 600 is deleted - Delete first $x of second 600 => with this patch : first $x of second 600 is set empty => without this patch : first $x of second 600 is deleted, second 600 has no $x anymore Perform same test plan on an authority. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9759 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9759 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- When testing, you may need to refresh (Ctrl+F5) for clearing the cached js. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9759 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes.