[Bug 9720] New: uninitialized value warnings in circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9720 Bug ID: 9720 Summary: uninitialized value warnings in circulation Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.somers@biblibre.com CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Like said in Bug 5727 : A lot of 'Use of uninitialized value in concatenation (.) or string' pollute log files and make them unreadable. This warnings must be corrected in most used pages of circulation/members module. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9720 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5727 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9720 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 15725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15725&action=edit Proposed patch Patch for circulation.pl. See commit comment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9720 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15725|Proposed patch |Proposed patch description| |(circulation) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9720 --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 15726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15726&action=edit Proposed patch (members) Patch for member pages. See commit comment -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9720 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9720 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15725|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15735&action=edit Bug 9720 : uninitialized value warnings in circulation This patch corrects several uninitialized value errors. Test plan: - Go to check out page - Check that issues and old issues are in different tables - Check that author is diplayed if exists - Check that patron address is displayed if exists - Perform a checkout Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9720 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9720 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15726|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15736&action=edit Bug 9720 : uninitialized value warnings in circulation (followup 1) This patch corrects several uninitialized value errors. Test plan: - Edit a borrower - Enter a surname using lowercase (it will be displayed uppercase by CSS) and save => Borrower surname is uppercase - Edit an organisation (depends on borrower category) - Enter a surname using lowercase (it will be displayed uppercase by CSS) and save => Borrower surname is uppercase - Go to a borrower page who has today issues - Click on More/Export today's checked in barcodes => You get a file to dowload Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9720 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9720 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15735|0 |1 is obsolete| | Attachment #15736|0 |1 is obsolete| | --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17026&action=edit Bug 9720 : uninitialized value warnings in circulation This patch corrects several uninitialized value errors. Test plan: - Go to check out page - Check that issues and old issues are in different tables - Check that author is diplayed if exists - Check that patron address is displayed if exists - Perform a checkout Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9720 --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17027&action=edit Bug 9720 : uninitialized value warnings in circulation (followup 1) This patch corrects several uninitialized value errors. Test plan: - Edit a borrower - Enter a surname using lowercase (it will be displayed uppercase by CSS) and save => Borrower surname is uppercase - Edit an organisation (depends on borrower category) - Enter a surname using lowercase (it will be displayed uppercase by CSS) and save => Borrower surname is uppercase - Go to a borrower page who has today issues - Click on More/Export today's checked in barcodes => You get a file to dowload Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9720 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9720 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: I am certainly in favor of removings warns! One small point: $data{'surname'} &&= uc( $data{'surname'} ); This is not a very clear construct. But it works. An if reads better.. Nothing to say. Looks good. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9720 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9720 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. There are still some uninitialized value warnings in circ, but fewer: Use of uninitialized value in string ne at /home/jcamins/kohaclone/circ/circulation.pl line 393. Use of uninitialized value in string eq at /home/jcamins/kohaclone/circ/circulation.pl line 399. Use of uninitialized value in sprintf at /home/jcamins/kohaclone/circ/circulation.pl line 453. Use of uninitialized value in sprintf at /home/jcamins/kohaclone/circ/circulation.pl line 453. (if you decide to work on them, please open a new bug) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9720 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org