[Bug 10416] New: Correct template markup problems on course detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10416 Bug ID: 10416 Summary: Correct template markup problems on course detail page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/course_reserves/course-details.pl?course _id=X OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org There are issues with validity and consistency on the course reserves course detail page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10416 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10416 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18673&action=edit Bug 10416 - Correct template markup problems on course detail page This patch corrects several problems with the course reserves course detail page: - Unescaped ampersands - Extra </div> - Incorrect text in title tag - Use of a table to display information which is more consistently displayed as a list. - More accurate alert message, "Are you sure you want to remove this item from the course?" rather than "Are you sure you want to delete this item?" - Missing icons from toolbar buttons To test, apply the patch and view the details of an existing course (Course reserves -> [Course name]). Confirm that these changes are present and look like an improvement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10416 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10416 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18673|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 18741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18741&action=edit Bug 10416 - Correct template markup problems on course detail page This patch corrects several problems with the course reserves course detail page: - Unescaped ampersands - Extra </div> - Incorrect text in title tag - Use of a table to display information which is more consistently displayed as a list. - More accurate alert message, "Are you sure you want to remove this item from the course?" rather than "Are you sure you want to delete this item?" - Missing icons from toolbar buttons To test, apply the patch and view the details of an existing course (Course reserves -> [Course name]). Confirm that these changes are present and look like an improvement. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> The course details screen looks much more consistent with other parts of Koha now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10416 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10416 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18741|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19021&action=edit Bug 10416 - Correct template markup problems on course detail page This patch corrects several problems with the course reserves course detail page: - Unescaped ampersands - Extra </div> - Incorrect text in title tag - Use of a table to display information which is more consistently displayed as a list. - More accurate alert message, "Are you sure you want to remove this item from the course?" rather than "Are you sure you want to delete this item?" - Missing icons from toolbar buttons To test, apply the patch and view the details of an existing course (Course reserves -> [Course name]). Confirm that these changes are present and look like an improvement. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> The course details screen looks much more consistent with other parts of Koha now. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, template only changes. Everything checks our and works as advertised. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10416 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19021|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19022&action=edit Bug 10416 - Correct template markup problems on course detail page Fixed typo in commit message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10416 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org