http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10418 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18675&action=edit Bug 10418 - Correct template markup problems on course reserves add item page This patch corrects several problems with the course reserves add item pages: - Non-standard grid markup. - Extra </div>. - Incorrect styling of errors and messages. - Redundant JS for adding focus to a field (use "focus" class). - Invalid use of <label> with no corresponding input (use <span class="label"> instead). - Incorrect capitalization. To test, apply the patch and examing both steps of the process of adding an item to an existing course: The initial "scan barcode" form, and the form for editing details of a scanned item. Some cases to check: - Scan an invalid barcode. - Scan a barcode which has already been added to a course. - Scan a barcode wihch has already been added to the course you're working with. Forms should look correct and work correctly. This patch contains whitespace changes, so please ignore whitespace when examining changes. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10418 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18675|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 18738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18738&action=edit Bug 10418 - Correct template markup problems on course reserves add item page This patch corrects several problems with the course reserves add item pages: - Non-standard grid markup. - Extra </div>. - Incorrect styling of errors and messages. - Redundant JS for adding focus to a field (use "focus" class). - Invalid use of <label> with no corresponding input (use <span class="label"> instead). - Incorrect capitalization. To test, apply the patch and examing both steps of the process of adding an item to an existing course: The initial "scan barcode" form, and the form for editing details of a scanned item. Some cases to check: - Scan an invalid barcode. - Scan a barcode which has already been added to a course. - Scan a barcode wihch has already been added to the course you're working with. Forms should look correct and work correctly. This patch contains whitespace changes, so please ignore whitespace when examining changes. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> The add item screen continues to work as before. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10418 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18738|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19020&action=edit Bug 10418 - Correct template markup problems on course reserves add item page This patch corrects several problems with the course reserves add item pages: - Non-standard grid markup. - Extra </div>. - Incorrect styling of errors and messages. - Redundant JS for adding focus to a field (use "focus" class). - Invalid use of <label> with no corresponding input (use <span class="label"> instead). - Incorrect capitalization. To test, apply the patch and examing both steps of the process of adding an item to an existing course: The initial "scan barcode" form, and the form for editing details of a scanned item. Some cases to check: - Scan an invalid barcode. - Scan a barcode which has already been added to a course. - Scan a barcode wihch has already been added to the course you're working with. Forms should look correct and work correctly. This patch contains whitespace changes, so please ignore whitespace when examining changes. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> The add item screen continues to work as before. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl. Works as advertised. -- You are receiving this mail because: You are watching all bug changes.