[Bug 10993] New: Transfer limits should be checked when placing a hold/reservation.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Bug ID: 10993 Summary: Transfer limits should be checked when placing a hold/reservation. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: olli-antti.kivilahti@jns.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If a Borrower cannot get an Item transfered to his pickup location of choice, the Borrower needs to know that before he places a hold. This is especially true when placing Item-level holds. If a patron can place a hold on an item, he expects the item to be available at his pickup location of choice. Currently there is no warning or hold block for holds that violate the UseBranchTransferLimits-setting. Solution. Create or use an existing centralized CheckBranchTransferLimits-function inside the C4::Reserves::CanItemBeReserved(), to see if an item can be reserved for the desired pickup location. When the borrower changes his pickup location in koha/opac-reserve.pl?biblionumber=xxx, the BranchTransferLimits need to be recalculated. UseBranchTransferLimits should also affect placing holds via the Restful API's. $pickuplocation is not always available in the Restful API -requests so we can use the Borrowers homebranch as the default pickup location. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Assignee|koha-bugs@lists.koha-commun |olli-antti.kivilahti@jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- BTW: Should this be optional? Is it against the initial spirit of UseBranchTransferLimits? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Also when a Patron is placing a hold, the Patron should be able to choose the pickup location even if there are no available/holdable Items in his home branch. So instead of failing to reach the "Place hold"-dialogue and choose the pickuplocation, the Patron should be sent to the koha/opac-reserve.pl?biblionumber=xxx with a notifcation that no items are available to his pickup location, prompting the Patron to choose another pickup location. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11005 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Transfer limits should be |Transfer limits should be |checked when placing a |checked when placing a |hold/reservation. |hold/reservation in OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 --- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 21891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21891&action=edit Bug 10993 [ENH] - Transfer limits should be checked when placing a hold/reservation in OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 --- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 21892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21892&action=edit quickie test document -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11020 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11024 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 --- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Sponsored by the Joensuu Regional Library -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11020 | Depends on| |11020 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 --- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 22000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22000&action=edit Bug 10993 - Transfer limits should be checked when placing a hold/reservation in OPAC. Depends on bug 11005, 11020 Prevents a user from placing holds on material whose branch transfer is denied. Displays clear messages that items are unavailable and re-checks in the business layer in case of UI blocks failing. Enables choosing another pickup location. Manual tests included. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21891|0 |1 is obsolete| | Attachment #21892|0 |1 is obsolete| | --- Comment #7 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 22001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22001&action=edit Manual test cases -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11024 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Some QA comments about this patch (I haven't tested, just looking at the code) * you must use 4 spaces and not tabs * +1 for the "manual test case". Note that we use the term "test plan". It could confuse some tester that are not english natives & could search the test plan No other code or patch comment (which does not mean passed QA yet, I haven't tested it either) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22000|0 |1 is obsolete| | --- Comment #9 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 22322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22322&action=edit Bug 10993 - Transfer limits should be checked when placing a hold/reservation in OPAC. Depends on bug 11005, 11020 Prevents a user from placing holds on material whose branch transfer is denied. Displays clear messages that items are unavailable and re-checks in the business layer in case of UI blocks failing. Enables choosing another pickup location. Manual test plan included. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 --- Comment #10 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Fixed tabs to spaces in indentation. Didn't realize my IDE uses tabs instead of spaces until bug 11024/7376. Not sure about templates since they are such a mess regarding indentation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11020 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11020 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22322|0 |1 is obsolete| | --- Comment #11 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 23163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23163&action=edit Bug 10993 - Transfer limits should be checked when placing a hold/reservation in OPAC. Depends on bug 11005, 11020 Prevents a user from placing holds on material whose branch transfer is denied. Displays clear messages that items are unavailable and re-checks in the business layer in case of UI blocks failing. Enables choosing another pickup location. Manual test plan included. Formatted with perltidy and Perl::Critic level 5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- trying to test this patch during hackfest KohaCon14. Unfortunately, it does not apply : fatal: sha1 information is lacking or useless (C4/Circulation.pm). Another problem: you're mixed "real", "new" code and reindent/perlity. This patch cannot be QAed. I encourage you to perltidy/reindent, but in a separate patch please. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|olli-antti.kivilahti@jns.fi |koha-bugs@lists.koha-commun | |ity.org --- Comment #13 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Sorry, I cannot work on this currently. I will let this slide to the next one who encounters this issue and wants to fix it. Hopefully using some of my code :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Olli-Antti Kivilahti from comment #13)
Sorry, I cannot work on this currently. I will let this slide to the next one who encounters this issue and wants to fix it. Hopefully using some of my code :)
I felt like fainting getting half way through with no sign of any obvious changes, except for white space. Do you have time to make reading and testing it more feasible? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org