[Bug 13869] New: Wrong capitalization on guided reports page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869 Bug ID: 13869 Summary: Wrong capitalization on guided reports page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: katrin.fischer@bsz-bw.de Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org On the last step of saving a new guided report to the database, the button is labelled "Save Report", but should be "Save report". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36996&action=edit Bug 13869: Wrong capitalization of 'Save Report' in guided reports On the last step of saving a new guided report to the database, the button is labelled 'Save Report', but should be 'Save report'. To test: - Create a new guided report from the reports page - Check on the very last step, when saving the report to the database, the button is labelled 'Save Report' - With the patch applied, this reads 'Save report' instead http://bugs.koha-community.org/show_bug.cgi?id=13868 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Please test carefully -- In Guided Reports the label on the button might be used as a parameter by the script for determining what action to take. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Good point Owen - I avoided changing other occurrences and only changed the value that is getting translated. So I hope the change is save. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 37050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37050&action=edit [Signed-off] Bug 13869: Wrong capitalization of 'Save Report' in guided reports On the last step of saving a new guided report to the database, the button is labelled 'Save Report', but should be 'Save report'. To test: - Create a new guided report from the reports page - Check on the very last step, when saving the report to the database, the button is labelled 'Save Report' - With the patch applied, this reads 'Save report' instead http://bugs.koha-community.org/show_bug.cgi?id=13868 Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #36996|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37050|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37308&action=edit [PASSED QA] Bug 13869: Wrong capitalization of 'Save Report' in guided reports On the last step of saving a new guided report to the database, the button is labelled 'Save Report', but should be 'Save report'. To test: - Create a new guided report from the reports page - Check on the very last step, when saving the report to the database, the button is labelled 'Save Report' - With the patch applied, this reads 'Save report' instead http://bugs.koha-community.org/show_bug.cgi?id=13868 Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Safe change. Script uses the "phase" variable which remains "Save Report" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org