[Bug 10283] New: Hide "many items" on second tab when using OpacSeparateHoldings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Bug ID: 10283 Summary: Hide "many items" on second tab when using OpacSeparateHoldings Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: magnus@enger.priv.no Depends on: 7674 As noted by Katrin on Bug 7674: "- if there are over 50 items in the holdings or Other holdings tab, the warning and link 'This record has many physical items. Click here to view them all.' is only shown for the first tab." If there are more than a given number of items, they do not display directly in the detail view in the OPAC, but the text and link "This record has many physical items. Click here to view them all." is displayed instead. Activating OpacSeparateHoldings separates holdings into two tabs. If there are manye items the text and link is shown on the first tab (showing the items that belong to the library of the logged in suer), but the second tab (showing items at all other libraries) show the full list, not the text and link. This makes the initial display of the detail page veeery slow, when there are a lot if items (I have tested with ~3000 items). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18246&action=edit Bug 10283: Hide "many items" on second tab when using OpacSeparateHoldings If there are over 50 items in the holdings or Other holdings tab, the warning and link 'This record has many physical items. Click here to view them all.' is only shown for the first tab. Test plan: - Switch on the OpacSeparateHoldings pref. - Go on a biblio detail page at the OPAC with more than 50 items - Check that the 'view all' link appears on the second tab. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch Assignee|oleonard@myacpl.org |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18246|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 18591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18591&action=edit Bug 10283: Hide "many items" on second tab when using OpacSeparateHoldings If there are over 50 items in the holdings or Other holdings tab, the warning and link 'This record has many physical items. Click here to view them all.' is only shown for the first tab. Test plan: - Switch on the OpacSeparateHoldings pref. - Go on a biblio detail page at the OPAC with more than 50 items - Check that the 'view all' link appears on the second tab. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |srdjan@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18591|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19043&action=edit [PASSED QA] Bug 10283: Hide "many items" on second tab when using OpacSeparateHoldings If there are over 50 items in the holdings or Other holdings tab, the warning and link 'This record has many physical items. Click here to view them all.' is only shown for the first tab. Test plan: - Switch on the OpacSeparateHoldings pref. - Go on a biblio detail page at the OPAC with more than 50 items - Check that the 'view all' link appears on the second tab. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11255 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org