[Bug 10445] New: SIP Server doesn't respect maxoutstanding system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Bug ID: 10445 Summary: SIP Server doesn't respect maxoutstanding system preference Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle.m.hall@gmail.com CC: colin.campbell@ptfs-europe.com The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds ( terrible naming on this one ). However, although the Koha OPAC respects this preference, placing holds via a SIP2 device will not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18841&action=edit Bug 10445 - SIP Server doesn't respect maxoutstanding system preference The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds ( terrible naming on this one ). However, although the Koha OPAC respects this preference, placing holds via a SIP2 device will not. Test Plan: 1) Set maxoutstanding to $10 2) Pick a patron owning more than $10 in fees 3) Attempt to place a hold for this patron from a SIP2 device This attempt should succeed 4) Apply this patch 5) Restart your SIP2 server 6) Attempt to place a hold for this patron from a SIP2 device again This attempt should now fail -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle.m.hall@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18841|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18842&action=edit Bug 10445 - SIP Server doesn't respect maxoutstanding system preference The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds ( terrible naming on this one ). However, although the Koha OPAC respects this preference, placing holds via a SIP2 device will not. Test Plan: 1) Set maxoutstanding to $10 2) Pick a patron owning more than $10 in fees 3) Attempt to place a hold for this patron from a SIP2 device This attempt should succeed 4) Apply this patch 5) Restart your SIP2 server 6) Attempt to place a hold for this patron from a SIP2 device again This attempt should now fail -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10446 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18842|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19203&action=edit Bug 10445 - SIP Server doesn't respect maxoutstanding system preference The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds ( terrible naming on this one ). However, although the Koha OPAC respects this preference, placing holds via a SIP2 device will not. Test Plan: 1) Set maxoutstanding to $10 2) Pick a patron owning more than $10 in fees 3) Attempt to place a hold for this patron from a SIP2 device This attempt should succeed 4) Apply this patch 5) Restart your SIP2 server 6) Attempt to place a hold for this patron from a SIP2 device again This attempt should now fail Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Who on the QA team (except for Chris and Kyle) knows how to test SIP or can teach me? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10446 | Depends on| |10446 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, I am working on testing the SIP2 patches - it would speed things up quite a bit if you could provide me with a test script or some example SIP messages for placing holds. For an example of a test script see bug 10817. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |brendan@bywatersolutions.co | |m --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- FAIL C4/SIP/ILS.pm OK pod OK forbidden patterns FAIL valid Compilation failed in require Global symbol "$self" requires explicit package name OK critic FAIL C4/SIP/ILS/Patron.pm OK pod OK forbidden patterns FAIL valid C4/SIP/ILS/Patron.pm had compilation errors. Global symbol "$self" requires explicit package name OK critic -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22143&action=edit Bug 10445 - SIP Server doesn't respect maxoutstanding system preference - QA Followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19203|0 |1 is obsolete| | Attachment #22143|0 |1 is obsolete| | --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 22145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22145&action=edit [PASSED-QA] Bug 10445 - SIP Server doesn't respect maxoutstanding system preference The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds ( terrible naming on this one ). However, although the Koha OPAC respects this preference, placing holds via a SIP2 device will not. Test Plan: 1) Set maxoutstanding to $10 2) Pick a patron owning more than $10 in fees 3) Attempt to place a hold for this patron from a SIP2 device This attempt should succeed 4) Apply this patch 5) Restart your SIP2 server 6) Attempt to place a hold for this patron from a SIP2 device again This attempt should now fail Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22145|0 |1 is obsolete| | --- Comment #9 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 22146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22146&action=edit [PASSED-QA] Bug 10445 - SIP Server doesn't respect maxoutstanding system preference The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds ( terrible naming on this one ). However, although the Koha OPAC respects this preference, placing holds via a SIP2 device will not. Test Plan: 1) Set maxoutstanding to $10 2) Pick a patron owning more than $10 in fees 3) Attempt to place a hold for this patron from a SIP2 device This attempt should succeed 4) Apply this patch 5) Restart your SIP2 server 6) Attempt to place a hold for this patron from a SIP2 device again This attempt should now fail Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 --- Comment #10 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 22147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22147&action=edit [PASSED-QA] Bug 10445 - SIP Server doesn't respect maxoutstanding system preference - QA Followup Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Followup to failed QA tests have helped pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org