[Bug 29722] New: Add some diversity to sample quotes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Bug ID: 29722 Summary: Add some diversity to sample quotes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Currently all of the sample quotes are by US Presidents and were all said by white men. It would be great to see some diversity in these sample quotes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 128643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128643&action=edit Bug 29722: Add more sample quotes This patch adds sample quotes from women, women of colour, trans women, Black and Indigenous women, and people who weren't US Presidents! To test: 1. Install a fresh Koha and import sample quotes 2. Go to Tools -> Quote editor 3. Confirm the quotes show Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Text to go in the| |This patch adds sample release notes| |quotes from women, women of | |colour, trans women, Black | |and Indigenous women, and | |people who weren't US | |Presidents! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I really love this, thx Aleisha! I had tried to get people to send me quotes at one of the GBSD days, but sadly that didn't work out. Glad to see more diversity, will try to test (or better QA). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Hayley Pelham <hayleypelham@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |hayleypelham@catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128643|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 128848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128848&action=edit Bug 29722: Add more sample quotes This patch adds sample quotes from women, women of colour, trans women, Black and Indigenous women, and people who weren't US Presidents! To test: 1. Install a fresh Koha and import sample quotes 2. Go to Tools -> Quote editor 3. Confirm the quotes show Sponsored-by: Catalyst IT Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128848|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 129235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129235&action=edit Bug 29722: Add more sample quotes This patch adds sample quotes from women, women of colour, trans women, Black and Indigenous women, and people who weren't US Presidents! To test: 1. Install a fresh Koha and import sample quotes 2. Go to Tools -> Quote editor 3. Confirm the quotes show Sponsored-by: Catalyst IT Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was aiming to mostly work on bug fixes... but this is kind of a bug fix for me :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- For another enhancement: we should add a wikipedia link to help discover less known persons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 129712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129712&action=edit Bug 29722: (QA follow-up) Replace unusual single quote -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- I found an unusual single quote character in n°44. Looks like it works but it is more consistent to use usual single quote. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in| | --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Love this patch, but please keep in mind that strings added to the installer are now showing up in translations on pootle too (which is pretty awesome, but means they are string changes :) ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #12)
Love this patch, but please keep in mind that strings added to the installer are now showing up in translations on pootle too (which is pretty awesome, but means they are string changes :) )
My apologies for that! For some reason I thought these didn't get translated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks a lot for more quotes, and cool ones! :D Some of the old ones are really obnoxious >_<
For some reason I thought these didn't get translated.
It depends on the translators. On Canada's french and France's french they are just copied as is. Maybe that might change once we reach 100% -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version(s)|22.05.00,21.11.03,21.05.11 |22.05.00,21.11.03,21.05.11, released in| |20.11.16 Status|Pushed to oldstable |RESOLVED --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 20.11.x branch for 20.11.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #16 from wainuiwitikapark@catalyst.net.nz --- Does this need to be backported to 19.11.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 --- Comment #17 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to wainuiwitikapark from comment #16)
Does this need to be backported to 19.11.x?
Completely up to you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 --- Comment #18 from wainuiwitikapark@catalyst.net.nz --- Not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.03,21.05.11, |22.05.00,21.11.03,21.05.11, released in|20.11.16 |20.11.17 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org