[Bug 29862] New: TestBuilder.t fails with ES enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Bug ID: 29862 Summary: TestBuilder.t fails with ES enabled Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org To reproduce: kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/TestBuilder.t t/db_dependent/TestBuilder.t .. 7/15 Invalid MARC field expression: nHiaHpae3NgZlIHLjw1aOK4orw_8D8Af9R8WOo4cDSyifeMJyb2e_s2UzLX_EJHr7i01S1P4uyRIwHzyQRp2xogLJamtpafxr73jNPmoKuxhtgbEUhXuNUdUWG8GquTLhIHSNixvJCboujpzt6j2f8T5AcSxSbfPiNhKaAkMufwMVzQmsW26LUo3Y1cedm_aN9yQ9cwxNIqiwSjH1CiUg3IP2iwQSZdUJg57uCmDCcexDc6CDix at /kohadevbox/koha/C4/Biblio.pm line 306. # Looks like you planned 12 tests but ran 6. # Failed test 'Tests for delete method' # at t/db_dependent/TestBuilder.t line 302. Can't call method "biblionumber" on an undefined value at t/db_dependent/TestBuilder.t line 281. # Looks like your test exited with 11 just after 8. t/db_dependent/TestBuilder.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 8/15 subtests Test Summary Report ------------------- t/db_dependent/TestBuilder.t (Wstat: 2816 Tests: 8 Failed: 1) Failed test: 8 Non-zero exit status: 11 Parse errors: Bad plan. You planned 15 tests but ran 8. Files=1, Tests=8, 26 wallclock secs ( 0.02 usr 0.00 sys + 18.06 cusr 5.22 csys = 23.30 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129522&action=edit Bug 29862: Add missing txn begin/rollback in TestBuilder.t It fixes the tests when SearchEngine=ES t/db_dependent/TestBuilder.t .. 7/15 Invalid MARC field expression: l5ffglZ_upqqcwOvaiyALgXfyJw2Ot2AGRPUsiAPzSFHfd8J_hsnuQ8z75B8RKc_kyo2rFBp8BrPNwcM1FPhc01ngP01HU_Z7Rx1VHfcIcmrifYnjBDWNmYB9N5_4xEnxMH7ZhqC9b2Bz9wf9 wSEmx64x6t5xFFKX at /kohadevbox/koha/C4/Biblio.pm line 306. # Looks like you planned 12 tests but ran 6. # Failed test 'Tests for delete method' # at t/db_dependent/TestBuilder.t line 302. Can't call method "biblionumber" on an undefined value at t/db_dependent/TestBuilder.t line 281. # Looks like your test exited with 11 just after 8. Previous subtest created invalid date in the ES mappings. Test plan: Set SearchEngine=ES and run the tests, they must pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Assignee|chris@bigballofwax.co.nz |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129522|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129616&action=edit Bug 29862: Add missing txn begin/rollback in TestBuilder.t It fixes the tests when SearchEngine=ES t/db_dependent/TestBuilder.t .. 7/15 Invalid MARC field expression: l5ffglZ_upqqcwOvaiyALgXfyJw2Ot2AGRPUsiAPzSFHfd8J_hsnuQ8z75B8RKc_kyo2rFBp8BrPNwcM1FPhc01ngP01HU_Z7Rx1VHfcIcmrifYnjBDWNmYB9N5_4xEnxMH7ZhqC9b2Bz9wf9 wSEmx64x6t5xFFKX at /kohadevbox/koha/C4/Biblio.pm line 306. # Looks like you planned 12 tests but ran 6. # Failed test 'Tests for delete method' # at t/db_dependent/TestBuilder.t line 302. Can't call method "biblionumber" on an undefined value at t/db_dependent/TestBuilder.t line 281. # Looks like your test exited with 11 just after 8. Previous subtest created invalid date in the ES mappings. Test plan: Set SearchEngine=ES and run the tests, they must pass. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works for me... signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in| | --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.03,21.05.11 |22.05.00,21.11.03,21.05.11, released in| |20.11.16 CC| |victor@tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 20.11.x branch for 20.11.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark@catalyst.net.nz --- Does this need to be backported to 19.11.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.03,21.05.11, |22.05.00,21.11.03,21.05.11, released in|20.11.16 |20.11.17 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org