[Bug 15339] New: TestBuilder build parameter warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Bug ID: 15339 Summary: TestBuilder build parameter warnings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: xarragon@gmail.com QA Contact: gmcharlt@gmail.com TestBuilder's build function ignores any parameters that it does not recognize. If the developer forgets to wrap the column values in a 'value' hashref he or she might waste time checking the code rather than the tests. This patch makes TestBuilder issue a warning whenever unregonized parameters are passed to build. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 --- Comment #1 from Martin Persson <xarragon@gmail.com> --- Created attachment 45527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45527&action=edit Bug 15339: TestBuilder warnings (code) Makes TestBuilder::build() alert the user when unreognized parameters are passed, which happens when the user supplies the column values directly, forgetting the 'value' hash. This patch holds the code changes. Examples of the kind of errors that it catches are in the tests (separate patch). Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 --- Comment #2 from Martin Persson <xarragon@gmail.com> --- Created attachment 45528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45528&action=edit Bug 15339: TestBuilder warnings (tests) Makes TestBuilder::build() alert the user when unreognized parameters are passed, which happens when the user supplies the column values directly, forgetting the 'value' hash. This patch contains the tests that doubles as a demonstration of the kind of error the patch is intended to prevent. Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Martin Persson <xarragon@gmail.com> --- Realized there are some shortcomings that I need to fix before this is worth looking at. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org