[Bug 14621] New: Messaging preferences table needs to be sorted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Bug ID: 14621 Summary: Messaging preferences table needs to be sorted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: larit@student.uef.fi QA Contact: testopia@bugs.koha-community.org I have been working with messaging preferences and I noticed a weird issue in Firefox on Ubuntu. On messaging preferences page, the table is unsorted and the content in rows are generated randomly on every page refresh. When you select/deselect checkboxes and refresh the page (without posting the changes), Firefox will remember your choices. Now the issue is that when the table is unsorted and the rows keep changing on page refresh, Firefox has trouble remembering your choices. This makes it appear as if the checkboxes are magically changing values on each page refresh. We need to have the items sorted in the table to prevent this from happening. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 --- Comment #1 from Lari Taskula <larit@student.uef.fi> --- Created attachment 41494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41494&action=edit Bug 14621 - Messaging preferences table needs to be sorted I have been working with messaging preferences and I noticed a weird issue in Firefox on Ubuntu. On messaging preferences page, the table is unsorted and the content in rows are generated randomly on every page refresh. When you select/deselect checkboxes and refresh the page (without posting the changes), Firefox will remember your choices. Now the issue is that when the table is unsorted and the rows keep changing on page refresh, Firefox has trouble remembering your choices. This makes it appear as if the checkboxes are magically changing values on each page refresh. Here is a patch that prevents this problem by sorting the messaging settings. Test plan: 1. Apply patch and have Perl version 5.18 or higher 2. In OPAC, navigate to "your messaging" 3. Observe the order of rows in the messaging settings table 4. Refresh the page 5. Observe that the order of rows is still the same as in step 3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14590 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |larit@student.uef.fi -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |z.tajoli@cineca.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli@cineca.it | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41494|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 42266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42266&action=edit Bug 14621 - Messaging preferences table needs to be sorted I have been working with messaging preferences and I noticed a weird issue in Firefox on Ubuntu. On messaging preferences page, the table is unsorted and the content in rows are generated randomly on every page refresh. When you select/deselect checkboxes and refresh the page (without posting the changes), Firefox will remember your choices. Now the issue is that when the table is unsorted and the rows keep changing on page refresh, Firefox has trouble remembering your choices. This makes it appear as if the checkboxes are magically changing values on each page refresh. Here is a patch that prevents this problem by sorting the messaging settings. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42266|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42273&action=edit Bug 14621 - Messaging preferences table needs to be sorted I have been working with messaging preferences and I noticed a weird issue in Firefox on Ubuntu. On messaging preferences page, the table is unsorted and the content in rows are generated randomly on every page refresh. When you select/deselect checkboxes and refresh the page (without posting the changes), Firefox will remember your choices. Now the issue is that when the table is unsorted and the rows keep changing on page refresh, Firefox has trouble remembering your choices. This makes it appear as if the checkboxes are magically changing values on each page refresh. Here is a patch that prevents this problem by sorting the messaging settings. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Very useful patch, thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Lari! And congratulations for your commit! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org