[Bug 5529] New: Staff client shows "Your lists:" and "public lists:" when there are none
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5529 Summary: Staff client shows "Your lists:" and "public lists:" when there are none Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Virtual Shelves AssignedTo: gmcharlt@gmail.com ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 On the staff client search results page the "Add to" menu offers a list of private and public lists to which results can be added. If there are no private and public lists, the menu still lists the labels, "Your lists:" and "public lists:" In search.pl: if (@pubshelves) { $template->param( addpubshelves => scalar (@pubshelves)); $template->param( addpubshelvesloop => @pubshelves); } if (@barshelves) { $template->param( addbarshelves => scalar (@barshelves)); $template->param( addbarshelvesloop => @barshelves); } The script passes template variables with the list count and list contents if @pubshelves and @barshelves evaluate as true. These variables will evaluate as true even if there are no lists in the database. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5529 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |colin.campbell@ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-04-06 11:43:22 UTC --- Testing a fix. Problem is some poor code in C4::VirtualShelves, it assigns a array_ref to an array in array context so that if you look at pubshelves in search.pl it is actually a 1 element array that element being a reference to an empty array i.e. [ [], ] so it is true consisting of 1 element. Need to ensure nowhere relies on incorrect behaviour -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5529 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|gmcharlt@gmail.com |colin.campbell@ptfs-europe. | |com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5529 --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-04-06 14:50:45 UTC --- Created attachment 3751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3751 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5529 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5529 Frederic Durand <frederic.durand@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic.durand@univ-lyon2. | |fr Patch Status|Needs Signoff |Failed QA --- Comment #3 from Frederic Durand <frederic.durand@univ-lyon2.fr> 2011-04-07 09:13:28 UTC --- With no lists already created (private or public ones) the "Add to" just contains "Cart" option, then all is working good for this point. As well the option to add biblios to 'New list' disappeared too, meaning it s quite more complicated and longer to create a new list than before. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5529 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3751|0 |1 is obsolete| | --- Comment #4 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-04-07 10:27:15 UTC --- Created attachment 3781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3781 Revised patch Add to patch: change to template to display new list option irrespective of existence of existing lists -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5529 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5529 Frederic Durand <frederic.durand@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #5 from Frederic Durand <frederic.durand@univ-lyon2.fr> 2011-04-07 14:25:54 UTC --- All is working perfectly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5529 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-07 22:57:45 UTC --- Pushed please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5529 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org