[Bug 5658] New: can't delete subfields in frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5658 Summary: can't delete subfields in frameworks Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com Estimated Hours: 0.0 I tried today on two installs of HEAD to delete a subfield from a framework and nothing happened. I didn't get any error messages and I didn't see it get deleted. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5658 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2011-05-18 20:38:36 UTC --- This is still an issue and it's critical that we be able to edit our frameworks - I think it's just a TT issue. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5658 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |frederic@tamil.fr Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5658 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|gmcharlt@gmail.com |frederic@tamil.fr -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5658 --- Comment #2 from Frédéric Demians <frederic@tamil.fr> 2011-05-23 12:12:28 UTC --- Created attachment 4229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4229 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5658 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 CC| |fridolyn.somers@gmail.com Depends on| |5240 Patch Status|Needs Signoff |--- -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5658 --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-05-23 12:39:05 UTC --- (In reply to comment #2)
Created attachment 4229 [details] Proposed patch
May I suggest another patch ? This bug depends on bug 5240 which wasn't fully committed (script modification was but not template modification). I recreated a patch with missing part from bug 5240 (updated to TT). The difference with Frédéric's patch is that delete link is not in perl script but directly in template (like edit link). Also : The framework code is always empty in edit and delete links. There is a bug in TT with "frameworkcode" parameter, it is not in loop so the call must be : [% frameworkcode %] instead of [% loo.frameworkcode %] Regards, -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5658 --- Comment #4 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-05-23 12:45:40 UTC --- Created attachment 4230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4230 Proposed patch (link into TT) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5658 Bug 5658 depends on bug 5240, which changed state. Bug 5240 Summary: next link hidden on edit subfields http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5240 What |Old Value |New Value ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5658 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Signed Off AssignedTo|frederic@tamil.fr |fridolyn.somers@gmail.com --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-05-23 13:09:45 UTC --- Thanks for catching the unpushed edits from bug 5240 Fridolyn. I have tested and signed off on your patch (attachment 4230). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5658 --- Comment #6 from Frédéric Demians <frederic@tamil.fr> 2011-05-23 14:46:36 UTC ---
I recreated a patch with missing part from bug 5240 (updated to TT). The difference with Frédéric's patch is that delete link is not in perl script but directly in template (like edit link).
+1 Thanks. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5658 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4229|0 |1 is obsolete| | Attachment #4230|0 |1 is obsolete| | --- Comment #7 from Frédéric Demians <frederic@tamil.fr> 2011-05-23 15:00:59 UTC --- Created attachment 4233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4233 Signed-off patch with Fridolyn fix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5658 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #8 from Ian Walls <ian.walls@bywatersolutions.com> 2011-05-25 20:41:23 UTC --- Tested, confirmed, marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5658 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Version|master |rel_3_4 Patch Status|Passed QA |Patch Pushed --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2011-05-25 21:31:49 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5658 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |katrin.fischer@bsz-bw.de Resolution| |FIXED --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-07-07 22:14:57 UTC --- It's possible to delete subfields from frameworks now. Patch is in master and 3.4.x. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5658 Bug 5658 depends on bug 5240, which changed state. Bug 5240 Summary: next link hidden on edit subfields http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5240 What |Old Value |New Value ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5658 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> 2011-08-11 18:36:19 UTC --- *** Bug 6327 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5658 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org