[Bug 17559] New: Invalid ID of element B_streetnumber in member edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17559 Bug ID: 17559 Summary: Invalid ID of element B_streetnumber in member edit form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: rbit@rbit.cz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In the include files member-alt-address-style-*.inc there is an element with name "B_streetnumber", but its id is "B_address". The ID should be "B_streetnumber" to avoid element ambiguity. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17559 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |rbit@rbit.cz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17559 --- Comment #1 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 57225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57225&action=edit Bug 17559: Fixed HTML element ID of B_streetnumber There is a duplicate ID in HTML code, because of this: <input type="text" id="B_address" name="B_streetnumber" size="5" value="" /> <input type="text" id="B_address" name="B_address" size="40" value="" /> Test plan: 1) Edit a patron and look into its HTML code 2) Find input: name="B_streetnumber" 3) Its ID is B_address - a duplicate within the code in fact 4) Apply the patch 5) Repeat steps 1 and 2 6) The ID is unique now: B_streetnumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17559 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17559 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com, | |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17559 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17559 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57225|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57240&action=edit [SIGNED-OFF] Bug 17559: Fixed HTML element ID of B_streetnumber There is a duplicate ID in HTML code, because of this: <input type="text" id="B_address" name="B_streetnumber" size="5" value="" /> <input type="text" id="B_address" name="B_address" size="40" value="" /> Test plan: 1) Edit a patron and look into its HTML code 2) Find input: name="B_streetnumber" 3) Its ID is B_address - a duplicate within the code in fact 4) Apply the patch 5) Repeat steps 1 and 2 6) The ID is unique now: B_streetnumber Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17559 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17559 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57240|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57638&action=edit Bug 17559: Fixed HTML element ID of B_streetnumber There is a duplicate ID in HTML code, because of this: <input type="text" id="B_address" name="B_streetnumber" size="5" value="" /> <input type="text" id="B_address" name="B_address" size="40" value="" /> Test plan: 1) Edit a patron and look into its HTML code 2) Find input: name="B_streetnumber" 3) Its ID is B_address - a duplicate within the code in fact 4) Apply the patch 5) Repeat steps 1 and 2 6) The ID is unique now: B_streetnumber Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17559 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10760 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760 [Bug 10760] Use Street Number and Street type in Alternate Address section -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17559 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Radek! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17559 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #5 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org