[Bug 17638] New: Search.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 Bug ID: 17638 Summary: Search.t is failing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57529&action=edit Bug 17638: Flush the config cache on setting a new context -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This patch fixes a big part of the tests, but some keep failing. I'd like someone to take a look, I am stuck with the other ones. It seems to be caused by bug 11921, but I don't manage to understand what's going wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- I'm not seeing any difference with "prove t/db_dependent/Search.t" with this patch than I do without. Am I testing the wrong file? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #3)
I'm not seeing any difference with "prove t/db_dependent/Search.t" with this patch than I do without. Am I testing the wrong file?
You should get less failures with this patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #4)
(In reply to Kyle M Hall from comment #3)
I'm not seeing any difference with "prove t/db_dependent/Search.t" with this patch than I do without. Am I testing the wrong file?
You should get less failures with this patch
Without patch: http://paste.koha-community.org/169 With patch: http://paste.koha-community.org/170 I'm not seeing a difference. That being said, it doesn't cause any problems either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Kyle M Hall from comment #5)
(In reply to Jonathan Druart from comment #4)
(In reply to Kyle M Hall from comment #3)
I'm not seeing any difference with "prove t/db_dependent/Search.t" with this patch than I do without. Am I testing the wrong file?
You should get less failures with this patch
Without patch: http://paste.koha-community.org/169 With patch: http://paste.koha-community.org/170
I'm not seeing a difference. That being said, it doesn't cause any problems either.
For me it absolutely makes diferences On master: http://paste.koha-community.org/172 With this patch: http://paste.koha-community.org/173 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Josef Moravec from comment #6)
(In reply to Kyle M Hall from comment #5)
(In reply to Jonathan Druart from comment #4)
(In reply to Kyle M Hall from comment #3)
I'm not seeing any difference with "prove t/db_dependent/Search.t" with this patch than I do without. Am I testing the wrong file?
You should get less failures with this patch
Without patch: http://paste.koha-community.org/169 With patch: http://paste.koha-community.org/170
I'm not seeing a difference. That being said, it doesn't cause any problems either.
For me it absolutely makes diferences On master: http://paste.koha-community.org/172 With this patch: http://paste.koha-community.org/173
Yes, it's what I get. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57551&action=edit Bug 17638: Make sure t/db_dependent/Search.t doesn't use a cached koha-conf.xml This patch makes the tests clean the 'config' namespace for cache before it runs any tests. To test: - Run: $ prove t/db_dependent/Search.t => FAIL: Self explanatory - Apply the patch - Run: $ prove t/db_dependent/Search.t => SUCCESS: All green - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57529|0 |1 is obsolete| | Attachment #57551|0 |1 is obsolete| | --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57552&action=edit Bug 17638: Make sure t/db_dependent/Search.t doesn't use a cached koha-conf.xml This patch makes the tests clean the 'config' namespace for cache before it runs any tests. To test: - Run: $ prove t/db_dependent/Search.t => FAIL: Self explanatory - Apply the patch - Run: $ prove t/db_dependent/Search.t => SUCCESS: All green - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Search.t is failing |t/db_dependent/Search.t is | |failing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57552|0 |1 is obsolete| | --- Comment #10 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 57568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57568&action=edit [SIGNED-OFF]Bug 17638: Make sure t/db_dependent/Search.t doesn't use a cached koha-conf.xml This patch makes the tests clean the 'config' namespace for cache before it runs any tests. To test: - Run: $ prove t/db_dependent/Search.t => FAIL: Self explanatory - Apply the patch - Run: $ prove t/db_dependent/Search.t => SUCCESS: All green - Sign off :-D Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All test pass successfuly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57568|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57575&action=edit Bug 17638: Make sure t/db_dependent/Search.t doesn't use a cached koha-conf.xml This patch makes the tests clean the 'config' namespace for cache before it runs any tests. To test: - Run: $ prove t/db_dependent/Search.t => FAIL: Self explanatory - Apply the patch - Run: $ prove t/db_dependent/Search.t => SUCCESS: All green - Sign off :-D Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All test pass successfuly Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Cannot reproduce, but I trust everyone telling me it's failing ; ) No regressions spotted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17664 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17638 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #13 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org