[Bug 41040] New: Empty patron search from the header should not trigger a patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Bug ID: 41040 Summary: Empty patron search from the header should not trigger a patron search Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com If the "arrow" button on the patron search is clicked with no value in the textbox, it redirects to members/members-home.pl and performs a search with no value automatically. It makes more send for it to behave as the "Patrons" link in the navbar that directs to members-home.pl where the librarian can then perform a more advanced search. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #1 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 188062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188062&action=edit Bug 41040: Empty patron search from the header should not trigger a patron search If the "arrow" button on the patron search is clicked with no value in the textbox, it redirects to members/members-home.pl and performs a search with no value automatically. It makes more send for it to behave as the "Patrons" link in the navbar that directs to members-home.pl where the librarian can then perform a more advanced search. Test Plan: 1) Click the "Search patrons" link on the header, then the arrow button 2) Note an empty patron search is performed immediately 3) Apply this patch 4) Restart all the things! 5) Repeat step 1 6) Note a paton search is no longer triggered automatically -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Kristi Krueger <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Daniel B. <dbarden@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dbarden@cuyahogalibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- The patch works. But... I often use this to get the list of patrons. Although my use case might not be what "normal" staff users do since I don't work in a library. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #3 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- (In reply to Caroline Cyr La Rose from comment #2)
The patch works.
But...
I often use this to get the list of patrons. Although my use case might not be what "normal" staff users do since I don't work in a library.
The letter searches should still work for your use case! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Caroline Cyr La Rose from comment #2)
The patch works.
But...
I often use this to get the list of patrons. Although my use case might not be what "normal" staff users do since I don't work in a library.
As a developer, I do this a lot too. But is this actually a work flow any real life librarian uses? Certainly not in a large system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Lucas Gass (lukeg) from comment #4)
(In reply to Caroline Cyr La Rose from comment #2)
The patch works.
But...
I often use this to get the list of patrons. Although my use case might not be what "normal" staff users do since I don't work in a library.
As a developer, I do this a lot too. But is this actually a work flow any real life librarian uses? Certainly not in a large system.
Hence my sentence
[...] Although my use case might not be what "normal" staff users do since I don't work in a library.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Lucas Gass (lukeg) from comment #4)
(In reply to Caroline Cyr La Rose from comment #2)
The patch works.
But...
I often use this to get the list of patrons. Although my use case might not be what "normal" staff users do since I don't work in a library.
As a developer, I do this a lot too. But is this actually a work flow any real life librarian uses? Certainly not in a large system.
Reading the comments and I was thinking how I will often do this in KTD but not my real world systems. If I recall correctly, Keycloak went through a change like this. Years ago, you used to be able to do an empty search to get all users, but these days you have to put in a * to get all users. So that's another option which would cover all use-cases. So long as there was a hint to say that * gets the full list... it could work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from David Cook <dcook@prosentient.com.au> --- After trying this one out, I don't think this is ready. Why not just disable the submit button in the header after it's pressed? If you use the filters in the header search to create a search for something like Category: Patron with Library: Centerville and you click search, it won't do the search with this patch. But I think that would break backwards compatibility. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #8 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 189016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189016&action=edit Bug 41040: Empty patron search from the header should not trigger a patron search If the "arrow" button on the patron search is clicked with no value in the textbox, it redirects to members/members-home.pl and performs a search with no value automatically. It makes more send for it to behave as the "Patrons" link in the navbar that directs to members-home.pl where the librarian can then perform a more advanced search. Test Plan: 1) Click the "Search patrons" link on the header, then the arrow button 2) Note an empty patron search is performed immediately 3) Apply this patch 4) Restart all the things! 5) Repeat step 1 6) Note a paton search is no longer triggered automatically -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #9 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 189017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189017&action=edit Bug 41040: Prevent form submission if no filters have been selected Patch from commit 532327a -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #10 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 189018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189018&action=edit Bug 41040: Use tooltip for message instead of alert Patch from commit bb8268d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- If the "arrow" button on the patron search is clicked with no value in the textbox, it redirects to members/members-home.pl and performs a search with no value automatically. It makes more send for it to behave as the "Patrons" link in the navbar that directs to members-home.pl where the librarian can then perform a more advanced search. Test Plan: 1) Click the "Search patrons" link on the header, then the arrow button 2) Note an empty patron search is performed immediately 3) Apply this patch 4) Restart all the things! 5) Repeat step 1 6) Note a paton search is no longer triggered automatically -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188062|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189016|0 |1 is obsolete| | Attachment #189017|0 |1 is obsolete| | Attachment #189018|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 189197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189197&action=edit Bug 41040: Prevent form submission if no filters have been selected Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 189198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189198&action=edit Bug 41040: Use tooltip for message instead of alert Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 189199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189199&action=edit Bug 41040: (follow-up) Tooltip text change and remove unnecessary class - I think "Please enter a card number or name" sounds friendlier - We don't add a "btn-primary" class to these buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #15 from David Nind <david@davidnind.com> --- Getting a sha1/fake ancestor error when applying the patch: git bz apply 41040 Bug 41040 - Empty patron search from the header should not trigger a patron search 189197 - Bug 41040: Prevent form submission if no filters have been selected 189198 - Bug 41040: Use tooltip for message instead of alert 189199 - Bug 41040: (follow-up) Tooltip text change and remove unnecessary class Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 41040: Prevent form submission if no filters have been selected error: sha1 information is lacking or useless (members/member.pl). error: could not build fake ancestor Patch failed at 0001 Bug 41040: Prevent form submission if no filters have been selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 189508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189508&action=edit Bug 41040: Empty patron search from the header should not trigger a patron search If the "arrow" button on the patron search is clicked with no value in the textbox, it redirects to members/members-home.pl and performs a search with no value automatically. It makes more send for it to behave as the "Patrons" link in the navbar that directs to members-home.pl where the librarian can then perform a more advanced search. Test Plan: 1) Click the "Search patrons" link on the header, then the arrow button 2) Note an empty patron search is performed immediately 3) Apply this patch 4) Restart all the things! 5) Repeat step 1 6) Note a paton search is no longer triggered automatically Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189197|0 |1 is obsolete| | --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 189509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189509&action=edit Bug 41040: Prevent form submission if no filters have been selected Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189198|0 |1 is obsolete| | --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 189510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189510&action=edit Bug 41040: Use tooltip for message instead of alert Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189199|0 |1 is obsolete| | --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 189511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189511&action=edit Bug 41040: (follow-up) Tooltip text change and remove unnecessary class - I think "Please enter a card number or name" sounds friendlier - We don't add a "btn-primary" class to these buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189508|0 |1 is obsolete| | --- Comment #20 from David Nind <david@davidnind.com> --- Created attachment 189517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189517&action=edit Bug 41040: Empty patron search from the header should not trigger a patron search If the "arrow" button on the patron search is clicked with no value in the textbox, it redirects to members/members-home.pl and performs a search with no value automatically. It makes more send for it to behave as the "Patrons" link in the navbar that directs to members-home.pl where the librarian can then perform a more advanced search. Test Plan: 1) Click the "Search patrons" link on the header, then the arrow button 2) Note an empty patron search is performed immediately 3) Apply this patch 4) Restart all the things! 5) Repeat step 1 6) Note a paton search is no longer triggered automatically Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189509|0 |1 is obsolete| | --- Comment #21 from David Nind <david@davidnind.com> --- Created attachment 189518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189518&action=edit Bug 41040: Prevent form submission if no filters have been selected Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189510|0 |1 is obsolete| | --- Comment #22 from David Nind <david@davidnind.com> --- Created attachment 189519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189519&action=edit Bug 41040: Use tooltip for message instead of alert Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189511|0 |1 is obsolete| | --- Comment #23 from David Nind <david@davidnind.com> --- Created attachment 189520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189520&action=edit Bug 41040: (follow-up) Tooltip text change and remove unnecessary class - I think "Please enter a card number or name" sounds friendlier - We don't add a "btn-primary" class to these buttons Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the "Search release notes| |patrons" option in the | |staff interface menu bar. | |Currently, clicking "Search | |patrons" and then the arrow | |(without entering a value) | |automatically performs a | |search. | | | |With this change, a patron | |search is now no longer | |automatic. If you don't | |enter anything, or don't | |select any options, you are | |now prompted (using a | |tooltip) to enter a patron | |name or card number. | | | |NOTE: This is a change in | |behavour from what you may | |be used to. --- Comment #24 from David Nind <david@davidnind.com> --- I think I personally would prefer it going to the patrons page and not automatically doing a search. But, I'm not sure how this is used in real life. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #25 from David Nind <david@davidnind.com> --- (In reply to David Nind from comment #24)
I think I personally would prefer it going to the patrons page and not automatically doing a search.
But, I'm not sure how this is used in real life.
However, you can get this behavour by clicking the "Patrons" link in the header. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #26 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Why are the script tags being added inside the <form> element. WC3 HTML validator does consider this valid but it seems unusual to me. Is there a reason to do this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 193117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193117&action=edit Bug 41040: (follow-up) Move JS to global JS file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #28 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #27)
Created attachment 193117 [details] [review] Bug 41040: (follow-up) Move JS to global JS file
Nice Owen, this is exactly what I thought was needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189517|0 |1 is obsolete| | --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 193118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193118&action=edit Bug 41040: Empty patron search from the header should not trigger a patron search If the "arrow" button on the patron search is clicked with no value in the textbox, it redirects to members/members-home.pl and performs a search with no value automatically. It makes more send for it to behave as the "Patrons" link in the navbar that directs to members-home.pl where the librarian can then perform a more advanced search. Test Plan: 1) Click the "Search patrons" link on the header, then the arrow button 2) Note an empty patron search is performed immediately 3) Apply this patch 4) Restart all the things! 5) Repeat step 1 6) Note a paton search is no longer triggered automatically Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189518|0 |1 is obsolete| | --- Comment #30 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 193119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193119&action=edit Bug 41040: Prevent form submission if no filters have been selected Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189519|0 |1 is obsolete| | --- Comment #31 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 193120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193120&action=edit Bug 41040: Use tooltip for message instead of alert Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189520|0 |1 is obsolete| | --- Comment #32 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 193121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193121&action=edit Bug 41040: (follow-up) Tooltip text change and remove unnecessary class - I think "Please enter a card number or name" sounds friendlier - We don't add a "btn-primary" class to these buttons Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193117|0 |1 is obsolete| | --- Comment #33 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 193122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193122&action=edit Bug 41040: (follow-up) Move JS to global JS file Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #34 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Thank you Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #35 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #36 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- All pushed to 25.11.x Thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|26.05.00,25.11.03 |26.05.00,25.11.03,25.05.09 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #37 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42338 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41048 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 cschrode <cschrode@akronlibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cschrode@akronlibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldstable |Needs documenting --- Comment #38 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not change behavior in 24.11 LTS for stability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #39 from David Cook <dcook@prosentient.com.au> --- So I think this has broken the top patron search in main? I can't search empty searches as expected, but I also can't search anything. I think I know what the problem is. I'll open a new bug for it I guess and link it here... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42423 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 [Bug 42423] Submit button in patron search from header never submits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 --- Comment #40 from David Cook <dcook@prosentient.com.au> --- Patch provided on bug 42423. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42643 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42643 [Bug 42643] [OMNIBUS] Assorted performance and stability work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43016 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43016 [Bug 43016] [OMNIBUS] Server resource protection -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|42643 | CC| |andrew@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42643 [Bug 42643] [OMNIBUS] Assorted performance and stability work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #41 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I looked in the manual and there was no mention that an empty search was even possible. Nothing to add or edit in the manual. RIP empty search :,( -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org