[Bug 42423] New: Submit button in patron search from header never submits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 Bug ID: 42423 Summary: Submit button in patron search from header never submits Initiative type: --- Sponsorship --- status: Product: Koha Version: 25.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com It looks like there's a bug in bug 41040 that prevents any patron search from the header and not just empty searches. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | Depends on| |41040 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41040 [Bug 41040] Empty patron search from the header should not trigger a patron search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 197829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197829&action=edit Bug 42423: Fix patron header search This patch fixes the patron header search, so that you can do patron searches from the header, but empty patron searches are prevented and show a tooltip. Test plan: 0. DO NOT APPLY THE PATCH YET 1. Log into the staff interface and try to search for anything in the "Search patrons" header search 2. Note that nothing happens at all no matter how much you click 3. Apply the patch 4. Refresh the browser page 5. Try to search for anything in the "Seearch patrons" header search 6. Note that it performs the search 7. Empty out the input box and hit Enter or the search button 8. Note that a tooltip appears saying "Please enter a card number or name" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Note: this should apply to main as well as 25.11.03 and 25.05.09 I've selected 25.05 as the lowest version that should be affected I've only tested this on main though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197829|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197853&action=edit Bug 42423: Fix patron header search This patch fixes the patron header search, so that you can do patron searches from the header, but empty patron searches are prevented and show a tooltip. Test plan: 0. DO NOT APPLY THE PATCH YET 1. Log into the staff interface and try to search for anything in the "Search patrons" header search 2. Note that nothing happens at all no matter how much you click 3. Apply the patch 4. Refresh the browser page 5. Try to search for anything in the "Seearch patrons" header search 6. Note that it performs the search 7. Empty out the input box and hit Enter or the search button 8. Note that a tooltip appears saying "Please enter a card number or name" Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197854&action=edit Bug 42423: Add a Cypress test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|25.05 |Main CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197853|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197854|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197875&action=edit Bug 42423: Fix patron header search This patch fixes the patron header search, so that you can do patron searches from the header, but empty patron searches are prevented and show a tooltip. Test plan: 0. DO NOT APPLY THE PATCH YET 1. Log into the staff interface and try to search for anything in the "Search patrons" header search 2. Note that nothing happens at all no matter how much you click 3. Apply the patch 4. Refresh the browser page 5. Try to search for anything in the "Seearch patrons" header search 6. Note that it performs the search 7. Empty out the input box and hit Enter or the search button 8. Note that a tooltip appears saying "Please enter a card number or name" Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197876&action=edit Bug 42423: Add a Cypress test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the patron release notes| |search in the staff | |interface header. | | | |If the search you enter | |didn't show any | |autocomplete results, | |clicking the arrow to | |search didn't do anything. | | | |Now, it will use the search | |you entered and show any | |results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00, 25.11.04 released in| | --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 25.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|26.05.00, 25.11.04 |26.05.00,25.11.04,25.05.10 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- I see it is in 25.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42423 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 41040 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org