[Bug 23602] New: Branch limitations should display in the itemtypes table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Bug ID: 23602 Summary: Branch limitations should display in the itemtypes table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl With the introduction of bug 15497 itemtypes can now be limited to select branches. We should display the selected branch list in the itemtype summary table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15497 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 [Bug 15497] Limit Item Types by Branch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |agustinmoyano@theke.io |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I missed this during my QA run on the original bug.. any chance of a quick followup Agustin.. hopefully it's a trivial request. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Bug 23602 depends on bug 15497, which changed state. Bug 15497 Summary: Limit Item Types by Branch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 --- Comment #2 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 92800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92800&action=edit Bug 23602: Display branch limitations in itemtype table This patch adds a column in itemtype table to display branch limitations. To test: 1) Open item types admin page. CHECK => there is no column for branch limitations, even if you add a limitation in an item type. 2) Apply this patch SUCCESS => A new column appears that displays branch limitations per item type 3) Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92800|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92815&action=edit Bug 23602: Display branch limitations in itemtype table This patch adds a column in itemtype table to display branch limitations. To test: 1) Open item types admin page. CHECK => there is no column for branch limitations, even if you add a limitation in an item type. 2) Apply this patch SUCCESS => A new column appears that displays branch limitations per item type 3) Sign off Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92816&action=edit Bug 23602: (follow-up) Correct terminology, add tooltip This follow-up changes the use of "branch" to the Koha standard "library." The patch also adds the use of a Bootstrap tooltip for showing an item type's library limitations in the main table of item types. To test, apply the patch and go to Administration -> Item types. In the table of item types, find one with library limitations. Hovering over the "# library limitations" test should trigger a Bootstrap-styled tooltip showing the library name and code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23606 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23606 [Bug 23606] Add columns configuration and export options to item types administration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Branch limitations should |Library limitations should |display in the itemtypes |display in the item types |table |table CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92815|0 |1 is obsolete| | --- Comment #5 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 93044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93044&action=edit Bug 23602: Display branch limitations in itemtype table This patch adds a column in itemtype table to display branch limitations. To test: 1) Open item types admin page. CHECK => there is no column for branch limitations, even if you add a limitation in an item type. 2) Apply this patch SUCCESS => A new column appears that displays branch limitations per item type 3) Sign off Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92816|0 |1 is obsolete| | --- Comment #6 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 93046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93046&action=edit Bug 23602: (follow-up) Correct terminology, add tooltip This follow-up changes the use of "branch" to the Koha standard "library." The patch also adds the use of a Bootstrap tooltip for showing an item type's library limitations in the main table of item types. To test, apply the patch and go to Administration -> Item types. In the table of item types, find one with library limitations. Hovering over the "# library limitations" test should trigger a Bootstrap-styled tooltip showing the library name and code. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93044|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93200&action=edit Bug 23602: Display branch limitations in itemtype table This patch adds a column in itemtype table to display branch limitations. To test: 1) Open item types admin page. CHECK => there is no column for branch limitations, even if you add a limitation in an item type. 2) Apply this patch SUCCESS => A new column appears that displays branch limitations per item type 3) Sign off Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93046|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93201&action=edit Bug 23602: (follow-up) Correct terminology, add tooltip This follow-up changes the use of "branch" to the Koha standard "library." The patch also adds the use of a Bootstrap tooltip for showing an item type's library limitations in the main table of item types. To test, apply the patch and go to Administration -> Item types. In the table of item types, find one with library limitations. Hovering over the "# library limitations" test should trigger a Bootstrap-styled tooltip showing the library name and code. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93202&action=edit Bug 23602: (follow-up) Improve tooltip formatting This follow-up changes the formatting of the tooltip to add a newline for library limit. To test, apply the patch and go to Administration -> Item types. In the table of item types, find one with library limitations. Hovering over the "# library limitations" test should trigger a Bootstrap-styled tooltip showing the library name and code, one per line. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93202|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 93205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93205&action=edit Bug 23602: (follow-up) Improve tooltip formatting This follow-up changes the formatting of the tooltip to add a newline for library limit. To test, apply the patch and go to Administration -> Item types. In the table of item types, find one with library limitations. Hovering over the "# library limitations" test should trigger a Bootstrap-styled tooltip showing the library name and code, one per line. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 15497 not in 19.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 [Bug 23772] Itemtype icons now showing in table and not checked when editing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Augustin, can you please have a look at bug 23602? It looks like this patch set broke the display of the item type in the table. This part in the template does no longer seem to work: [% UNLESS Koha.Preference('noItemTypeImages') %] <td> [% SET image_location = itemtype.image_location('intranet') %] [% IF image_location %]<img src="[% image_location | html %]" alt="" />[% ELSE %] [% END %] </td> [% END %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 [Bug 23804] Itemtype not checked when editing -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org