[Bug 23803] New: Add Font Awesome icon to cart in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 Bug ID: 23803 Summary: Add Font Awesome icon to cart in staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: claire_gravely@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The cart icon should be a font awesome icon to match the other icons used in Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |claire_gravely@hotmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 --- Comment #1 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 94009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94009&action=edit Bug 23803: Add Font Awesome icon to cart in staff interface This patch adds the font awesome icon to the cart in the staff interface. To test: 1. Apply patch and run yarn build (see: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 2. Check that the old cart icon no longer displays and the new font awesome icon is positioned correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94009|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 94010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94010&action=edit Bug 23803: Add Font Awesome icon to cart in staff interface This patch adds the font awesome icon to the cart in the staff interface. To test: 1. Apply patch and run yarn build (see: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 2. Check that the old cart icon no longer displays and the new font awesome icon is positioned correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94010|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 94012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94012&action=edit Bug 23803: Add Font Awesome icon to cart in staff interface This patch adds the font awesome icon to the cart in the staff interface. To test: 1. Apply patch and run yarn build (see: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 2. Check that the old cart icon no longer displays and the new font awesome icon is positioned correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 94013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94013&action=edit Bug 23803: (follow-up) Remove additional references and file This patch removes the cart-small.gif file and a couple other references to the file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94013|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 94014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94014&action=edit Bug 23803: (follow-up) Remove additional references and file This patch removes the cart-small.gif file and a couple other references to the file. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org