[Bug 15790] New: Don't delete a MARC framework if existing records use that framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Bug ID: 15790 Summary: Don't delete a MARC framework if existing records use that framework Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/biblio_framework.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In contrast with item types, where you cannot delete an item type if existing records use it, Koha will let you delete a MARC framework even if there are existing records which use that framework code. I think the correct behavior is to prevent the user from proceeding with the deletion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15785 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 [Bug 15785] Use Font Awesome icons in confirmation dialogs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 47931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47931&action=edit Bug 15790 - Don't delete a MARC framework if existing records use that framework If a MARC framework is in use by any records it should not be possible to delete it. Deleting a framework which is in use will leave the deleted framework code in those records. This patch modifies the deletion confirmation dialog so that it will not let the user confirm the deletion if there are records using it. Depends on Bug 15785 - Use Font Awesome icons in confirmation dialogs To test, apply the patch and go to Administration -> MARC frameworks 1. Try to delete a framework which is in use by 1 or more records. The resulting confirmation dialog should prevent you from proceeding. 2. Try to delete a framework which is not in use. Test both canceling and confirming that deletion to make both function correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47931|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 47933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47933&action=edit Bug 15790 - Don't delete a MARC framework if existing records use that framework If a MARC framework is in use by any records it should not be possible to delete it. Deleting a framework which is in use will leave the deleted framework code in those records. This patch modifies the deletion confirmation dialog so that it will not let the user confirm the deletion if there are records using it. Depends on Bug 15785 - Use Font Awesome icons in confirmation dialogs To test, apply the patch and go to Administration -> MARC frameworks 1. Try to delete a framework which is in use by 1 or more records. The resulting confirmation dialog should prevent you from proceeding. 2. Try to delete a framework which is not in use. Test both canceling and confirming that deletion to make both function correctly. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47933|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47973&action=edit Bug 15790 - Don't delete a MARC framework if existing records use that framework If a MARC framework is in use by any records it should not be possible to delete it. Deleting a framework which is in use will leave the deleted framework code in those records. This patch modifies the deletion confirmation dialog so that it will not let the user confirm the deletion if there are records using it. Depends on Bug 15785 - Use Font Awesome icons in confirmation dialogs To test, apply the patch and go to Administration -> MARC frameworks 1. Try to delete a framework which is in use by 1 or more records. The resulting confirmation dialog should prevent you from proceeding. 2. Try to delete a framework which is not in use. Test both canceling and confirming that deletion to make both function correctly. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 48731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48731&action=edit [3.22.x] Bug 15790 - Don't delete a MARC framework if existing records use that framework Patch for 3.22.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.10. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org