[Bug 15833] New: Bad variable value in renewal template confirmation dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 Bug ID: 15833 Summary: Bad variable value in renewal template confirmation dialog Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/renew.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: jonathan.druart@bugs.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com On renew.pl, the confirmation dialog which appears when you have successfully renewed something includes a link to the item, but a bad value is being passed to the template as part of that link: /cgi-bin/koha/catalogue/moredetail.pl?itemnumber=11157&biblionumber=5433&bi=Koha::Schema::Result::Biblioitem=HASH(0x8a58338)#item11157 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48143&action=edit Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object 2 links are wrong on the renew page, because item.biblioitemnumber does not return the biblioitemnumber as expect the template. Test plan: Renew an item and check the item link. It should contain a valid biblioitemnumber for the 'bi' parameter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48143|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48146&action=edit [SIGNED-OFF] Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object 2 links are wrong on the renew page, because item.biblioitemnumber does not return the biblioitemnumber as expect the template. Test plan: Renew an item and check the item link. It should contain a valid biblioitemnumber for the 'bi' parameter. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48146|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 48227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48227&action=edit Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object 2 links are wrong on the renew page, because item.biblioitemnumber does not return the biblioitemnumber as expect the template. Test plan: Renew an item and check the item link. It should contain a valid biblioitemnumber for the 'bi' parameter. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Link repaired. At first glance, I am wondering if biblioitemnumber is of actual use here; is it only passed back and forth between script and template? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - should be in the May 2016 release - thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.10. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org