https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42111 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42111 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42118 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42118 [Bug 42118] Update various admin pages to use grid layout for forms - Part 2 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42111 Felicie <felicie.thiery@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Athens County Public list of Sponsors| |Libraries Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42111 --- Comment #2 from Felicie <felicie.thiery@biblibre.com> --- Created attachment 196092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196092&action=edit Bug 42111: Update various admin pages to use grid layout for forms - Part 1 This patch updates several administration templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Administration -> Additional fields - Administration -> Audio alerts - Administration -> Cities and Towns - Administration -> Classification configuration -> Classification sources -> Classification filing rules -> Classification splitting rules On the classification splitting rules page I've reformatted the regular expression section to fit better. To test, add or edit a splitting rule. - Under "Splitting routine" choose "RegEx" - "Regular expression" and "Test the regular expressions" fields should appear. - Add one or more regular expressions, e.g. s/\s/\n/g s/(\s?=)/\n=/g s/^(J|K)\n/$1 / - In the "Test the regular expressions" text area enter some call numbers e.g. 830 Han 159.9 (091) Gesh J 3 Kin =774 830 Hil =774 4 830 Las=20 4 - Click "Test" - The formatted call numbers should appear below in a grid: +---------+------------------+--------------+----------------+--------------+ | 830 Han | 159.9 (091) Gesh | J 3 Kin =774 | 830 Hil =774 4 | 830 Las=20 4 | +---------+------------------+--------------+----------------+--------------+ | 830 | 159.9 | J 3 | 830 | 830 | | Han | (091) | Kin | Hil | Las | | | Gesh | =774 | =774 | =20 | | | | | 4 | 4 | +---------+------------------+--------------+----------------+--------------+ Sponsored-by: Athens County Public Libraries Signed-off-by: Felicie <felicie.thiery@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42111 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42111 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200745&action=edit Bug 42111: Update various admin pages to use grid layout for forms - Part 1 This patch updates several administration templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Administration -> Additional fields - Administration -> Audio alerts - Administration -> Cities and Towns - Administration -> Classification configuration -> Classification sources -> Classification filing rules -> Classification splitting rules On the classification splitting rules page I've reformatted the regular expression section to fit better. To test, add or edit a splitting rule. - Under "Splitting routine" choose "RegEx" - "Regular expression" and "Test the regular expressions" fields should appear. - Add one or more regular expressions, e.g. s/\s/\n/g s/(\s?=)/\n=/g s/^(J|K)\n/$1 / - In the "Test the regular expressions" text area enter some call numbers e.g. 830 Han 159.9 (091) Gesh J 3 Kin =774 830 Hil =774 4 830 Las=20 4 - Click "Test" - The formatted call numbers should appear below in a grid: +---------+------------------+--------------+----------------+--------------+ | 830 Han | 159.9 (091) Gesh | J 3 Kin =774 | 830 Hil =774 4 | 830 Las=20 4 | +---------+------------------+--------------+----------------+--------------+ | 830 | 159.9 | J 3 | 830 | 830 | | Han | (091) | Kin | Hil | Las | | | Gesh | =774 | =774 | =20 | | | | | 4 | 4 | +---------+------------------+--------------+----------------+--------------+ Sponsored-by: Athens County Public Libraries Signed-off-by: Felicie <felicie.thiery@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42111 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 200902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200902&action=edit Bug 42111: Update various admin pages to use grid layout for forms - Part 1 This patch updates several administration templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Administration -> Additional fields - Administration -> Audio alerts - Administration -> Cities and Towns - Administration -> Classification configuration -> Classification sources -> Classification filing rules -> Classification splitting rules On the classification splitting rules page I've reformatted the regular expression section to fit better. To test, add or edit a splitting rule. - Under "Splitting routine" choose "RegEx" - "Regular expression" and "Test the regular expressions" fields should appear. - Add one or more regular expressions, e.g. s/\s/\n/g s/(\s?=)/\n=/g s/^(J|K)\n/$1 / - In the "Test the regular expressions" text area enter some call numbers e.g. 830 Han 159.9 (091) Gesh J 3 Kin =774 830 Hil =774 4 830 Las=20 4 - Click "Test" - The formatted call numbers should appear below in a grid: +---------+------------------+--------------+----------------+--------------+ | 830 Han | 159.9 (091) Gesh | J 3 Kin =774 | 830 Hil =774 4 | 830 Las=20 4 | +---------+------------------+--------------+----------------+--------------+ | 830 | 159.9 | J 3 | 830 | 830 | | Han | (091) | Kin | Hil | Las | | | Gesh | =774 | =774 | =20 | | | | | 4 | 4 | +---------+------------------+--------------+----------------+--------------+ Sponsored-by: Athens County Public Libraries Signed-off-by: Felicie <felicie.thiery@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42111 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #6)

- <fieldset class="rows"> - <legend class="visually-hidden">Audio alert details</legend> + <fieldset class="fg"> + <legend class="sr-only">Audio alert details</legend>

Is this correct, Owen?

We had that before: Bug 42564: Upgrade Font Awesome in the staff interface to 7.2 <fieldset class="rows"> - <legend class="sr-only">Audio alert details</legend> + <legend class="visually-hidden">Audio alert details</legend>

Oops, ignore this. I was in the middle of a conflict and tried to fix this, but I hadn't turned the brain on yet! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42111 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 201927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201927&action=edit Bug 42111: Update various admin pages to use grid layout for forms - Part 1 This patch updates several administration templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Administration -> Additional fields - Administration -> Audio alerts - Administration -> Cities and Towns - Administration -> Classification configuration -> Classification sources -> Classification filing rules -> Classification splitting rules On the classification splitting rules page I've reformatted the regular expression section to fit better. To test, add or edit a splitting rule. - Under "Splitting routine" choose "RegEx" - "Regular expression" and "Test the regular expressions" fields should appear. - Add one or more regular expressions, e.g. s/\s/\n/g s/(\s?=)/\n=/g s/^(J|K)\n/$1 / - In the "Test the regular expressions" text area enter some call numbers e.g. 830 Han 159.9 (091) Gesh J 3 Kin =774 830 Hil =774 4 830 Las=20 4 - Click "Test" - The formatted call numbers should appear below in a grid: +---------+------------------+--------------+----------------+--------------+ | 830 Han | 159.9 (091) Gesh | J 3 Kin =774 | 830 Hil =774 4 | 830 Las=20 4 | +---------+------------------+--------------+----------------+--------------+ | 830 | 159.9 | J 3 | 830 | 830 | | Han | (091) | Kin | Hil | Las | | | Gesh | =774 | =774 | =20 | | | | | 4 | 4 | +---------+------------------+--------------+----------------+--------------+ Sponsored-by: Athens County Public Libraries Signed-off-by: Felicie <felicie.thiery@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.