[Bug 42094] New: Tidy all script tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug ID: 42094 Summary: Tidy all script tags Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 41324 On bug 41324 we tidy all the script tags that contained a kohaTable. Now we would like to tidy all the remaining script tags. We will certainly need a comment in the code to flag the script tag that is used to interpolate TT variables into JS variable. ``` <script> // Accept TT tags here let js_variable = [% perl_variable %]; </script> <script> // Here TT tags are prohibided, and ideally the code must be moved to a separate .js file // And we can reuse js_variable </script> ``` Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 [Bug 41324] Tidy kohaTable block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- I quite like the Mozilla dev guide model you mention in the 2026 Overview you presented at Hackfest, Jonathan. <script id="data" type="application/json"> [% To.json(data) | $raw %]; // Or [% data | json %] </script> <script> const userInfo = JSON.parse(document.getElementById("data").text); </script> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #1)
I quite like the Mozilla dev guide model you mention in the 2026 Overview you presented at Hackfest, Jonathan.
Yes I know, you are the one who pointed it to me! ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #2)
(In reply to David Cook from comment #1)
I quite like the Mozilla dev guide model you mention in the 2026 Overview you presented at Hackfest, Jonathan.
Yes I know, you are the one who pointed it to me! ;)
Haha I figured I'd just record it here in case people were interested 😅 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Was there discussion about it and how did it go? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #4)
Was there discussion about it and how did it go?
Yes, we are going to do it. I have a branch almost ready. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41653 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 [Bug 41653] Stores for permissions and sysprefs should be under the Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #5)
(In reply to David Cook from comment #4)
Was there discussion about it and how did it go?
Yes, we are going to do it. I have a branch almost ready.
Which method? Or are we using both? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #6)
(In reply to Jonathan Druart from comment #5)
(In reply to David Cook from comment #4)
Was there discussion about it and how did it go?
Yes, we are going to do it. I have a branch almost ready.
Which method? Or are we using both?
No new method, the current one. Given the size of the diff we want the easiest to test and less disruptive changes as possible. After this is done we could start using `type="application/json"` for some of the regular JS variables (*_table_settings for instance). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Tidy all script tags |Tidy all script tags | |(except value_builder) --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- I am excluding cataloguing/value_builder files for this bug report. They are very messy and not trivial to migrate, and I don't want to delay the current work because of them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42278 [Bug 42278] Tidy all script tags - circ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42280 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 [Bug 42280] Tidy all script tags - admin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42281 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42281 [Bug 42281] Tidy all script tags - authorities -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 [Bug 42282] Tidy all script tags - catalogue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42284 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42284 [Bug 42284] Tidy all script tags - addbiblio/authorities -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42285 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42285 [Bug 42285] Tidy all script tags - authorities -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42286 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42286 [Bug 42286] Tidy all script tags - ill -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42288 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42288 [Bug 42288] Tidy all script tags - reserve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42289 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42289 [Bug 42289] Tidy all script tags - tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42290 [Bug 42290] Tidy all script tags - suggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42291 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42291 [Bug 42291] Tidy all script tags - shelves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42292 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42292 [Bug 42292] Tidy all script tags - opac -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42293 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42293 [Bug 42293] Tidy all script tags - serials -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42294 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 [Bug 42294] Tidy all script tags - patron searches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42295 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42295 [Bug 42295] Tidy all script tags - includes staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42296 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 [Bug 42296] Tidy all script tags - trivial ones -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug 42094 depends on bug 42285, which changed state. Bug 42285 Summary: Tidy all script tags - authorities https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42285 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196809&action=edit Bug 42094: Adjust tests Rename xt/tt_kohaTable_tidy.t to xt/tt_script_tidy.t We now test all .tt and .inc files, except cataloguing/value_builder files. They are very messy and not trivial to migrate. Test plan: If you have applied all patches from the dependeng bug reports this test should now pass. We are testing that: * All files has only ONE script tag with the attribute data-tt-allowed set to "true" * All script tags with data-tt-allowed="true" have TT tags * All script tags without data-tt-allowed="true" do not have TT tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196810&action=edit Bug 42094: Fix occurrence in t Patch from commit 927b96f -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- The whole tree is available at https://gitlab.com/joubu/Koha/-/commits/bug_42094 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196809|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196810|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196909&action=edit Bug 42094: Adjust tests Rename xt/tt_kohaTable_tidy.t to xt/tt_script_tidy.t We now test all .tt and .inc files, except cataloguing/value_builder files. They are very messy and not trivial to migrate. Test plan: If you have applied all patches from the dependeng bug reports this test should now pass. We are testing that: * All files has only ONE script tag with the attribute data-tt-allowed set to "true" * All script tags with data-tt-allowed="true" have TT tags * All script tags without data-tt-allowed="true" do not have TT tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196910&action=edit Bug 42094: Fix occurrence in t Patch from commit 8b5eaa2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196909|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196910|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196911&action=edit Bug 42094: Adjust tests Rename xt/tt_kohaTable_tidy.t to xt/tt_script_tidy.t We now test all .tt and .inc files, except cataloguing/value_builder files. They are very messy and not trivial to migrate. Test plan: If you have applied all patches from the dependeng bug reports this test should now pass. We are testing that: * All files has only ONE script tag with the attribute data-tt-allowed set to "true" * All script tags with data-tt-allowed="true" have TT tags * All script tags without data-tt-allowed="true" do not have TT tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196912&action=edit Bug 42094: Fix occurrence in t Patch from commit 817b7bc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42330 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42330 [Bug 42330] Use main-container.inc from all the templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42332 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 [Bug 42332] Remove conditional TT tags from tables thead -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #0)
On bug 41324 we tidy all the script tags that contained a kohaTable. Now we would like to tidy all the remaining script tags.
We will certainly need a comment in the code to flag the script tag that is used to interpolate TT variables into JS variable.
``` <script> // Accept TT tags here let js_variable = [% perl_variable %]; </script>
<script> // Here TT tags are prohibided, and ideally the code must be moved to a separate .js file // And we can reuse js_variable </script> ```
The hard part here is that let 'js_variable = [% perl_variable | html %]' or 'js_variable = [% perl_variable | uri%]' can lead Javascript string content that contains inappropriately escaped characters. Say it's a search string. If you do 'js_variable = [% perl_variable | html %]' then "this & that" becomes "this & that", which is incorrect... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|42330 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42330 [Bug 42330] Use main-container.inc from all the templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42748 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42748 [Bug 42748] Rewrite selenium/administration_tasks.t using Cypress -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug 42094 depends on bug 42290, which changed state. Bug 42290 Summary: Tidy all script tags - suggestion https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42290 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug 42094 depends on bug 42283, which changed state. Bug 42283 Summary: Tidy all script tags - cataloguing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42283 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug 42094 depends on bug 42282, which changed state. Bug 42282 Summary: Tidy all script tags - catalogue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug 42094 depends on bug 42278, which changed state. Bug 42278 Summary: Tidy all script tags - circ https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42278 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug 42094 depends on bug 42286, which changed state. Bug 42286 Summary: Tidy all script tags - ill https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42286 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug 42094 depends on bug 42281, which changed state. Bug 42281 Summary: Tidy all script tags - authorities https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42281 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug 42094 depends on bug 41653, which changed state. Bug 41653 Summary: Stores for permissions and sysprefs should be under the Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug 42094 depends on bug 42287, which changed state. Bug 42287 Summary: Tidy all script tags - members https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42287 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug 42094 depends on bug 42288, which changed state. Bug 42288 Summary: Tidy all script tags - reserve https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42288 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug 42094 depends on bug 42289, which changed state. Bug 42289 Summary: Tidy all script tags - tools https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42289 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug 42094 depends on bug 41324, which changed state. Bug 41324 Summary: Tidy kohaTable block https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug 42094 depends on bug 42280, which changed state. Bug 42280 Summary: Tidy all script tags - admin https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug 42094 depends on bug 42291, which changed state. Bug 42291 Summary: Tidy all script tags - shelves https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42291 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug 42094 depends on bug 42292, which changed state. Bug 42292 Summary: Tidy all script tags - opac https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42292 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug 42094 depends on bug 42279, which changed state. Bug 42279 Summary: Tidy all script tags - acqui https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug 42094 depends on bug 42284, which changed state. Bug 42284 Summary: Tidy all script tags - addbiblio/authorities https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42284 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug 42094 depends on bug 42293, which changed state. Bug 42293 Summary: Tidy all script tags - serials https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42293 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|25.11 |26.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #19 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- David mentioned the need for a scrubber to prevent script injection. I'm getting an error from the QA tools and /kohadevbox/koha/xt/tt_script_tidy.t fails -- I guess the failures is really pointing at issues elsewhere in the code, rather than a problem with this patch. [FAIL] t/lib/plugins/Koha/Plugin/TestValuebuilder/test_valuebuilder_popup.tt FAIL valid_template : filter not found * Proving /kohadevbox/koha/xt/tt_script_tidy.t FAIL # Failed test 'koha-tmpl/intranet-tmpl/prog/en/includes/main-container.inc has a <script> tag with Template::Toolkit tags.' # at /kohadevbox/koha/xt/tt_script_tidy.t line 73. # got: '1' # expected: '0' # Failed test 'koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc has a <script> tag with Template::Toolkit tags.' # at /kohadevbox/koha/xt/tt_script_tidy.t line 73. # got: '1' # expected: '0' # Failed test 'koha-tmpl/intranet-tmpl/prog/en/includes/wrapper-staff-tool-plugin.inc has a <script> tag with Template::Toolkit tags.' # at /kohadevbox/koha/xt/tt_script_tidy.t line 73. # got: '1' # expected: '0' # Failed test 'koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt has a <script> tag with Template::Toolkit tags.' # at /kohadevbox/koha/xt/tt_script_tidy.t line 73. # got: '1' # expected: '0' # Failed test 'koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill.tt has a <script> tag with Template::Toolkit tags.' # at /kohadevbox/koha/xt/tt_script_tidy.t line 73. # got: '1' # expected: '0' # Failed test 'koha-tmpl/intranet-tmpl/prog/en/modules/pos/printreceipt.tt has a <script> tag with Template::Toolkit tags.' # at /kohadevbox/koha/xt/tt_script_tidy.t line 73. # got: '1' # expected: '0' # Failed test 'koha-tmpl/intranet-tmpl/prog/en/modules/tools/restore-records.tt has a <script> tag with Template::Toolkit tags.' # at /kohadevbox/koha/xt/tt_script_tidy.t line 73. # got: '1' # expected: '0' # Failed test 'koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt has a <script> tag with Template::Toolkit tags.' # at /kohadevbox/koha/xt/tt_script_tidy.t line 73. # got: '1' # expected: '0' # Looks like you failed 8 tests of 2434. /kohadevbox/koha/xt/tt_script_tidy.t .. Dubious, test returned 8 (wstat 2048, 0x800) Failed 8/2434 subtests Test Summary Report ------------------- /kohadevbox/koha/xt/tt_script_tidy.t (Wstat: 2048 (exited 8) Tests: 2434 Failed: 8) Failed tests: 439, 583, 787, 1306, 1366, 1615, 1891, 2377 Non-zero exit status: 8 Files=1, Tests=2434, 1 wallclock secs ( 0.06 usr 0.01 sys + 0.20 cusr 0.03 csys = 0.30 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196911|0 |1 is obsolete| | Attachment #196912|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205530&action=edit Bug 42094: Adjust tests Rename xt/tt_kohaTable_tidy.t to xt/tt_script_tidy.t We now test all .tt and .inc files, except cataloguing/value_builder files. They are very messy and not trivial to migrate. Test plan: If you have applied all patches from the dependeng bug reports this test should now pass. We are testing that: * All files has only ONE script tag with the attribute data-tt-allowed set to "true" * All script tags with data-tt-allowed="true" have TT tags * All script tags without data-tt-allowed="true" do not have TT tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205531&action=edit Bug 42094: Fix occurrence in t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205532&action=edit Bug 42094: Allow data-tt-allowed-exception="true" on module and importmap scripts Allow a second data-tt-allowed for module and importmap To identify them clearly the attribute is data-tt-allowed-exception. Ideally we should not need that but I prefer an easy solution and not break the Vue islands. Something better to suggest? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #23 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205533&action=edit Bug 42094: main-container.inc - exception -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205534&action=edit Bug 42094: wrapper-staff-tool-plugin.inc - exception -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205535&action=edit Bug 42094: opac-user.tt - exception -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205536&action=edit Bug 42094: patron-detail-tabs.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205537&action=edit Bug 42094: admin/circulation_triggers.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205538&action=edit Bug 42094: circ/transferstoreceive.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205539&action=edit Bug 42094: ill/ill.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205540&action=edit Bug 42094: members/moremember.tt Review this with `git show -w` to remove the indentation changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #31 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205541&action=edit Bug 42094: pos/printreceipt.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #32 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205542&action=edit Bug 42094: tools/restore-records.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #33 from Jonathan Druart <jonathan.druart@gmail.com> --- All those are new occurrences, which is quite painful... People should be aware of this new rule now. reserve/request.tt and opac-user.tt are still failing, but it's failing on main already, they should be fixed as follow-up patches of bug 36868. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205530|0 |1 is obsolete| | Attachment #205531|0 |1 is obsolete| | Attachment #205532|0 |1 is obsolete| | Attachment #205533|0 |1 is obsolete| | Attachment #205534|0 |1 is obsolete| | Attachment #205535|0 |1 is obsolete| | Attachment #205536|0 |1 is obsolete| | Attachment #205537|0 |1 is obsolete| | Attachment #205538|0 |1 is obsolete| | Attachment #205539|0 |1 is obsolete| | Attachment #205540|0 |1 is obsolete| | Attachment #205541|0 |1 is obsolete| | Attachment #205542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #34 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 205574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205574&action=edit Bug 42094: Adjust tests Rename xt/tt_kohaTable_tidy.t to xt/tt_script_tidy.t We now test all .tt and .inc files, except cataloguing/value_builder files. They are very messy and not trivial to migrate. Test plan: If you have applied all patches from the dependeng bug reports this test should now pass. We are testing that: * All files has only ONE script tag with the attribute data-tt-allowed set to "true" * All script tags with data-tt-allowed="true" have TT tags * All script tags without data-tt-allowed="true" do not have TT tags Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #35 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 205575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205575&action=edit Bug 42094: Fix occurrence in t Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #36 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 205576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205576&action=edit Bug 42094: Allow data-tt-allowed-exception="true" on module and importmap scripts Allow a second data-tt-allowed for module and importmap To identify them clearly the attribute is data-tt-allowed-exception. Ideally we should not need that but I prefer an easy solution and not break the Vue islands. Something better to suggest? Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #37 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 205577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205577&action=edit Bug 42094: main-container.inc - exception Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #38 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 205578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205578&action=edit Bug 42094: wrapper-staff-tool-plugin.inc - exception Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #39 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 205579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205579&action=edit Bug 42094: opac-user.tt - exception Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #40 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 205580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205580&action=edit Bug 42094: patron-detail-tabs.inc Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #41 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 205581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205581&action=edit Bug 42094: admin/circulation_triggers.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #42 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 205582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205582&action=edit Bug 42094: circ/transferstoreceive.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #43 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 205583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205583&action=edit Bug 42094: ill/ill.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #44 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 205584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205584&action=edit Bug 42094: members/moremember.tt Review this with `git show -w` to remove the indentation changes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #45 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 205585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205585&action=edit Bug 42094: pos/printreceipt.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #46 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 205586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205586&action=edit Bug 42094: tools/restore-records.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #47 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 205587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205587&action=edit Bug 42094: (follow-up) Add missing END Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #48 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 205588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205588&action=edit Bug 42094: (follow-up) Move a stray TT block Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #49 from Owen Leonard <oleonard@myacpl.org> ---
[FAIL] t/lib/plugins/Koha/Plugin/TestValuebuilder/test_valuebuilder_popup.tt FAIL valid_template : filter not found
I'm still seeing this error but I'm not sure if it's relevant? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #50 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205590&action=edit Bug 42094: (follow-up) Fix occurrence in t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205590|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #51 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 205594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205594&action=edit Bug 42094: (follow-up) Fix occurrence in t Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Bug 42094 depends on bug 42296, which changed state. Bug 42296 Summary: Tidy all script tags - trivial ones https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205574|0 |1 is obsolete| | Attachment #205575|0 |1 is obsolete| | Attachment #205576|0 |1 is obsolete| | Attachment #205577|0 |1 is obsolete| | Attachment #205578|0 |1 is obsolete| | Attachment #205579|0 |1 is obsolete| | Attachment #205580|0 |1 is obsolete| | Attachment #205581|0 |1 is obsolete| | Attachment #205582|0 |1 is obsolete| | Attachment #205583|0 |1 is obsolete| | Attachment #205584|0 |1 is obsolete| | Attachment #205585|0 |1 is obsolete| | Attachment #205586|0 |1 is obsolete| | Attachment #205587|0 |1 is obsolete| | Attachment #205588|0 |1 is obsolete| | Attachment #205594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #52 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 205961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205961&action=edit Bug 42094: Adjust tests Rename xt/tt_kohaTable_tidy.t to xt/tt_script_tidy.t We now test all .tt and .inc files, except cataloguing/value_builder files. They are very messy and not trivial to migrate. Test plan: If you have applied all patches from the dependeng bug reports this test should now pass. We are testing that: * All files has only ONE script tag with the attribute data-tt-allowed set to "true" * All script tags with data-tt-allowed="true" have TT tags * All script tags without data-tt-allowed="true" do not have TT tags Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #53 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 205962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205962&action=edit Bug 42094: Fix occurrence in t Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #54 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 205963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205963&action=edit Bug 42094: Allow data-tt-allowed-exception="true" on module and importmap scripts Allow a second data-tt-allowed for module and importmap To identify them clearly the attribute is data-tt-allowed-exception. Ideally we should not need that but I prefer an easy solution and not break the Vue islands. Something better to suggest? Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #55 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 205964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205964&action=edit Bug 42094: main-container.inc - exception Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #56 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 205965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205965&action=edit Bug 42094: wrapper-staff-tool-plugin.inc - exception Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #57 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 205966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205966&action=edit Bug 42094: opac-user.tt - exception Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #58 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 205967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205967&action=edit Bug 42094: patron-detail-tabs.inc Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #59 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 205968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205968&action=edit Bug 42094: admin/circulation_triggers.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #60 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 205969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205969&action=edit Bug 42094: circ/transferstoreceive.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #61 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 205970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205970&action=edit Bug 42094: ill/ill.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #62 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 205971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205971&action=edit Bug 42094: members/moremember.tt Review this with `git show -w` to remove the indentation changes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #63 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 205972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205972&action=edit Bug 42094: pos/printreceipt.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #64 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 205973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205973&action=edit Bug 42094: tools/restore-records.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #65 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 205974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205974&action=edit Bug 42094: (follow-up) Add missing END Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #66 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 205975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205975&action=edit Bug 42094: (follow-up) Move a stray TT block Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #67 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 205976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205976&action=edit Bug 42094: (follow-up) Fix occurrence in t Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #68 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Rebased so it's applies again. I just had to rollback main, apply, rebase on main and it didn't even make a conflict :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #69 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Test failing due to recent patches on main reintroducing what we are getting rid of. kohadev-koha@kohadevbox:koha((65c15719c20...))$ prove xt/tt_script_tidy.t xt/tt_script_tidy.t .. 1/3249 # Failed test 'koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/patron_import.inc has a <script> tag with Template::Toolkit tags.' # at xt/tt_script_tidy.t line 78. # got: '1' # expected: '0' # Failed test 'koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt has a <script> tag with Template::Toolkit tags.' # at xt/tt_script_tidy.t line 78. # got: '1' # expected: '0' xt/tt_script_tidy.t .. 2973/3249 # Looks like you failed 2 tests of 3249. xt/tt_script_tidy.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/3249 subtests Test Summary Report ------------------- xt/tt_script_tidy.t (Wstat: 512 (exited 2) Tests: 3249 Failed: 2) Failed tests: 141, 2289 Non-zero exit status: 2 Files=1, Tests=3249, 1 wallclock secs ( 0.22 usr 0.01 sys + 0.46 cusr 0.04 csys = 0.73 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #70 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205977&action=edit Bug 42094: Fix new occurrences in patron_import.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #71 from Jonathan Druart <jonathan.druart@gmail.com> --- Fixed patron_import.inc, see comment #33 for request.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #72 from Lisette Scheer <lisette@bywatersolutions.com> --- Looks great. I added a follow-up for a new occurance. If that is the correct way, it's good to PQA, but if I did it wrong, please let me know. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205961|0 |1 is obsolete| | Attachment #205962|0 |1 is obsolete| | Attachment #205963|0 |1 is obsolete| | Attachment #205964|0 |1 is obsolete| | Attachment #205965|0 |1 is obsolete| | Attachment #205966|0 |1 is obsolete| | Attachment #205967|0 |1 is obsolete| | Attachment #205968|0 |1 is obsolete| | Attachment #205969|0 |1 is obsolete| | Attachment #205970|0 |1 is obsolete| | Attachment #205971|0 |1 is obsolete| | Attachment #205972|0 |1 is obsolete| | Attachment #205973|0 |1 is obsolete| | Attachment #205974|0 |1 is obsolete| | Attachment #205975|0 |1 is obsolete| | Attachment #205976|0 |1 is obsolete| | Attachment #205977|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #73 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206156&action=edit Bug 42094: Adjust tests Rename xt/tt_kohaTable_tidy.t to xt/tt_script_tidy.t We now test all .tt and .inc files, except cataloguing/value_builder files. They are very messy and not trivial to migrate. Test plan: If you have applied all patches from the dependeng bug reports this test should now pass. We are testing that: * All files has only ONE script tag with the attribute data-tt-allowed set to "true" * All script tags with data-tt-allowed="true" have TT tags * All script tags without data-tt-allowed="true" do not have TT tags Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #74 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206157&action=edit Bug 42094: Fix occurrence in t Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #75 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206158&action=edit Bug 42094: Allow data-tt-allowed-exception="true" on module and importmap scripts Allow a second data-tt-allowed for module and importmap To identify them clearly the attribute is data-tt-allowed-exception. Ideally we should not need that but I prefer an easy solution and not break the Vue islands. Something better to suggest? Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #76 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206159&action=edit Bug 42094: main-container.inc - exception Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #77 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206160&action=edit Bug 42094: wrapper-staff-tool-plugin.inc - exception Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #78 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206161&action=edit Bug 42094: opac-user.tt - exception Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #79 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206162&action=edit Bug 42094: patron-detail-tabs.inc Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #80 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206163&action=edit Bug 42094: admin/circulation_triggers.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #81 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206164&action=edit Bug 42094: circ/transferstoreceive.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #82 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206165&action=edit Bug 42094: ill/ill.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #83 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206166&action=edit Bug 42094: members/moremember.tt Review this with `git show -w` to remove the indentation changes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #84 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206167&action=edit Bug 42094: pos/printreceipt.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #85 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206168&action=edit Bug 42094: tools/restore-records.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #86 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206169&action=edit Bug 42094: (follow-up) Add missing END Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #87 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206170&action=edit Bug 42094: (follow-up) Move a stray TT block Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #88 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206171&action=edit Bug 42094: (follow-up) Fix occurrence in t Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #89 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206172&action=edit Bug 42094: Fix new occurrences in patron_import.inc Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #90 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206173&action=edit Bug 42094: (QA follow-up) Fix new occurence in request.tt Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #91 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lisette Scheer from comment #72)
Looks great. I added a follow-up for a new occurance. If that is the correct way, it's good to PQA, but if I did it wrong, please let me know.
Nope, this is wrong: <script nonce="[% Koha.CSPNonce | $raw %]"> + + <script nonce="[% Koha.CSPNonce | $raw %]"> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #92 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 206207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206207&action=edit Bug 42094: Fix new occurrences in reserve/request.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206173|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #93 from Lisette Scheer <lisette@bywatersolutions.com> --- Looks great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206207|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #94 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206491&action=edit Bug 42094: Fix new occurrences in reserve/request.tt Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206156|0 |1 is obsolete| | Attachment #206157|0 |1 is obsolete| | Attachment #206158|0 |1 is obsolete| | Attachment #206159|0 |1 is obsolete| | Attachment #206160|0 |1 is obsolete| | Attachment #206161|0 |1 is obsolete| | Attachment #206162|0 |1 is obsolete| | Attachment #206163|0 |1 is obsolete| | Attachment #206164|0 |1 is obsolete| | Attachment #206165|0 |1 is obsolete| | Attachment #206166|0 |1 is obsolete| | Attachment #206167|0 |1 is obsolete| | Attachment #206168|0 |1 is obsolete| | Attachment #206169|0 |1 is obsolete| | Attachment #206170|0 |1 is obsolete| | Attachment #206171|0 |1 is obsolete| | Attachment #206172|0 |1 is obsolete| | Attachment #206491|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #95 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 206560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206560&action=edit Bug 42094: Adjust tests Rename xt/tt_kohaTable_tidy.t to xt/tt_script_tidy.t We now test all .tt and .inc files, except cataloguing/value_builder files. They are very messy and not trivial to migrate. Test plan: If you have applied all patches from the dependeng bug reports this test should now pass. We are testing that: * All files has only ONE script tag with the attribute data-tt-allowed set to "true" * All script tags with data-tt-allowed="true" have TT tags * All script tags without data-tt-allowed="true" do not have TT tags Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #96 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 206561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206561&action=edit Bug 42094: Fix occurrence in t Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #97 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 206562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206562&action=edit Bug 42094: Allow data-tt-allowed-exception="true" on module and importmap scripts Allow a second data-tt-allowed for module and importmap To identify them clearly the attribute is data-tt-allowed-exception. Ideally we should not need that but I prefer an easy solution and not break the Vue islands. Something better to suggest? Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #98 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 206563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206563&action=edit Bug 42094: main-container.inc - exception Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #99 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 206564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206564&action=edit Bug 42094: wrapper-staff-tool-plugin.inc - exception Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #100 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 206565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206565&action=edit Bug 42094: opac-user.tt - exception Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #101 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 206566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206566&action=edit Bug 42094: patron-detail-tabs.inc Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #102 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 206567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206567&action=edit Bug 42094: admin/circulation_triggers.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #103 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 206568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206568&action=edit Bug 42094: circ/transferstoreceive.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #104 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 206569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206569&action=edit Bug 42094: ill/ill.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #105 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 206570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206570&action=edit Bug 42094: members/moremember.tt Review this with `git show -w` to remove the indentation changes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #106 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 206571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206571&action=edit Bug 42094: pos/printreceipt.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #107 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 206572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206572&action=edit Bug 42094: tools/restore-records.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #108 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 206573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206573&action=edit Bug 42094: (follow-up) Add missing END Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #109 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 206574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206574&action=edit Bug 42094: (follow-up) Move a stray TT block Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #110 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 206575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206575&action=edit Bug 42094: (follow-up) Fix occurrence in t Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #111 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 206576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206576&action=edit Bug 42094: Fix new occurrences in patron_import.inc Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #112 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 206577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206577&action=edit Bug 42094: Fix new occurrences in reserve/request.tt Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 --- Comment #113 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Just a rebase to fix a conflict, thanks Lisette for the QA :D -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org