[Bug 10449] New: Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Bug ID: 10449 Summary: Suggestions pending approval should count only suggestions of current branch Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.somers@biblibre.com In intranet main page and acquisition home page, a text can display the number of suggestions pending for approval. When clicking on this like, the suggestions management page is displayed. In this page, by default, only the suggestions of current branch are visible. The "Suggestions pending approval" should count only suggestions of current branch so that when clicking on link, you see the same count in "Pending" tab. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 18885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18885&action=edit Proposed patch See commit message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18885|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18985&action=edit Bug 10449 - Suggestions pending approval should count only suggestions of current branch In intranet main page and acquisition home page, a text can display the number of suggestions pending for approval. When clicking on this like, the suggestions management page is displayed. In this page, by default, only the suggestions of current branch are visible. This patch modifies "Suggestions pending approval" count so that when clicking on link, you see the same count in "Pending" tab. Test plan : - Create pending suggestions in several branches - Connect with user in koha-conf.xml to have no selected branch (you see NO LIBRARY SET) - On main page, look at "Suggestions pending approval" - Click on this link - In suggestions management page, click on "Go" near "Status" => You see the same count in "Pending" tab - Come back to main page - Select a branch (with pending suggestions) - On main page, look at "Suggestions pending approval" - Click on this link => You see the same count in "Pending" tab Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but this does no longer apply due to a conflict in the VirtualShelves.t: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 10499: VirtualShelves.t - wrap tests in a database connection Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/VirtualShelves.t CONFLICT (content): Merge conflict in t/db_dependent/VirtualShelves.t Failed to merge in the changes. Patch failed at 0001 Bug 10499: VirtualShelves.t - wrap tests in a database connection When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, forget that... I had confused my bug numbers :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi fridolyn, I have some concerns about your patch: 1) The patch works nicely according to the description, but it limits on branchcode and so suggestions created for _ANY_ library are always left out. The code used in the database for those seems to be _ANY_ - which is a bit confusing as I would have expected the branchcode column to be empty in this case. But that doesn't change anything about 1) :) 2) I am also wondering if superlibrarians should see the total count instead of a branch related one, but I think showing them the count for the branch they are logged in at is probably right. Failing QA for 1). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #6 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 19929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19929&action=edit Bug 10449 - Count suggestions without branch also See commit message -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #5)
Failing QA for 1).
Does the follow-up need signoff ? I'd say no because it is very small. I set to signed-off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #8 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #5)
The code used in the database for those seems to be _ANY_ - which is a bit confusing as I would have expected the branchcode column to be empty in this case. I think this is indeed a bug. You should open a new one.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 8274 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fridolyn, it might be a separate bug, but it means that your follow-up does not work - there is currently no way to have a suggestion which an empty branchcode. When you don't allow the patron to pick the branch in the OPAC the homelibrary will be used. When you create a suggestion for any library in staff, the branchcode is _ANY_ - so your change to the SQL query will currently have no effect: + $query .= q{ AND (branchcode='' OR branchcode=?) }; -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10753 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #11 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #10) Oh, indeed. What should I do ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, not sure right now why this got stuck. I think we should either replace the _ANY_ by an empty branchcode and correct existing suggestions or we need to make the SQL take those _ANY_ into account. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Peggy Thrasher <p.thrasher@dover.nh.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher@dover.nh.gov -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Can I know how we want to see this number calculated? On master I got all suggestions, with these 2 patches, I got the suggestions from the current branch + from any library. So the number is still different... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10753 CC| |sophie.meynieux@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #14 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Does bug 10753 help to resolve ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can this be rescued? The branch specific suggestions + any with an empty branch code sounds reasonable to me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #15)
Can this be rescued? The branch specific suggestions + any with an empty branch code sounds reasonable to me.
As far as I understand, this is the current behavior. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jonathan Druart from comment #16)
(In reply to Katrin Fischer from comment #15)
Can this be rescued? The branch specific suggestions + any with an empty branch code sounds reasonable to me.
As far as I understand, this is the current behavior.
Sorry, forget that, it's not. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Fridolin, It's not obvious that what you described in the bug description is a bug. The sentence is "XXX suggestions waiting. Manage suggestions.", it implies all suggestions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8147 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14958 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org