http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi fridolyn, I have some concerns about your patch: 1) The patch works nicely according to the description, but it limits on branchcode and so suggestions created for _ANY_ library are always left out. The code used in the database for those seems to be _ANY_ - which is a bit confusing as I would have expected the branchcode column to be empty in this case. But that doesn't change anything about 1) :) 2) I am also wondering if superlibrarians should see the total count instead of a branch related one, but I think showing them the count for the branch they are logged in at is probably right. Failing QA for 1). -- You are receiving this mail because: You are watching all bug changes.