[Bug 27458] New: Set focus for cursor to Credit type code field when creating new credit type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Bug ID: 27458 Summary: Set focus for cursor to Credit type code field when creating new credit type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: koha-bugs@lists.koha-community.org, oleonard@myacpl.org, testopia@bugs.koha-community.org When creating a new credit type in administration, it would be nice if the cursor was in the first form field "Credit type code ". See bug 27192 for a similar one. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |amyking386@gmail.com CC| |amyking386@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 --- Comment #1 from Amy King <amyking386@gmail.com> --- Created attachment 115276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115276&action=edit Bug 27458 Focus cursor to credit type code when creating new type. Test plan: Before applying patch 1. Click on Administration 2. Scroll down to Accounting and click on Credit types 3. Click New credit type 4. Note how the cursor does not focus on Credit type code field. 5. Apply patch 6. Repeat steps 1-3 7. Note how the cursor now focuses on Credit type code field. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Amy, thanks for your patch! The commit message must start with "Bug 27458: ". Can you resubmit please? -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 --- Comment #3 from Amy King <amyking386@gmail.com> --- Created attachment 115344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115344&action=edit Bug 27458: Sets cursor to focus credit type code when creating new type. Test plan: Before applying patch 1. Click on Administration 2. Scroll down to Accounting and click on Credit types 3. Click New credit type 4. Note how the cursor does not focus on Credit type code field. 5. Apply patch 6. Repeat steps 1-3 7. Note how the cursor now focuses on Credit type code field. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Amy, could you take a look at the bug linked in the first comment? The solution there is a little different using a class="focus" to the input element. I think that would be a more standardized way of doing this! There are also 2 patches here currently, you can obsolete them by going on details > edit details > obsolete or by using git bz. :) -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115276|0 |1 is obsolete| | Attachment #115344|0 |1 is obsolete| | --- Comment #5 from Amy King <amyking386@gmail.com> --- Created attachment 115377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115377&action=edit Bug 27458: cursor focueses to credit type field using class="focus" Test Plan: Before applying patch 1. Click on Administration 2. Scroll down to Accounting and click on Credit types 3. Click New credit type 4. Note hoe the cursor does not focus on Credit type code field 5. Apply patch 6. Repeat steps 1-3 7. Note how the cursor now focuses on Credity type code field -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov Status|Needs Signoff |Failed QA --- Comment #6 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- I have tried this twice and am not seeing the cursor automatically placed in the credit type code field. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- There is already a class attribute on that <input> tag, so the new "focus" value should be added to it, e.g. 'class="required focus"' -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115377|0 |1 is obsolete| | --- Comment #8 from Amy King <amyking386@gmail.com> --- Created attachment 115459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115459&action=edit Bug 27458: cursor focueses to credit type field class="required focus" Test Plan: Before applying patch 1. Click on Administration 2. Scroll down to Accounting and click on Credit types 3. Click New credit type 4. Note how the cursor does not focus on Credit type code field 5. Apply patch 6. Repeat steps 1-3 7. Note how the cursor now focuses on Credity type code field -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115459|0 |1 is obsolete| | --- Comment #9 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115468&action=edit Bug 27458: cursor focueses to credit type field class="required focus" Test Plan: Before applying patch 1. Click on Administration 2. Scroll down to Accounting and click on Credit types 3. Click New credit type 4. Note how the cursor does not focus on Credit type code field 5. Apply patch 6. Repeat steps 1-3 7. Note how the cursor now focuses on Credity type code field Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- It works! -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115468|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115522&action=edit Bug 27458: cursor focueses to credit type field class="required focus" Test Plan: Before applying patch 1. Click on Administration 2. Scroll down to Accounting and click on Credit types 3. Click New credit type 4. Note how the cursor does not focus on Credit type code field 5. Apply patch 6. Repeat steps 1-3 7. Note how the cursor now focuses on Credity type code field Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great work Amy, thanks for your contribution. All works as expected, Passing QA -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115522|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115554&action=edit Bug 27458: Set focus for cursor to Credit type code field Test Plan: Before applying patch 1. Click on Administration 2. Scroll down to Accounting and click on Credit types 3. Click New credit type 4. Note how the cursor does not focus on Credit type code field 5. Apply patch 6. Repeat steps 1-3 7. Note how the cursor now focuses on Credity type code field Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> JD amended patch: Edit commit title -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.03 released in| | --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Feel free to ask if it's needed.
actually credit_types.tt didn't exist in 19.11 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27458 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org