[Bug 27457] New: Set focus for cursor to Debit type code field when creating new debit type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Bug ID: 27457 Summary: Set focus for cursor to Debit type code field when creating new debit type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: koha-bugs@lists.koha-community.org, testopia@bugs.koha-community.org When creating a new debit type in administration, it would be nice if the cursor was in the first form field "Debit typecode ". See bug 27192 for a similar one. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mazen.i.khallaf@gmail.com Assignee|oleonard@myacpl.org |mazen.i.khallaf@gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 --- Comment #1 from Catherine <catherinem2003@gmail.com> --- Created attachment 115272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115272&action=edit Bug 27457: Set focus for cursor to Debit type code field Test Plan: 1.Click administration 2.Click debit types 3.Click new debit type 4.Check if the cursor is in the first form field (it shouldn't) 5.Add patch 6.Repeat steps 1-3 7.Check if the cursor is in the first form field (it should) Sponsored by Catalyst IT -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 --- Comment #2 from Mazen Khallaf <mazen.i.khallaf@gmail.com> --- Created attachment 115273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115273&action=edit Bug 27457: Set cursor focus to debit type code field when creating new debit type Test Plan: 1. Go to Administration 2. Go to Debit Types 3. Go to New Debit Type (Cursor shouldn't focus on 'Debit Type Code') 5. Apply Patch 6. Repeat steps 1-3 (Cursor should automatically focus on the 'Debit Type Code' field) -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There are 2 patches here, obsoleting the second one. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115273|0 |1 is obsolete| | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Thanks for your patch Catherine. A small note, try to not add unnecessary whitespace changes like: - $(document).ready(function() { + $(document).ready(function(){ -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hi Mazen, A minor point about consistency, whilst your patch does indeed work, we actually have a class hooked up already to achieve this.. so; rather than requiring the addition of the javascript you've added, you could just add a 'focus' class to the input in question instead.. which is a little terser and the preferred option. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 --- Comment #6 from Mazen Khallaf <mazen.i.khallaf@gmail.com> --- (In reply to Martin Renvoize from comment #5)
Hi Mazen,
A minor point about consistency, whilst your patch does indeed work, we actually have a class hooked up already to achieve this.. so; rather than requiring the addition of the javascript you've added, you could just add a 'focus' class to the input in question instead.. which is a little terser and the preferred option.
I'll try to keep that in mind. Thanks, Martin! -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115272|0 |1 is obsolete| | --- Comment #7 from Catherine <catherinem2003@gmail.com> --- Created attachment 115346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115346&action=edit Bug 27457: Set focus for cursor to Debit type code field Test Plan: 1.Click administration 2.Click debit types 3.Click new debit type 4.Check if the cursor is in the first form field (it shouldn't) 5.Add patch 6.Repeat steps 1-3 7.Check if the cursor is in the first form field (it should) Sponsored by Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115346|0 |1 is obsolete| | --- Comment #8 from Catherine <catherinem2003@gmail.com> --- Created attachment 115353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115353&action=edit Bug 27457: Set focus for cursor to Debit type code field Test Plan: 1.Click administration 2.Click debit types 3.Click new debit type 4.Check if the cursor is in the first form field (it shouldn't) 5.Add patch 6.Repeat steps 1-3 7.Check if the cursor is in the first form field (it should) -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115353|0 |1 is obsolete| | --- Comment #9 from Catherine <catherinem2003@gmail.com> --- Created attachment 115354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115354&action=edit Bug 27457: Set focus for cursor to Debit type code field Test Plan: 1.Click administration 2.Click debit types 3.Click new debit type 4.Check if the cursor is in the first form field (it shouldn't) 5.Add patch 6.Repeat steps 1-3 7.Check if the cursor is in the first form field (it should) Sponsored by Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Catherine and Mazen, could you please take a look at the solution from bug 27192 I posted in the first comment? I think this should work here too and will not require additional Javascript, just adding a class to the input element. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115354|0 |1 is obsolete| | --- Comment #11 from Catherine <catherinem2003@gmail.com> --- Created attachment 115461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115461&action=edit Bug 27457: Set focus for cursor to Debit type code field Test Plan: 1.Click administration 2.Click debit types 3.Click new debit type 4.Check if the cursor is in the first form field (it shouldn't) 5.Add patch 6.Repeat steps 1-3 7.Check if the cursor is in the first form field (it should) Sponsored by Catalyst IT -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115461|0 |1 is obsolete| | --- Comment #12 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115478&action=edit Bug 27457: Set focus for cursor to Debit type code field Test Plan: 1.Click administration 2.Click debit types 3.Click new debit type 4.Check if the cursor is in the first form field (it shouldn't) 5.Add patch 6.Repeat steps 1-3 7.Check if the cursor is in the first form field (it should) Sponsored by Catalyst IT Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115478|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115518&action=edit Bug 27457: Set focus for cursor to Debit type code field Test Plan: 1.Click administration 2.Click debit types 3.Click new debit type 4.Check if the cursor is in the first form field (it shouldn't) 5.Add patch 6.Repeat steps 1-3 7.Check if the cursor is in the first form field (it should) Sponsored by Catalyst IT Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Excellent work everyone, thanks. Passing QA -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | CC| |andrew@bywatersolutions.com --- Comment #17 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.03,20.05.09 |21.05.00,20.11.03,20.05.09, released in| |19.11.15 Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor@tuxayo.net --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27457 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org