[Bug 43672] New: When a patron has no advance notices value and their category is changed to one with a value the checkboxes are not enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 Bug ID: 43672 Summary: When a patron has no advance notices value and their category is changed to one with a value the checkboxes are not enabled Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Target Milestone: --- To recreate: 1 - Have two patron categories one with messaging preference default with advance notices days and email set one with no messaging preference defaults 2 - Save a patron in the category with no defaults 3 - Edit the patron, change their category to the one with a default 4 - Note the checkbox for email is disabled, but days dropdown is set 5 - Save 6 - Note the patron has days set, but no transport -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 207002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207002&action=edit Bug 43672: Pass a change event when setting the messaging preferences This patch bubbles up a change event when a days drodown is set by javascript To test: 1 - Have two patron categories one with messaging preference default with advance notices days and email set one with no messaging preference defaults 2 - Save a patron in the category with no defaults 3 - Edit the patron, change their category to the one with a default 4 - Note the checkbox for email is disabled, but days dropdown is set 5 - Save 6 - Note the patron has days set, but no transport 7 - Apply patch 8 - Repeat 9 - Confirm values set correctly on change of category 10 - Confirm value saves correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shipra.poojary@bywatersolut | |ions.com --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- *** Bug 43745 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207002|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 207486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207486&action=edit Bug 43672: Pass a change event when setting the messaging preferences This patch bubbles up a change event when a days drodown is set by javascript To test: 1 - Have two patron categories one with messaging preference default with advance notices days and email set one with no messaging preference defaults 2 - Save a patron in the category with no defaults 3 - Edit the patron, change their category to the one with a default 4 - Note the checkbox for email is disabled, but days dropdown is set 5 - Save 6 - Note the patron has days set, but no transport 7 - Apply patch 8 - Repeat 9 - Confirm values set correctly on change of category 10 - Confirm value saves correctly Signed-off-by: Kristi Krueger <KKRUEGER@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 Kathleen L. <klehman@faylib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |klehman@faylib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207486|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 --- Comment #4 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 208188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208188&action=edit Bug 43672: Pass a change event when setting the messaging preferences This patch bubbles up a change event when a days drodown is set by javascript To test: 1 - Have two patron categories one with messaging preference default with advance notices days and email set one with no messaging preference defaults 2 - Save a patron in the category with no defaults 3 - Edit the patron, change their category to the one with a default 4 - Note the checkbox for email is disabled, but days dropdown is set 5 - Save 6 - Note the patron has days set, but no transport 7 - Apply patch 8 - Repeat 9 - Confirm values set correctly on change of category 10 - Confirm value saves correctly Signed-off-by: Kristi Krueger <KKRUEGER@cuyahogalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 --- Comment #5 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 208189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208189&action=edit Bug 43672: (QA follow-up) Handle "Always update without asking" case The same change is needed for the case where UpdateMessagingPrefsOnCategoryChange is set to "Always update without asking" Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Pushed to main for 26.11 with consent from Pedro whilst he's on annual leave -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Keywords| |rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brittanie.maccarone@william | |soncounty-tn.gov, | |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.05 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43672 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords|rel_26_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org