[Bug 17656] New: Irregularities in serial prediction pattern are planned only for the current year
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Bug ID: 17656 Summary: Irregularities in serial prediction pattern are planned only for the current year Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P2 Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: koha@univ-lyon3.fr QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com When you se, through test prediction pattern, a serial pattern including planned irregularities (for example a 1/month serial that you know there's no issue on july), this is only valid fot the current subscription. Over the next renewal, you will have to set it again which is very tedious. We should be able to configure this in the long run (as it was possible in previous version of Koha before 3.14, I think) Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Summary|Irregularities in serial |Irregularities in serial |prediction pattern are |prediction pattern are |planned only for the |planned only for current |current year |subscription -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The current irregularity feature works with saving internal fictive issue numbers in a text field irregularity. If you edited/shifted some dates in serial collection, you might be surprised what happens. You cannot view the saved irregularities in serial collection (I only see e.g. 2 issues on the Planning tab); they are only visible when editing the subscription and looking at the prediction pattern again. Bug 18365 and friends made it easier to handle discrepancies in the schedule. An occasional irregularity could be resolved that way. Would it be useful to define recurring irregularities in terms of the serial frequency chosen? If it is month, we could allow the user to select one or more months to skip? Same for weeks or days. (Year seems less interesting.) Doing this would replace selection of irregulars in the prediction pattern. If so, how should we handle 'special' frequencies like 1 per 3 months or 3 per month btw? Skip all in e.g. July or refine with skip second in July etc.? It seems to me that we should make the irregularity info more visible to the user too on Serial collection form. Any feedback is appreciated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Irregularities in serial |Do we need recurring |prediction pattern are |irregularities in Serials ? |planned only for current | |subscription | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel my expectation for this was always that it will be recurring. So say I have a serial prediction pattern for 1/month and I say there is never an issue in August (vacation?), I'd want this to stick. As I understood the feature, it would allow to have patterns that are not 'regular' in some odd ways. Like 50 issues a year, mostly weekly, where the time between issues is not always the same, but some are just skipped. Not sure if we could reach out to serial librarians on the mailing list maybe? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #2)
Not sure if we could reach out to serial librarians on the mailing list maybe?
Sent to general ml. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@inlibr | |o.com, | |gaetan.boisson@biblibre.com | |, sonia.bouis@univ-lyon3.fr --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We are looking for feedback on this one - adding some names to cc in hope of more comments! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thread: https://lists.katipo.co.nz/pipermail/koha/2017-June/048380.html Sadly no comments so far. So it's Lyon 3 and me so far considering this a bug, maybe enough? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #5)
Thread: https://lists.katipo.co.nz/pipermail/koha/2017-June/048380.html
Sadly no comments so far. So it's Lyon 3 and me so far considering this a bug, maybe enough?
We can wait a little bit more :) Good things take time.. Hope to address this later, having some more feedback. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #7 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Hello Marcel, I think it's a pity not to try to find a solution if we are several libraries that miss this feature. Furthermore, it existed in the previous versions of Koha and for us, it was clearly a regression when it disappeared. If the solution proposed isn't correct, it will be Failed QA.... If you don't mind, I will change this bug title to the former one to give a chance to this feature to be back in koha. Sonia -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Do we need recurring |Irregularities in serial |irregularities in Serials ? |prediction pattern are | |planned only for current | |subscription -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Sonia, it's good information that this is a regression to the older serials module. I agree that we need to bring it back. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #9 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 68259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68259&action=edit Bug 17656 - Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for monthly or daily serials ( 1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly subscription -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #10 from Alex Arnaud <alex.arnaud@biblibre.com> --- Here is a proposal for keeping irregularities on subscription after renewal. This patch save days of week or month in a new column (permanent_irregularity). So it works only for daily and monthly subscriptions. I think that it doesn't make sense to do this for weekly... you opinion? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68259|0 |1 is obsolete| | --- Comment #11 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 68261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68261&action=edit Bug 17656 - Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for monthly or daily serials ( 1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz Status|Needs Signoff |Failed QA --- Comment #12 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Alex When checking if Wednesday and Thursday are still checked I have found that the test prediction pattern div is no longer being displayed. The errors I am getting in my intranet-error.log are: 0.0.2.2:34032] AH01215: [Fri Oct 20 00:20:18 2017] showpredictionpattern.pl: Argument "month" isn't numeric in numeric eq (==) at /home/vagrant/kohaclone/serials/showpredictionpattern.pl line 116., referer: http://localhost:8081/cgi-bin/koha/serials/subscription-add.pl?op=modify&subscriptionid=4 [Fri Oct 20 00:20:18.672718 2017] [cgi:error] [pid 7358] [client 10.0.2.2:34032] AH01215: [Fri Oct 20 00:20:18 2017] showpredictionpattern.pl: Argument "day" isn't numeric in numeric eq (==) at /home/vagrant/kohaclone/serials/showpredictionpattern.pl line 116., referer: http://localhost:8081/cgi-bin/koha/serials/subscription-add.pl?op=modify&subscriptionid=4 [Fri Oct 20 00:20:18.678244 2017] [cgi:error] [pid 7358] [client 10.0.2.2:34032] AH01215: [Fri Oct 20 00:20:18 2017] showpredictionpattern.pl: The method permanent_irregularity is not covered by tests!, referer: http://localhost:8081/cgi-bin/koha/serials/subscription-add.pl?op=modify&subscriptionid=4 Your t/db_dependent/Serials/SubscriptionIrregularity.pm test also fails because there is no test for permanent_irregularity function -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #13 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Hello Alex, Good thing for dayly and monthly publication. As for weekly issues, don't know if it's realistic but what about basing calculation on week numbering (iso 8601) ? Some review (not so unusual cases) announce clearly their "not issued weeks". Example the New Yorker publishes 5 issues that runs along 2 weeks and they are cited in the publication information block. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #14 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Alex Buckley from comment #12)
Hi Alex
When checking if Wednesday and Thursday are still checked I have found that the test prediction pattern div is no longer being displayed.
The errors I am getting in my intranet-error.log are:
0.0.2.2:34032] AH01215: [Fri Oct 20 00:20:18 2017] showpredictionpattern.pl: Argument "month" isn't numeric in numeric eq (==) at /home/vagrant/kohaclone/serials/showpredictionpattern.pl line 116., referer: http://localhost:8081/cgi-bin/koha/serials/subscription-add. pl?op=modify&subscriptionid=4 [Fri Oct 20 00:20:18.672718 2017] [cgi:error] [pid 7358] [client 10.0.2.2:34032] AH01215: [Fri Oct 20 00:20:18 2017] showpredictionpattern.pl: Argument "day" isn't numeric in numeric eq (==) at /home/vagrant/kohaclone/serials/showpredictionpattern.pl line 116., referer: http://localhost:8081/cgi-bin/koha/serials/subscription-add. pl?op=modify&subscriptionid=4 [Fri Oct 20 00:20:18.678244 2017] [cgi:error] [pid 7358] [client 10.0.2.2:34032] AH01215: [Fri Oct 20 00:20:18 2017] showpredictionpattern.pl: The method permanent_irregularity is not covered by tests!, referer: http://localhost:8081/cgi-bin/koha/serials/subscription-add. pl?op=modify&subscriptionid=4 I will fix the warning "Argument x isn't numeric" while doing the patch for weekly.
Your t/db_dependent/Serials/SubscriptionIrregularity.pm test also fails because there is no test for permanent_irregularity function
You must Launch misc/devel/update_dbix_class_files.pl to update Koha/Schema/Result/Subscription.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68261|0 |1 is obsolete| | --- Comment #15 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 68607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68607&action=edit Bug 17656 - Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for monthly, daily or weekly serials ( 1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #16 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Koha Team Lyon 3 from comment #13)
Hello Alex,
Good thing for dayly and monthly publication. As for weekly issues, don't know if it's realistic but what about basing calculation on week numbering (iso 8601) ? Some review (not so unusual cases) announce clearly their "not issued weeks". Example the New Yorker publishes 5 issues that runs along 2 weeks and they are cited in the publication information block.
Olivier Crouzet
Hello Olivier, I did it for weekly serials. Please test and give me your opinion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68607|0 |1 is obsolete| | --- Comment #17 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 68608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68608&action=edit Bug 17656 - Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for monthly, daily or weekly serials ( 1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68608|0 |1 is obsolete| | --- Comment #18 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 68665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68665&action=edit Bug 17656 - Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for monthly, daily or weekly serials ( 1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #19 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Ok Alex, I will do it as soon as possible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.bourgault@inlibro.com Status|Needs Signoff |Failed QA --- Comment #20 from David Bourgault <david.bourgault@inlibro.com> --- Test plan works as described, but QA tools warns of forbidden patterns. koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.inc FAIL forbidden patterns forbidden pattern: Do not use line breaks inside template tags (bug 18675) (line 5) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #21 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to David Bourgault from comment #20)
Test plan works as described, but QA tools warns of forbidden patterns.
koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice. inc FAIL forbidden patterns forbidden pattern: Do not use line breaks inside template tags (bug 18675) (line 5)
Hello David, I have no warning when launching the qa script (koha-qa.pl -v 3 -c 1) For the file subscription_daily_choice file i got: OK koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.inc OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #22 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Alex Arnaud from comment #21)
(In reply to David Bourgault from comment #20)
Test plan works as described, but QA tools warns of forbidden patterns.
koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice. inc FAIL forbidden patterns forbidden pattern: Do not use line breaks inside template tags (bug 18675) (line 5)
Hello David,
I have no warning when launching the qa script (koha-qa.pl -v 3 -c 1) For the file subscription_daily_choice file i got:
OK koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice. inc OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template
Sorry you are right. My QA tools was not up to date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68665|0 |1 is obsolete| | --- Comment #23 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 69124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69124&action=edit Bug 17656 - Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for monthly, daily or weekly serials ( 1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69124|0 |1 is obsolete| | --- Comment #24 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 69207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69207&action=edit Bug 17656 - Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for monthly, daily or weekly serials ( 1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #25 from David Bourgault <david.bourgault@inlibro.com> --- Test plan worked. QA tool all green except for C4/Serials.pm which warned that "POD coverage was greater before". Inspecting the file manually, this doesnt seem to be the case. I suspect that it is triggered because you remove a function and its pod, which it shouldn't warn about. Signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #26 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Hello Alex, For the three types of periodicity, the "permanent" irregularities on top of table are kept over the renewal. This is working. But the detail of excluded issues is not automatically set in relation with these ones (cf joined image).We have to manually uncheck and recheck the "permanent" irregularities to have the corresponding issues checked in the "Not published column". That's a progress in the sense that there's a trace of the previous configuration but the idea was to get all this automatically. would it be possible ? Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #27 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 69279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69279&action=edit monthly irregularities test example -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69207|0 |1 is obsolete| | --- Comment #28 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 69553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69553&action=edit Bug 17656 - Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for monthly, daily or weekly serials ( 1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #29 from Alex Arnaud <alex.arnaud@biblibre.com> --- Hello Olivier, Please re-try with this patch (just a typo in the previous). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #30 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Bonjour Alex It's ok now as far as keeping irregularities is concerned : the corrresponding issues to exclude are now automatically checked when checking the top table of "permanent" irregularities. But there's one problem remaining about multi-receiving weekly serials. The excluded issues are correctly skipped when receiving issues one by one but not when receiving through multi-receiving function. For the others two periodicities (daily and monthly), it also works with multi-receiving. I tested without patch and the problem disappears. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Olivier, thx for your great testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #32 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Koha Team Lyon 3 from comment #30)
Bonjour Alex It's ok now as far as keeping irregularities is concerned : the corrresponding issues to exclude are now automatically checked when checking the top table of "permanent" irregularities. But there's one problem remaining about multi-receiving weekly serials. The excluded issues are correctly skipped when receiving issues one by one but not when receiving through multi-receiving function.
For the others two periodicities (daily and monthly), it also works with multi-receiving.
I tested without patch and the problem disappears.
Olivier Crouzet
Hello Olivier, Can you write a test plan for this bug? I've tried the following one and it works for: - create a weekly serial from week #44 to week 50 (7 issues), - place irregularities on week #47 and #48, save, - click on Receive button on subscription detail page, - click on multi-receiving, - How many issues do you want to receive ? => 7 - I got 5 issues generated. #47 and #48 has been skipped -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #33 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Hello Alex I tested again and realized that the problem is not bound to multi-receiving function. I was focusing last time on verifying at each renewal wether issues checkboxes was checked or not and I almost missed it (and my checkings were followed by a subscription saving as a reflex). So the remaining problem is that the irregularities are not fit to new subscription unless you edit the subscription, run the test and save. If you just make the renewal the irregularities(field irregularity) are not updated. When testing I fall again upon a bug that I have already posted for ( https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15484). It's also tight with irregularities and it would be great to have look at it. Olivier -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69553|0 |1 is obsolete| | --- Comment #34 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 69814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69814&action=edit Bug 17656 - Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for monthly, daily or weekly serials ( 1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69814|0 |1 is obsolete| | --- Comment #35 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 69820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69820&action=edit Bug 17656 - Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for monthly, daily or weekly serials ( 1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #36 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 69915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69915&action=edit Bug 17656 - Update irregularities on subscription renewals Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Renew subscription from 2017-10-16 - Check that you have the prediction pattern table on renwal page - Submit renewal - Check that irregularity and permanent_irregularity column have been updated. - Do the same for a monthly and weekly subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #37 from Alex Arnaud <alex.arnaud@biblibre.com> --- Hello Olivier, The last patch add the prediction parttern table to the renewal pop-up. While renewing, you can change irregularities or let them as they were before. I think this is better than automatically update irregularities without asking the user. Please test Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #38 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Hey Alex, Happy new year I tested again the three periodicity and it works like a charm ! I agree with you about not renewing automatically and being able to modify irregularities. The more flexibility, the better. Just a thing about why I don't sign yet : I tested on top master and I had to solve a conflict (in the first patch : staff-global.css file) to be able to apply the patch. I leave you rebase the commit and I will sign it right away. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69820|0 |1 is obsolete| | --- Comment #39 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 70335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70335&action=edit Bug 17656 - Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for monthly, daily or weekly serials ( 1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69915|0 |1 is obsolete| | --- Comment #40 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 70336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70336&action=edit Bug 17656 - Update irregularities on subscription renewals Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Renew subscription from 2017-10-16 - Check that you have the prediction pattern table on renwal page - Submit renewal - Check that irregularity and permanent_irregularity column have been updated. - Do the same for a monthly and weekly subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #41 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Koha Team Lyon 3 from comment #38)
Just a thing about why I don't sign yet : I tested on top master and I had to solve a conflict (in the first patch : staff-global.css file) to be able to apply the patch. I leave you rebase the commit and I will sign it right away.
Hello Olivier, patches rebased. Happy new year! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #42 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- it works, thank you Alex ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #43 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 70335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70335 Bug 17656 - Keep irregularities during subscription renewals Review of attachment 70335: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17656&attachment=70335) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.inc @@ +1,5 @@
+<p><em> + If there is a day (or more) in the week where issues are never + published, you can check corresponding boxes below. +</em></p> +[% daily_choice = [ {name => 'monday', desc => 'Monday', value => 1}, {name => 'tuesday', desc => 'Tuesday', value => 2}, {name => 'wednesday', desc => 'Wednesday', value => 3}, {name => 'thursday', desc => 'Thursday', value => 4}, {name => 'friday', desc => 'Friday', value => 5}, {name => 'saturday', desc => 'Saturday', value => 6}, {name => 'sunday', desc => 'Sunday', value => 7} ] %]
This way the day names are not translatable ::: koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_monthly_choice.inc @@ +1,5 @@
+<p><em> + If there is a month (or more) in the year where issues are never + published, you can check corresponding boxes below. +</em></p> +[% monthly_choice = [ {name => 'january', desc => 'January', value => 1}, {name => 'february', desc => 'February', value => 2}, {name => 'march', desc => 'March', value => 3}, {name => 'april', desc => 'April', value => 4}, {name => 'may', desc => 'May', value => 5}, {name => 'june', desc => 'June', value => 6}, {name => 'july', desc => 'July', value => 7}, {name => 'august', desc => 'August', value => 8}, {name => 'september', desc => 'September', value => 9}, {name => 'october', desc => 'October', value => 10}, {name => 'november', desc => 'November', value => 11}, {name => 'december', desc => 'December', value =>12} ] %]
Month names are not translatable ::: t/Koha/DateUtils.t @@ +26,5 @@
+ +my $dt = DateTime->new(year => 2017, month => 1, day => 1); + +eval { issue_number('2017', 'day'); }; +is($@, 'Date passed to issue_number is not a valid DateTime object');
Could you please also test if the ref() of exception has right class? @@ +40,5 @@
+is(issue_number($dt, 'day'), 6, '2022-09-17 is the sixth day of week'); + +is(issue_number($dt, 'week'), 37, '2022-09-17 is the week #37 of the year'); + +is(issue_number($dt, 'month'), 9, '2017-09-17 is the ninth month of the year');
should be 2022-09-17 ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #44 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 70336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70336 Bug 17656 - Update irregularities on subscription renewals Review of attachment 70336: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17656&attachment=70336) ----------------------------------------------------------------- ::: C4/Serials.pm @@ +2713,4 @@
return @$serials; }
+=head2 GessEnddate
typo @@ +2718,5 @@
+my $enddate = GessEnddate($startdate_iso $frequencyid, $numberlength, $weeklength, $monthlength); + +=cut + +sub GuessEnddate {
Better to add new subs just to Koha namespace... but I understand it here - we do not have all the objects needed for serials management (frequencies and number patterns are missing) and calling C4 subs from Koha namespace is not good idea... If you are not willing to add needed objects, we could just fill a bug for now... ::: Koha/Subscription.pm @@ +77,5 @@
+Return the length type (issues, weeks, months) + +=cut + +sub subtype {
Maybe lengthtype would be better name? Not blocker ::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt @@ +52,5 @@
+ <input type="hidden" id="numbering3" value="[% numbering3 %]" /> + <input type="hidden" id="whenmorethan1" value="[% whenmorethan1 %]" /> + <input type="hidden" id="whenmorethan2" value="[% whenmorethan2 %]" /> + <input type="hidden" id="whenmorethan3" value="[% whenmorethan3 %]" /> + <input type="hidden" id="locale" value="[% locale %]" />
Why do you include all the data when renewing subscription? It should be not needed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #45 from Josef Moravec <josef.moravec@gmail.com> --- One more thing - you missed to add the new db column to kohastructure.sql. Also, the atomic update must be idempotent - you should always use IGNORE or helper subs like column_exists and so on - see https://wiki.koha-community.org/wiki/Database_updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #46 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Josef Moravec from comment #44)
Comment on attachment 70336 [details] [review] Bug 17656 - Update irregularities on subscription renewals
Review of attachment 70336 [details] [review]: -----------------------------------------------------------------
Better to add new subs just to Koha namespace... but I understand it here - we do not have all the objects needed for serials management (frequencies and number patterns are missing) and calling C4 subs from Koha namespace is not good idea... If you are not willing to add needed objects, we could just fill a bug for now...
Don't understand. You mean create Koha::Subscription->GuessEnddate?
::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt @@ +52,5 @@
+ <input type="hidden" id="numbering3" value="[% numbering3 %]" /> + <input type="hidden" id="whenmorethan1" value="[% whenmorethan1 %]" /> + <input type="hidden" id="whenmorethan2" value="[% whenmorethan2 %]" /> + <input type="hidden" id="whenmorethan3" value="[% whenmorethan3 %]" /> + <input type="hidden" id="locale" value="[% locale %]" />
Why do you include all the data when renewing subscription? It should be not needed!
Yes. testPredictionPattern js function needs all the data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #47 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 70430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70430&action=edit Bug 17656 - Fix QA comments - Make day and month names translatable, - Update unit tests, - Fix a typo in C4/Serials.pm (GessEndDate), - rename subtype subroutine to lengthtype - DB Change: add changes in kohastructure.sql and Bug_17656-add-permanent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #48 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 70430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70430 Bug 17656 - Fix QA comments - Make day and month names translatable, - Update unit tests, - Fix a typo in C4/Serials.pm (GessEndDate), - rename subtype subroutine to lengthtype - DB Change: add changes in kohastructure.sql and Bug_17656-add-permanent Review of attachment 70430: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17656&attachment=70430) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.inc @@ +4,2 @@
</em></p> [% daily_choice = [ {name => 'monday', desc => 'Monday', value => 1}, {name => 'tuesday', desc => 'Tuesday', value => 2}, {name => 'wednesday', desc => 'Wednesday', value => 3}, {name => 'thursday', desc => 'Thursday', value => 4}, {name => 'friday', desc => 'Friday', value => 5}, {name => 'saturday', desc => 'Saturday', value => 6}, {name => 'sunday', desc => 'Sunday', value => 7} ] %]
Looks like you do not need the "desc" values here now, is that true? ::: koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_monthly_choice.inc @@ +4,2 @@
</em></p> [% monthly_choice = [ {name => 'january', desc => 'January', value => 1}, {name => 'february', desc => 'February', value => 2}, {name => 'march', desc => 'March', value => 3}, {name => 'april', desc => 'April', value => 4}, {name => 'may', desc => 'May', value => 5}, {name => 'june', desc => 'June', value => 6}, {name => 'july', desc => 'July', value => 7}, {name => 'august', desc => 'August', value => 8}, {name => 'september', desc => 'September', value => 9}, {name => 'october', desc => 'October', value => 10}, {name => 'november', desc => 'November', value => 11}, {name => 'december', desc => 'December', value =>12} ] %]
Looks like you do not need the "desc" values here now, is that true? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #49 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Alex Arnaud from comment #46)
(In reply to Josef Moravec from comment #44)
Comment on attachment 70336 [details] [review] [review] Bug 17656 - Update irregularities on subscription renewals
Review of attachment 70336 [details] [review] [review]: -----------------------------------------------------------------
Better to add new subs just to Koha namespace... but I understand it here - we do not have all the objects needed for serials management (frequencies and number patterns are missing) and calling C4 subs from Koha namespace is not good idea... If you are not willing to add needed objects, we could just fill a bug for now...
Don't understand. You mean create Koha::Subscription->GuessEnddate?
Yes, that is what I ment.
::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt @@ +52,5 @@
+ <input type="hidden" id="numbering3" value="[% numbering3 %]" /> + <input type="hidden" id="whenmorethan1" value="[% whenmorethan1 %]" /> + <input type="hidden" id="whenmorethan2" value="[% whenmorethan2 %]" /> + <input type="hidden" id="whenmorethan3" value="[% whenmorethan3 %]" /> + <input type="hidden" id="locale" value="[% locale %]" />
Why do you include all the data when renewing subscription? It should be not needed!
Yes. testPredictionPattern js function needs all the data.
Then I think the showpredictionpattern.pl script should be changed to use stored data for parameters which weren't changed... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #50 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Josef Moravec from comment #49)
(In reply to Alex Arnaud from comment #46)
(In reply to Josef Moravec from comment #44)
Comment on attachment 70336 [details] [review] [review] [review] Bug 17656 - Update irregularities on subscription renewals
Review of attachment 70336 [details] [review] [review] [review]: -----------------------------------------------------------------
Yes. testPredictionPattern js function needs all the data.
Then I think the showpredictionpattern.pl script should be changed to use stored data for parameters which weren't changed...
Why? testPredictionPattern JS function get this data and pass them to showpredictionpattern.pl. It works exactly like in subscription-add.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #51 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Josef Moravec from comment #49)
(In reply to Alex Arnaud from comment #46)
(In reply to Josef Moravec from comment #44)
Comment on attachment 70336 [details] [review] [review] [review] Bug 17656 - Update irregularities on subscription renewals
Review of attachment 70336 [details] [review] [review] [review]: -----------------------------------------------------------------
Better to add new subs just to Koha namespace... but I understand it here - we do not have all the objects needed for serials management (frequencies and number patterns are missing) and calling C4 subs from Koha namespace is not good idea... If you are not willing to add needed objects, we could just fill a bug for now...
Don't understand. You mean create Koha::Subscription->GuessEnddate?
Yes, that is what I ment.
I see one obstacle. GuessEnddate is used with the subscription's data itself in subscription-renew.pl and with data coming from the html form in subscription-add.pl. So method calls will be: $subscription_object->GuessEnddate() in the first case, and $subscription_object->GuessEnddate($firstacquidate, $periodicity, ...) in the second one Quite tricky no? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #52 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 70619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70619&action=edit Bug 17656 - [QA followup] Remove useless description in subscription_daily_choice.inc and subscription_monthly_choice.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Alex, should this be set back to Signed off with your follow-up? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #54 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Alex Arnaud from comment #51)
(In reply to Josef Moravec from comment #49)
(In reply to Alex Arnaud from comment #46)
(In reply to Josef Moravec from comment #44)
Comment on attachment 70336 [details] [review] [review] [review] [review] Bug 17656 - Update irregularities on subscription renewals
Review of attachment 70336 [details] [review] [review] [review] [review]: -----------------------------------------------------------------
Better to add new subs just to Koha namespace... but I understand it here - we do not have all the objects needed for serials management (frequencies and number patterns are missing) and calling C4 subs from Koha namespace is not good idea... If you are not willing to add needed objects, we could just fill a bug for now...
Don't understand. You mean create Koha::Subscription->GuessEnddate?
Yes, that is what I ment.
I see one obstacle. GuessEnddate is used with the subscription's data itself in subscription-renew.pl and with data coming from the html form in subscription-add.pl. So method calls will be:
$subscription_object->GuessEnddate() in the first case, and $subscription_object->GuessEnddate($firstacquidate, $periodicity, ...) in the second one
Quite tricky no?
Not that tricky I think, you should use it like this: my $subscription_object = Koha::Subscription->new( { firstacquidate => "....", periodicity => "....", ... }); my $enddate = $subscription_object->guess_end_date; the call is always the same. It doesn't matter if it is in the database or not. If you wan't to save it to db, use ->store, but it is not an obligation. Also, please consider to change ->irregularities and ->permanent_irregularities to be getter and setter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #55 from Josef Moravec <josef.moravec@gmail.com> --- It also will need rebase again, sorry. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70335|0 |1 is obsolete| | --- Comment #56 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 75403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75403&action=edit Bug 17656 - Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for monthly, daily or weekly serials ( 1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70336|0 |1 is obsolete| | --- Comment #57 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 75404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75404&action=edit Bug 17656 - Update irregularities on subscription renewals Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Renew subscription from 2017-10-16 - Check that you have the prediction pattern table on renwal page - Submit renewal - Check that irregularity and permanent_irregularity column have been updated. - Do the same for a monthly and weekly subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70430|0 |1 is obsolete| | --- Comment #58 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 75405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75405&action=edit Bug 17656 - Fix QA comments - Make day and month names translatable, - Update unit tests, - Fix a typo in C4/Serials.pm (GessEndDate), - rename subtype subroutine to lengthtype - DB Change: add changes in kohastructure.sql and Bug_17656-add-permanent-irre -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70619|0 |1 is obsolete| | --- Comment #59 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 75406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75406&action=edit Bug 17656 - [QA followup] Remove useless description in subscription_daily_choice.inc and subscription_monthly_choice.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #60 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 75407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75407&action=edit Bug 17656: Update irregularities on multi-renewals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #61 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 75408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75408&action=edit Bug 17656: move GuessEnddate in Koha::Subscription::guess_enddate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #62 from Alex Arnaud <alex.arnaud@biblibre.com> --- I've rebased these patches. Particulary upon bug 7910 that has been pushed recently. SO, addition for the plan is: - create several subscription with permanent irregularities, - renew them using the multi-renew feature, - check that the new irregulaties are consistent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #63 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Bonjour Alex, J'étais parti, le coeur plein d'entrain, pour une nouvelle séance de test sur la nouvelle mouture de ton patch (tu as dû te régaler..), mais après mise à jour d'une master de test que j'ai sur vbox (qu'avait pas servi depuis la dernière fois), je me retrouve avec un affichage déglingué et je constate que koha cherche à charger les css et js en leur ajoutant un suffixe 18.0500000 (ça ressemble à la date de mise à jour du patch ?!) : http://preprod:8080/intranet-tmpl/prog/css/staff-global_18.0500000.css Soit j'ai fait une grosse bourde, soit il y a quelque chose qui m'échappe (voire même les deux d'ailleurs ). ça te parle ? Olivier -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #64 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Koha Team Lyon 3 from comment #63)
Bonjour Alex, J'étais parti, le coeur plein d'entrain, pour une nouvelle séance de test sur la nouvelle mouture de ton patch (tu as dû te régaler..), mais après mise à jour d'une master de test que j'ai sur vbox (qu'avait pas servi depuis la dernière fois), je me retrouve avec un affichage déglingué et je constate que koha cherche à charger les css et js en leur ajoutant un suffixe 18.0500000 (ça ressemble à la date de mise à jour du patch ?!) : http://preprod:8080/intranet-tmpl/prog/css/staff-global_18.0500000.css Soit j'ai fait une grosse bourde, soit il y a quelque chose qui m'échappe (voire même les deux d'ailleurs ). ça te parle ?
Olivier
Hello Olivier, You have to update web server's rewrite rules. See bug 20187. For apache, it is: RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].js$ $1.js [L] RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].css$ $1.css [L] Nginx: rewrite "^(.*)_[0-9]{2}\.[0-9]{7}\.(js|css)$" $1.$2; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #65 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Great ! that's much better with the js ans css rewriting rules ! I could did the test again for daily, weekly and monthly periodicities. Everything is working as expected, dates are correctly skipped, permanent irregularities are kept over the renewal. Just a little thing about ergonomy of "Week(s) not published" scrolldown list : when you tick/untick a checkbox at first time, the form jumps surprisingly. Could we avoid this ? Anyway, thank you Alex and I hope that it will be OK this time. Olivier -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75403|0 |1 is obsolete| | --- Comment #66 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 75721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75721&action=edit Bug 17656 - Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for monthly, daily or weekly serials ( 1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75404|0 |1 is obsolete| | --- Comment #67 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 75722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75722&action=edit Bug 17656 - Update irregularities on subscription renewals Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Renew subscription from 2017-10-16 - Check that you have the prediction pattern table on renwal page - Submit renewal - Check that irregularity and permanent_irregularity column have been updated. - Do the same for a monthly and weekly subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75405|0 |1 is obsolete| | --- Comment #68 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 75723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75723&action=edit Bug 17656 - Fix QA comments - Make day and month names translatable, - Update unit tests, - Fix a typo in C4/Serials.pm (GessEndDate), - rename subtype subroutine to lengthtype - DB Change: add changes in kohastructure.sql and Bug_17656-add-permanent-irre -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75406|0 |1 is obsolete| | --- Comment #69 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 75724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75724&action=edit Bug 17656 - [QA followup] Remove useless description in subscription_daily_choice.inc and subscription_monthly_choice.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75407|0 |1 is obsolete| | --- Comment #70 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 75725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75725&action=edit Bug 17656: Update irregularities on multi-renewals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75408|0 |1 is obsolete| | --- Comment #71 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 75726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75726&action=edit Bug 17656: move GuessEnddate in Koha::Subscription::guess_enddate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #72 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Koha Team Lyon 3 from comment #65)
Just a little thing about ergonomy of "Week(s) not published" scrolldown list : when you tick/untick a checkbox at first time, the form jumps surprisingly. Could we avoid this ?
Fixed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #73 from Josef Moravec <josef.moravec@gmail.com> --- I went through another round of testing. Looking good now, just one (hopefully last) issue: When the subscription is based on week, you can check irregularities for all pregenerated issues - but it works only when you check weeks from first year. Probably there should be just week numbers from 1 to 52, which could be enough. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #74 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Josef Moravec from comment #73)
I went through another round of testing. Looking good now, just one (hopefully last) issue: When the subscription is based on week, you can check irregularities for all pregenerated issues - but it works only when you check weeks from first year.
Probably there should be just week numbers from 1 to 52, which could be enough.
Don't understand. Can you give me an example ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #75 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Alex Arnaud from comment #74)
(In reply to Josef Moravec from comment #73)
I went through another round of testing. Looking good now, just one (hopefully last) issue: When the subscription is based on week, you can check irregularities for all pregenerated issues - but it works only when you check weeks from first year.
Probably there should be just week numbers from 1 to 52, which could be enough.
Don't understand. Can you give me an example ?
Here is the screenshot: https://screenshots.firefox.com/hOUt987Krzxs6uTm/localhost the other years weeks are not working - they do not set the checkboxes on previewed issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #76 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 75953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75953&action=edit Bug 17656: predication table - check all issues with same data-dow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #77 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Hello Alex I tested again but I don't see any change about what Joseph Moravec told about nor about jumping checkboxes. Am I missing something ? Olivier -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #78 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Koha Team Lyon 3 from comment #77)
Hello Alex
I tested again but I don't see any change about what Joseph Moravec told about nor about jumping checkboxes.
Am I missing something ?
Olivier
Hello Olivier, The problem Joseph talked about as i understood it is that clicking a permanent irregularity does not check all the correponding irregularities. It checks only the first one in fact. My last fix works well for me but maybe i still missunderstand anything. Joseph, can you confirm ? For the "jumping checkboxes", i did not manage to reproduce it. Can you remind me where and how it happens ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #79 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- What I understood about Joseph comment is what follows : Say we configure a weekly review from 01/01/2018 to 31/12/2018,if you set 52 issues as subscription length, it will be okay. A priori, it makes sense that you will set permanent irregularities on a single cycle/subscription (but people are strange !). If, for some reason, you put, say, 56 issues as subscription length, you will obtain as much checkboxes in the checkboxes lists. In the "weeks not published" scrolldown list, you will have four extra checkboxes (corresponding to weeks 1,2,3,4 of year 2019). If you check one of these weeks, the corresponding checkbox will not be checked on the fixed list and you risk not to notice this. It's the reason why, I guess, Joseph suggests to limit the displayed list to 52 weeks (Some year may have 53 weeks according to iso numbering. may be we can limit by end date of current year. Problem, I'm thinking that some subscription (and numbering) begin in the middle of the year and finish the year after like New York Review. as for "jumping checkboxes", It occurs in the "weeks not published" scrolldown list and only at first checkbox checking. the second checking you do, no problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #80 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Sorry the patches could not apply, can you please rebase Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17656 - Keep irregularities during subscription renewals Using index info to reconstruct a base tree... M C4/Serials.pm M koha-tmpl/intranet-tmpl/prog/css/staff-global.css M koha-tmpl/intranet-tmpl/prog/en/modules/serials/showpredictionpattern.tt M serials/subscription-add.pl Falling back to patching base and 3-way merge... Auto-merging serials/subscription-add.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/showpredictionpattern.tt Auto-merging koha-tmpl/intranet-tmpl/prog/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/staff-global.css Auto-merging C4/Serials.pm Failed to merge in the changes. Patch failed at 0001 Bug 17656 - Keep irregularities during subscription renewals The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-17656---Keep-irregularities-during-subscriptio-4ETfMG.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #81 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Major bug, can we please get a rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #82 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #81)
Major bug, can we please get a rebase?
Still waiting and hoping for a rebase... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75721|0 |1 is obsolete| | --- Comment #83 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 102724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102724&action=edit Bug 17656 - Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for monthly, daily or weekly serials ( 1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75722|0 |1 is obsolete| | --- Comment #84 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 102725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102725&action=edit Bug 17656 - Update irregularities on subscription renewals Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Renew subscription from 2017-10-16 - Check that you have the prediction pattern table on renwal page - Submit renewal - Check that irregularity and permanent_irregularity column have been updated. - Do the same for a monthly and weekly subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75723|0 |1 is obsolete| | --- Comment #85 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 102726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102726&action=edit Bug 17656 - Fix QA comments - Make day and month names translatable, - Update unit tests, - Fix a typo in C4/Serials.pm (GessEndDate), - rename subtype subroutine to lengthtype - DB Change: add changes in kohastructure.sql and Bug_17656-add-permanent-irre -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75724|0 |1 is obsolete| | --- Comment #86 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 102727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102727&action=edit Bug 17656 - [QA followup] Remove useless description in subscription_daily_choice.inc and subscription_monthly_choice.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75725|0 |1 is obsolete| | --- Comment #87 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 102728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102728&action=edit Bug 17656: Update irregularities on multi-renewals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75726|0 |1 is obsolete| | --- Comment #88 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 102729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102729&action=edit Bug 17656: move GuessEnddate in Koha::Subscription::guess_enddate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75953|0 |1 is obsolete| | --- Comment #89 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 102730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102730&action=edit Bug 17656: predication table - check all issues with same data-dow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #90 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Katrin Fischer from comment #82)
(In reply to Katrin Fischer from comment #81)
Major bug, can we please get a rebase?
Still waiting and hoping for a rebase...
Patches rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102724|0 |1 is obsolete| | Attachment #102725|0 |1 is obsolete| | Attachment #102726|0 |1 is obsolete| | Attachment #102727|0 |1 is obsolete| | Attachment #102728|0 |1 is obsolete| | Attachment #102729|0 |1 is obsolete| | Attachment #102730|0 |1 is obsolete| | --- Comment #91 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102860&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #92 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102861&action=edit Bug 17656: Update irregularities on subscription renewals Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Renew subscription from 2017-10-16 - Check that you have the prediction pattern table on renwal page - Submit renewal - Check that irregularity and permanent_irregularity column have been updated. - Do the same for a monthly and weekly subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #93 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102862&action=edit Bug 17656: Fix issues found by QA - Make day and month names translatable - Update unit tests - Fix a typo in C4/Serials.pm (GessEndDate) - Rename subtype subroutine to lengthtype - DB Change: add changes in kohastructure.sql and Bug_17656-add-permanent-irregularities.perl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #94 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102863&action=edit Bug 17656: (QA follow-up) Remove useless description in subscription_daily_choice.inc and subscription_monthly_choice.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #95 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102864&action=edit Bug 17656: Update irregularities on multi-renewals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #96 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102865&action=edit Bug 17656: Move GuessEnddate in Koha::Subscription::guess_enddate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #97 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102866&action=edit Bug 17656: Predication table - check all issues with same data-dow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #98 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102867&action=edit Bug 17656: (follow-up) Add missing filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #99 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Alex, I've cleaned up the commit messages and added the missing filters to make the QA tools happy, but I got 2 remaining issues in the QA script: FAIL serials/subscription-renew.pl FAIL valid "my" variable $subscription masks earlier declaration in same scope FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/showpredictionpattern.tt OK filters FAIL forbidden patterns forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 9) Could you have a look at those please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102860|0 |1 is obsolete| | --- Comment #100 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 102960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102960&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102861|0 |1 is obsolete| | --- Comment #101 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 102961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102961&action=edit Bug 17656: Update irregularities on subscription renewals Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Renew subscription from 2017-10-16 - Check that you have the prediction pattern table on renwal page - Submit renewal - Check that irregularity and permanent_irregularity column have been updated. - Do the same for a monthly and weekly subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102862|0 |1 is obsolete| | --- Comment #102 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 102962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102962&action=edit Bug 17656: Fix issues found by QA - Make day and month names translatable - Update unit tests - Fix a typo in C4/Serials.pm (GessEndDate) - Rename subtype subroutine to lengthtype - DB Change: add changes in kohastructure.sql and Bug_17656-add-permanent-irregularities.perl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102863|0 |1 is obsolete| | --- Comment #103 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 102963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102963&action=edit Bug 17656: (QA follow-up) Remove useless description in subscription_daily_choice.inc and subscription_monthly_choice.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102864|0 |1 is obsolete| | --- Comment #104 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 102964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102964&action=edit Bug 17656: Update irregularities on multi-renewals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102865|0 |1 is obsolete| | --- Comment #105 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 102965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102965&action=edit Bug 17656: Move GuessEnddate in Koha::Subscription::guess_enddate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102866|0 |1 is obsolete| | --- Comment #106 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 102966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102966&action=edit Bug 17656: Predication table - check all issues with same data-dow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102867|0 |1 is obsolete| | --- Comment #107 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 102967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102967&action=edit Bug 17656: (follow-up) Add missing filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #108 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 102968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102968&action=edit Bug 17656: fix QA tools warnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #109 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Katrin Fischer from comment #99)
Hi Alex,
I've cleaned up the commit messages and added the missing filters to make the QA tools happy, but I got 2 remaining issues in the QA script:
FAIL serials/subscription-renew.pl FAIL valid "my" variable $subscription masks earlier declaration in same scope
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/showpredictionpattern.tt OK filters FAIL forbidden patterns forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 9)
Could you have a look at those please?
Katrin, QA warnings are fixed. Also, i did a tiny rebase again. Thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #110 from David Nind <david@davidnind.com> --- Patch no longer applies 8-(: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17656: Keep irregularities during subscription renewals Using index info to reconstruct a base tree... M C4/Serials.pm M koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss M koha-tmpl/intranet-tmpl/prog/css/staff-global.css Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/staff-global.css Auto-merging koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss Auto-merging C4/Serials.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 17656: Keep irregularities during subscription renewals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102960|0 |1 is obsolete| | --- Comment #111 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 103623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103623&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102961|0 |1 is obsolete| | --- Comment #112 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 103624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103624&action=edit Bug 17656: Update irregularities on subscription renewals Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Renew subscription from 2017-10-16 - Check that you have the prediction pattern table on renwal page - Submit renewal - Check that irregularity and permanent_irregularity column have been updated. - Do the same for a monthly and weekly subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102962|0 |1 is obsolete| | --- Comment #113 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 103625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103625&action=edit Bug 17656: Fix issues found by QA - Make day and month names translatable - Update unit tests - Fix a typo in C4/Serials.pm (GessEndDate) - Rename subtype subroutine to lengthtype - DB Change: add changes in kohastructure.sql and Bug_17656-add-permanent-irregularities.perl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102963|0 |1 is obsolete| | --- Comment #114 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 103626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103626&action=edit Bug 17656: (QA follow-up) Remove useless description in subscription_daily_choice.inc and subscription_monthly_choice.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102964|0 |1 is obsolete| | --- Comment #115 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 103627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103627&action=edit Bug 17656: Update irregularities on multi-renewals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102965|0 |1 is obsolete| | --- Comment #116 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 103628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103628&action=edit Bug 17656: Move GuessEnddate in Koha::Subscription::guess_enddate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102966|0 |1 is obsolete| | --- Comment #117 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 103629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103629&action=edit Bug 17656: Predication table - check all issues with same data-dow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102967|0 |1 is obsolete| | --- Comment #118 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 103630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103630&action=edit Bug 17656: (follow-up) Add missing filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102968|0 |1 is obsolete| | --- Comment #119 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 103631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103631&action=edit Bug 17656: fix QA tools warnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #120 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to David Nind from comment #110)
Patch no longer applies 8-(:
Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17656: Keep irregularities during subscription renewals Using index info to reconstruct a base tree... M C4/Serials.pm M koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss M koha-tmpl/intranet-tmpl/prog/css/staff-global.css Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/staff-global.css Auto-merging koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss Auto-merging C4/Serials.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 17656: Keep irregularities during subscription renewals
Patches rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103623|0 |1 is obsolete| | --- Comment #121 from David Nind <david@davidnind.com> --- Created attachment 103657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103657&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103624|0 |1 is obsolete| | --- Comment #122 from David Nind <david@davidnind.com> --- Created attachment 103658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103658&action=edit Bug 17656: Update irregularities on subscription renewals Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Renew subscription from 2017-10-16 - Check that you have the prediction pattern table on renwal page - Submit renewal - Check that irregularity and permanent_irregularity column have been updated. - Do the same for a monthly and weekly subscription Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103625|0 |1 is obsolete| | --- Comment #123 from David Nind <david@davidnind.com> --- Created attachment 103659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103659&action=edit Bug 17656: Fix issues found by QA - Make day and month names translatable - Update unit tests - Fix a typo in C4/Serials.pm (GessEndDate) - Rename subtype subroutine to lengthtype - DB Change: add changes in kohastructure.sql and Bug_17656-add-permanent-irregularities.perl Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103626|0 |1 is obsolete| | --- Comment #124 from David Nind <david@davidnind.com> --- Created attachment 103660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103660&action=edit Bug 17656: (QA follow-up) Remove useless description in subscription_daily_choice.inc and subscription_monthly_choice.inc Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103627|0 |1 is obsolete| | --- Comment #125 from David Nind <david@davidnind.com> --- Created attachment 103661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103661&action=edit Bug 17656: Update irregularities on multi-renewals Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103628|0 |1 is obsolete| | --- Comment #126 from David Nind <david@davidnind.com> --- Created attachment 103662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103662&action=edit Bug 17656: Move GuessEnddate in Koha::Subscription::guess_enddate Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103629|0 |1 is obsolete| | --- Comment #127 from David Nind <david@davidnind.com> --- Created attachment 103663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103663&action=edit Bug 17656: Predication table - check all issues with same data-dow Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103630|0 |1 is obsolete| | --- Comment #128 from David Nind <david@davidnind.com> --- Created attachment 103664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103664&action=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103631|0 |1 is obsolete| | --- Comment #129 from David Nind <david@davidnind.com> --- Created attachment 103665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103665&action=edit Bug 17656: fix QA tools warnings Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #130 from David Nind <david@davidnind.com> --- Created attachment 103667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103667&action=edit Bug 17656 - Image of renewal form (In reply to Alex Arnaud from comment #120)
Patches rebased
Thanks Alex! Everything seems to work as per the test plan. I've signed-off, but I'm not sure that the renewal form displays correctly - see screenshot attached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #131 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #132 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL installer/data/mysql/atomicupdate/Bug_17656-add-permanent-irregularities.sql FAIL git manipulation The file has been added and deleted in the same patchset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #133 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- - $periodicity, $firstacquidate, $irregularity, $numberpattern, $locale, - $numberlength, $weeklength, $monthlength, $lastvalue1, $innerloop1, - $lastvalue2, $innerloop2, $lastvalue3, $innerloop3, $status, - $biblionumber, $callnumber, $notes, $letter, $manualhistory, - $internalnotes, $serialsadditems, $staffdisplaycount, $opacdisplaycount, - $graceperiod, $location, $enddate, $subscriptionid, $skip_serialseq, - $itemtype, $previousitemtype, $mana_id + $periodicity, $firstacquidate, $irregularity, $permanent_irregularity, + $numberpattern, $locale, $numberlength, $weeklength, $monthlength, + $lastvalue1, $innerloop1, $lastvalue2, $innerloop2, $lastvalue3, + $innerloop3, $status, $biblionumber, $callnumber, $notes, $letter, + $manualhistory, $internalnotes, $serialsadditems, $staffdisplaycount, + $opacdisplaycount, $graceperiod, $location, $enddate, $subscriptionid, + $skip_serialseq, $itemtype, $previousitemtype, $mana_id Doing things like this does not life make easier for QA. Do I now have to check if every parameter is still there? You could have added the permanent_irregularity without touching all the other lines. And you can still fix it too? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #134 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Same remark for this: - librarian => $auser, - branchcode => $branchcode, - aqbooksellerid => $aqbooksellerid, - cost => $cost, - aqbudgetid => $aqbudgetid, - biblionumber => $biblionumber, - startdate => $startdate, - periodicity => $periodicity, - numberlength => $numberlength, - weeklength => $weeklength, - monthlength => $monthlength, - lastvalue1 => $lastvalue1, - innerloop1 => $innerloop1, - lastvalue2 => $lastvalue2, - innerloop2 => $innerloop2, - lastvalue3 => $lastvalue3, - innerloop3 => $innerloop3, - status => $status, - notes => $notes, - letter => $letter, - firstacquidate => $firstacquidate, - irregularity => $irregularity, - numberpattern => $numberpattern, - locale => $locale, - callnumber => $callnumber, - manualhistory => $manualhistory, - internalnotes => $internalnotes, - serialsadditems => $serialsadditems, - staffdisplaycount => $staffdisplaycount, - opacdisplaycount => $opacdisplaycount, - graceperiod => $graceperiod, - location => $location, - enddate => $enddate, - skip_serialseq => $skip_serialseq, - itemtype => $itemtype, - previousitemtype => $previousitemtype, - mana_id => $mana_id, + librarian => $auser, + branchcode => $branchcode, + aqbooksellerid => $aqbooksellerid, + cost => $cost, + aqbudgetid => $aqbudgetid, + biblionumber => $biblionumber, + startdate => $startdate, + periodicity => $periodicity, + numberlength => $numberlength, etc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #135 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- +=head2 GessEnddate + +my $enddate = GessEnddate($startdate_iso $frequencyid, $numberlength, $weeklength, $monthlength); + +=cut + +sub GuessEnddate { The routine name should obviously be the same in POD and code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #136 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #135)
+=head2 GessEnddate + +my $enddate = GessEnddate($startdate_iso $frequencyid, $numberlength, $weeklength, $monthlength); + +=cut + +sub GuessEnddate {
The routine name should obviously be the same in POD and code.
Seeing a correction now. Reason for some squashing ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #137 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- You add a routine to DateUtils called issue_number: +my $week_number = issue_number('2017-01-01', 'week'); What you actually want is a day-of-week, week number or month. The name is confusing. I do not expect an issue_number in DateUtils. The POD is wrong since you expect a dt and raise an exception on a string. + return Day_of_Week(split /-/, $date->ymd); Please consider using a DateTime function here: $dt->day_of_week() $dt->wday() and $dt->dow(). $dt->local_day_of_week() Actually $dt->dow is shorter than issue_number($dt, 'week') + return $date->month; In this case it is more work to call issue_number($dt, 'month') than to say $dt->month. + my $dow = issue_number( dt_from_string($date), $frequency->unit ); This is a bit confusing. If we do not know the unit, how could we save it into dow (day of week) ? Rename ? I recommend to remove issue_number from DateUtils. We could move it to Serials? It is a thin wrapper to three DateTime methods. If you want to keep it in DateUtils, we should come up with a convincing name. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #138 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- +my $subscription_o = Koha::Subscriptions->find($subscription->{subscriptionid}); +my @irreg = $subscription_o->irregularities; +is($irreg[0], 2, 'First element of irregularities is 2'); +is($irreg[1], 4, 'Second element of irregularities is 4'); +is($irreg[2], 7, 'Third element of irregularities is 7'); + +my @permanent_irreg = $subscription_o->permanent_irregularities; +is($permanent_irreg[0], 1, 'First element of permanent_irregularities is 1'); +is($permanent_irreg[1], 2, 'Second element of permanent_irregularities is 2'); Do we really need this? You add a separate script here to test if split /;/ works ? I appreciate your willingness to test, but I have the impression that we should focus here on complex exceptions with various frequencies, different months, leap years, etc. Think of various date peculiarities. Elaborating on that, t/db_dependent/Koha/Subscription/Irregularities.t contains a lot of code, but actually only one test. + is($irregularities, '10;11', 'Irregularities have been updated'); Since this looks like the most important test, I would really expect more testing here. Maybe you should think of some intelligent mocks here to reduce a lot of building calls? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #139 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Since we already got into string freeze, I leave it for now. Please resubmit your work in some squashed way. Perhaps divide the module changes, tests, script and template changes, and db revisions over separate patches. Thanks ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26054 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103657|0 |1 is obsolete| | Attachment #103658|0 |1 is obsolete| | Attachment #103659|0 |1 is obsolete| | Attachment #103660|0 |1 is obsolete| | Attachment #103661|0 |1 is obsolete| | Attachment #103662|0 |1 is obsolete| | Attachment #103663|0 |1 is obsolete| | Attachment #103664|0 |1 is obsolete| | Attachment #103665|0 |1 is obsolete| | --- Comment #140 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 117789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117789&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #141 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 117790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117790&action=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #142 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 117791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117791&action=edit Bug 17656: [DO NOT PUSH] provide schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #143 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 117792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117792&action=edit Bug 17656: [DO NOT PUSH] provide css file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #144 from Alex Arnaud <alex.arnaud@biblibre.com> --- Patches rebased and squashed. @Marcel, I took your QA remarks into account. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #145 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- CSS is already conflicting - I will leave this patch off for testing running yarn build locally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual, | |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #146 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but there are quite some QA fails here :( It looks like the first could be a rebase issue? FAIL C4/Serials.pm FAIL valid Constant subroutine C4::Serials::MISSING_LOST redefined Constant subroutine C4::Serials::MISSING_NEVER_RECIEVED redefined Constant subroutine C4::Serials::STOPPED redefined Constant subroutine C4::Serials::DELETED redefined Constant subroutine C4::Serials::MISSING_DAMAGED redefined Constant subroutine C4::Serials::EXPECTED redefined Constant subroutine C4::Serials::LATE redefined Constant subroutine C4::Serials::MISSING_SOLD_OUT redefined Constant subroutine C4::Serials::ARRIVED redefined Constant subroutine C4::Serials::NOT_ISSUED redefined Constant subroutine C4::Serials::CLAIMED redefined Constant subroutine C4::Serials::MISSING redefined FAIL t/Serials/IssueNumber.t OK critic FAIL file permissions File must have the exec flag FAIL t/db_dependent/Koha/Subscription/GuessEnddate.t OK critic FAIL file permissions File must have the exec flag FAIL t/db_dependent/Koha/Subscription/Irregularities.t OK critic FAIL file permissions File must have the exec flag FAIL t/db_dependent/Serials/SubscriptionIrregularity.t OK critic FAIL file permissions File must have the exec flag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117792|0 |1 is obsolete| | --- Comment #147 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 117846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117846&action=edit Bug 17656: [DO NOT PUSH] provide css file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #148 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 117851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117851&action=edit Bug 17656: QA warnings fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117851|0 |1 is obsolete| | --- Comment #149 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 117852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117852&action=edit Bug 17656: QA warnings fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117852|0 |1 is obsolete| | --- Comment #150 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 118856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118856&action=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi <amarangikarunathilaka@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #151 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- Hello Alex, Sorry but when I record a subscription after adding irregularities via Test prediction pattern and I click on Save Subscription button, I get this error : The method Koha::Subscriptions->startdate is not covered by tests! I tried to create a new subs and that time it was OK. But when I create another sub for testing another type of frequency I got this error again. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #152 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- Some more details : I tried a daily frequency with the following data : 05/04/2021 to 11/04/2021 (french notation = 5 april 2021 to 11 april 2021) first issue 05/04/2021 subs start : idem issues 7 subs end : 11/04/2021 wednesday and thursday are checked as irregulars multireceiving 5 items renewing : wednesday and thursday are still checked. That's OK but when I submit the form, the following message is displayed : "Renewing is cancelled, contact the administrator" Going back to Editing subscription, in Test pattern it's said : End date is not consistent with subscription length. Indeed end date is remained on 11/04/2021 I decided to delete enddate and let it making itself but when saving I get again the error message "The method Koha::Subscriptions->startdate is not covered by tests!" Olivier -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #153 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 119106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119106&action=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #154 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- Hello, I testes this time on Ptfx Sandbox. no more message "Renewal cancelled". Sorry, I think this was template problem on my instance. It's OK now for startdate error message. Everything works as expected as for daily and monthly frequencies. Exceptions are kept. date are skipped when receiving as well. But unfortunately weekly frequency does not work. Irregularities are not retained : my parameters : first issue publ. date 01/01/2021 startdate 01/01/2021 issues 52 enddate 31/12/2021 I checked 8 and 15 feb 2021 They are recorded ok I multireceived 50 issues and click on Renew button but no weeks are no more checked on the form. Olivier -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #155 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for all the testing going on here! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #156 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Koha Team University Lyon 3 from comment #154)
I checked 8 and 15 feb 2021 They are recorded ok I multireceived 50 issues and click on Renew button but no weeks are no more checked on the form.
Olivier
Olivier, Did you check the weeks in the list above the prediction table ? Doing so works for me. If you check weeks inside the prediction table (column "Not published"), they are not saved as permanent irregularities but as irregularities. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #157 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- Oh ! stupid ! I did'nt get it !. I think I only checked the flat list below. I redo the test checking the irregularities in the choice list and you are right it-s OK : this time irregularities are kept. I will sign off but I have 2 last suggestions : I think all the same, the display for weeks type is little ambiguous : The presence of 2 wordings very close can be troubling Please check the issues that are NOT published (irregularities) and below : Choice the weeks in the year where the issues are not published May be, in this case, the second is redundant. I would suggest to suppress the second and make the first like this : Please check in the dropdown list, the issues that are NOT published (irregularities) and last thing : the "Weeks(s)not_published" form is jumping when we check a checkbox. Could you add a "return false" to "Check_permanent_irregularities" function to prevent this ? Olivier -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #158 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 120863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120863&action=edit Bug 17656: More meaningful messages in prediction pattern table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #159 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Koha Team University Lyon 3 from comment #157)
Please check the issues that are NOT published (irregularities) and below : Choice the weeks in the year where the issues are not published
May be, in this case, the second is redundant. I would suggest to suppress the second and make the first like this : Please check in the dropdown list, the issues that are NOT published (irregularities)
and last thing : the "Weeks(s)not_published" form is jumping when we check a checkbox. Could you add a "return false" to "Check_permanent_irregularities" function to prevent this ?
Olivier
Olivier, Please test my proposal for meaningful messages. Also, fixed the jump on top of the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #160 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- Hey Alex, Great ! That's perfect. Hope this patch will be in master soon, what's the english for "je croise les doigt" ? fingers crossed ? Olivier -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |victor@tuxayo.net --- Comment #161 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Koha Team University Lyon 3 from comment #160)
Hope this patch will be in master soon, what's the english for "je croise les doigt" ? fingers crossed ?
yes ^^" Too bad I hit an issue when testing however :o (In reply to Koha Team University Lyon 3 from comment #151)
The method Koha::Subscriptions->startdate is not covered by tests!
same! details - rebuilt schema files[1] - new subscription - record 146 from sample data - first publication date: 05/02/2021 - Frequency 1/day - start date 05/02/2021 - numbering pattern number - Subscription length: 7 - not published: 05/04/2021 & 05/05/2021 - save The method Koha::Subscriptions->startdate is not covered by tests! [1] dbic command from koha-testing-docker mysql -h db -ppassword -uroot -e 'DROP DATABASE IF EXISTS dbic; CREATE DATABASE dbic' cd '/kohadevbox/koha' mysql -h db -ppassword -uroot dbic < installer/data/mysql/kohastructure.sql misc/devel/update_dbix_class_files.pl --db_name dbic --db_host db --db_user root --db_passwd password Did I do something wrong? Reverted to "need signoff" so it's not in the signoff queue. Which would cause someone from QA to look at it, pass it and don't look a it later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117789|0 |1 is obsolete| | --- Comment #162 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 121082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121082&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117790|0 |1 is obsolete| | --- Comment #163 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 121083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121083&action=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117791|0 |1 is obsolete| | --- Comment #164 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 121084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121084&action=edit Bug 17656: [DO NOT PUSH] provide schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117846|0 |1 is obsolete| | --- Comment #165 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 121085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121085&action=edit Bug 17656: [DO NOT PUSH] provide css file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118856|0 |1 is obsolete| | --- Comment #166 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 121086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121086&action=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi <amarangikarunathilaka@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119106|0 |1 is obsolete| | --- Comment #167 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 121087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121087&action=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120863|0 |1 is obsolete| | --- Comment #168 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 121088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121088&action=edit Bug 17656: More meaningful messages in prediction pattern table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #169 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Victor Grousset/tuxayo from comment #161)
The method Koha::Subscriptions->startdate is not covered by tests!
Victor, it's ok now. I squashed the fix in "use Koha::Subscription->startdate instead of Koha::Subscriptions" patch. It's the same problem in other place. Patches rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121082|0 |1 is obsolete| | --- Comment #170 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121192&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121083|0 |1 is obsolete| | --- Comment #171 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121193&action=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121084|0 |1 is obsolete| | --- Comment #172 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121194&action=edit Bug 17656: [DO NOT PUSH] provide schema file Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121085|0 |1 is obsolete| | --- Comment #173 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121195&action=edit Bug 17656: [DO NOT PUSH] provide css file Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121086|0 |1 is obsolete| | --- Comment #174 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121196&action=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi <amarangikarunathilaka@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121087|0 |1 is obsolete| | --- Comment #175 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121197&action=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121088|0 |1 is obsolete| | --- Comment #176 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121198&action=edit Bug 17656: More meaningful messages in prediction pattern table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #177 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works :) Thanks for the fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121192|0 |1 is obsolete| | --- Comment #178 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121296&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121193|0 |1 is obsolete| | --- Comment #179 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121297&action=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121194|0 |1 is obsolete| | --- Comment #180 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121298&action=edit Bug 17656: [DO NOT PUSH] provide schema file Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121195|0 |1 is obsolete| | --- Comment #181 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121299&action=edit Bug 17656: [DO NOT PUSH] provide css file Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121196|0 |1 is obsolete| | --- Comment #182 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121300&action=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi <amarangikarunathilaka@gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121197|0 |1 is obsolete| | --- Comment #183 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121301&action=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121198|0 |1 is obsolete| | --- Comment #184 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121302&action=edit Bug 17656: More meaningful messages in prediction pattern table Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #185 from Victor Grousset/tuxayo <victor@tuxayo.net> --- For some reason not all commits had the signed off mark. I confirm having tested with all applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@helsinki.fi --- Comment #186 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Adds unused function _get_sub_length which should be removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an issue where release notes| |irregularities are lost | |when renewing a | |subscription. Now when | |renewing a subscription | |irregularities are kept for | |daily, weekly and monthly | |serials (1 unit per issue | |only). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Patch doesn't apply --- Comment #187 from Nick Clemens <nick@bywatersolutions.com> --- Doesn't apply, please remove unused function in comment 186 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121296|0 |1 is obsolete| | --- Comment #188 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128489&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121297|0 |1 is obsolete| | --- Comment #189 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128491&action=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121298|0 |1 is obsolete| | --- Comment #190 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128492&action=edit Bug 17656: [DO NOT PUSH] provide schema file Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121299|0 |1 is obsolete| | --- Comment #191 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128493&action=edit Bug 17656: [DO NOT PUSH] provide css file Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121300|0 |1 is obsolete| | --- Comment #192 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128494&action=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi <amarangikarunathilaka@gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121301|0 |1 is obsolete| | --- Comment #193 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128495&action=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121302|0 |1 is obsolete| | --- Comment #194 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128496&action=edit Bug 17656: More meaningful messages in prediction pattern table Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128489|0 |1 is obsolete| | --- Comment #195 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128498&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128491|0 |1 is obsolete| | --- Comment #196 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128499&action=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128492|0 |1 is obsolete| | --- Comment #197 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128500&action=edit Bug 17656: [DO NOT PUSH] provide schema file Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128493|0 |1 is obsolete| | --- Comment #198 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128501&action=edit Bug 17656: [DO NOT PUSH] provide css file Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128494|0 |1 is obsolete| | --- Comment #199 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128502&action=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi <amarangikarunathilaka@gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128495|0 |1 is obsolete| | --- Comment #200 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128503&action=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128496|0 |1 is obsolete| | --- Comment #201 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128504&action=edit Bug 17656: More meaningful messages in prediction pattern table Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |thibaud.guillot@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #202 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Patchs rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Status|Needs Signoff |Patch doesn't apply --- Comment #203 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Patch doesn't apply : <pre> root@kohadevbox:koha(bz17656)$ git bz apply 17656 Bug 17656 - Irregularities in serial prediction pattern are planned only for current subscription 128498 - Bug 17656: Keep irregularities during subscription renewals 128499 - Bug 17656: (follow-up) Add missing filters 128500 - Bug 17656: [DO NOT PUSH] provide schema file 128501 - Bug 17656: [DO NOT PUSH] provide css file 128502 - Bug 17656: QA warnings fixes 128503 - Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions 128504 - Bug 17656: More meaningful messages in prediction pattern table Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17656: Keep irregularities during subscription renewals Using index info to reconstruct a base tree... M C4/Serials.pm M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss M koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt M koha-tmpl/intranet-tmpl/prog/js/subscription-add.js M serials/subscription-add.pl Falling back to patching base and 3-way merge... Auto-merging serials/subscription-add.pl Auto-merging koha-tmpl/intranet-tmpl/prog/js/subscription-add.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/subscription-add.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt Auto-merging koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Serials.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 17656: Keep irregularities during subscription renewals hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-17656-Keep-irregularities-during-subscription--JneHV9.patch </pre> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128498|0 |1 is obsolete| | Attachment #128499|0 |1 is obsolete| | Attachment #128500|0 |1 is obsolete| | Attachment #128501|0 |1 is obsolete| | Attachment #128502|0 |1 is obsolete| | Attachment #128503|0 |1 is obsolete| | Attachment #128504|0 |1 is obsolete| | --- Comment #204 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 132412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132412&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #205 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 132413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132413&action=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #206 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 132415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132415&action=edit Bug 17656: [DO NOT PUSH] provide schema file Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #207 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 132416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132416&action=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi <amarangikarunathilaka@gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #208 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 132417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132417&action=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #209 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 132418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132418&action=edit Bug 17656: More meaningful messages in prediction pattern table Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #210 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 132447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132447&action=edit Bug 17656: fix issue_number call in showprediction.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #211 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 132448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132448&action=edit Bug 17656: (follow-up) Fix typo for QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #212 from Séverine Queune <severine.queune@bulac.fr> --- I've got an error trace on cgi-bin/koha/serials/subscription-renew.pl?mode=popup&subscriptionid=1 when I try to renew the subscription. See the full error in text document attached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #213 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132692&action=edit Error trace when renew a subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #214 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 132779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132779&action=edit Bug 17656: (follow-up) Update DBIC + fix missing C4::Serials functions needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #215 from Séverine Queune <severine.queune@bulac.fr> --- I still have an error trace, this time when I save the subscription. With the patch applies, the option to set 'regular irregularities' for daily (text + checkbox) are not displayed anymore. It didn't happen the first time I test the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #216 from Fridolin Somers <fridolin.somers@biblibre.com> --- Up ^^ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31454 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority --- Comment #217 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can't believe we still haven't fixed this :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132412|0 |1 is obsolete| | Attachment #132413|0 |1 is obsolete| | Attachment #132415|0 |1 is obsolete| | Attachment #132416|0 |1 is obsolete| | Attachment #132417|0 |1 is obsolete| | Attachment #132418|0 |1 is obsolete| | Attachment #132447|0 |1 is obsolete| | Attachment #132448|0 |1 is obsolete| | Attachment #132779|0 |1 is obsolete| | --- Comment #218 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 177497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177497&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #219 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 177498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177498&action=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #220 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 177499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177499&action=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi <amarangikarunathilaka@gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #221 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 177500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177500&action=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #222 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 177501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177501&action=edit Bug 17656: More meaningful messages in prediction pattern table Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #223 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 177502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177502&action=edit Bug 17656: fix issue_number call in showprediction.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #224 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 177503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177503&action=edit Bug 17656: (follow-up) Fix typo for QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #225 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 177504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177504&action=edit Bug 17656: (follow-up) Update DBIC + fix missing C4::Serials functions needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #226 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 177505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177505&action=edit Bug 17656: (QA follow-up) fix compile errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #227 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- woow, had to dig to bring that one back from the grave! I've just made a small patch to fix one or two compile error and fix rebase conflicts. I didn't include the Koha Schema update, but they are supposed to be generated when the test plan is run. Hope this one will finally be merged! Arthur -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #228 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Arthur, just saw this in my emails and was going to put an RM_priority on it, but it already has one. Would love to see this long standing problem resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alex.arnaud@biblibre.com |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #229 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Katrin Fischer from comment #228)
Hi Arthur, just saw this in my emails and was going to put an RM_priority on it, but it already has one. Would love to see this long standing problem resolved.
Hi Katrin, Sorry that this patch lacked my attention for such a long time. I've tried to fix things in such a way that it is now applicable on current main + possible to test on KTD. I was able to run/edit/save subscriptions on KTD, as far as I could tell it still works if you update database / generate the schema / update dbix files as it is described in the test plan. Best, Arthur -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #230 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- No worries - I was just trying to give this a little RM "push"! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177497|0 |1 is obsolete| | --- Comment #231 from David Nind <david@davidnind.com> --- Created attachment 177663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177663&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177498|0 |1 is obsolete| | --- Comment #232 from David Nind <david@davidnind.com> --- Created attachment 177664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177664&action=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177499|0 |1 is obsolete| | --- Comment #233 from David Nind <david@davidnind.com> --- Created attachment 177665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177665&action=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi <amarangikarunathilaka@gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177500|0 |1 is obsolete| | --- Comment #234 from David Nind <david@davidnind.com> --- Created attachment 177666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177666&action=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177501|0 |1 is obsolete| | --- Comment #235 from David Nind <david@davidnind.com> --- Created attachment 177667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177667&action=edit Bug 17656: More meaningful messages in prediction pattern table Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177502|0 |1 is obsolete| | --- Comment #236 from David Nind <david@davidnind.com> --- Created attachment 177668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177668&action=edit Bug 17656: fix issue_number call in showprediction.pl Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177503|0 |1 is obsolete| | --- Comment #237 from David Nind <david@davidnind.com> --- Created attachment 177669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177669&action=edit Bug 17656: (follow-up) Fix typo for QA Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177504|0 |1 is obsolete| | --- Comment #238 from David Nind <david@davidnind.com> --- Created attachment 177670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177670&action=edit Bug 17656: (follow-up) Update DBIC + fix missing C4::Serials functions needed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177505|0 |1 is obsolete| | --- Comment #239 from David Nind <david@davidnind.com> --- Created attachment 177671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177671&action=edit Bug 17656: (QA follow-up) fix compile errors Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #240 from David Nind <david@davidnind.com> --- I've tested, and I think that everything works as expected, so I have signed off. However, it may pay for someone who is more familiar with serials to add their signoff as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177663|0 |1 is obsolete| | Attachment #177664|0 |1 is obsolete| | Attachment #177665|0 |1 is obsolete| | Attachment #177666|0 |1 is obsolete| | Attachment #177667|0 |1 is obsolete| | Attachment #177668|0 |1 is obsolete| | Attachment #177669|0 |1 is obsolete| | Attachment #177670|0 |1 is obsolete| | Attachment #177671|0 |1 is obsolete| | --- Comment #241 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177831&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #242 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177832&action=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #243 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177833&action=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi <amarangikarunathilaka@gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #244 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177834&action=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #245 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177835&action=edit Bug 17656: More meaningful messages in prediction pattern table Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #246 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177836&action=edit Bug 17656: fix issue_number call in showprediction.pl Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #247 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177837&action=edit Bug 17656: (follow-up) Fix typo for QA Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #248 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177838&action=edit Bug 17656: (follow-up) Update DBIC + fix missing C4::Serials functions needed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #249 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177839&action=edit Bug 17656: (QA follow-up) fix compile errors Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #250 from Jonathan Druart <jonathan.druart@gmail.com> --- Tricky rebase, please retest. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #251 from Mathieu Saby <mathsabypro@gmail.com> --- I tried on that sandbox : https://staff-bz17656.sandboxes.ptfs-europe.co.uk/ When I created a subscription, it was impossible to choose a numbering pattern (no choices in the dropdown menu) It does not seem to be an issue on other sandbox, so probably caused by this patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #252 from David Nind <david@davidnind.com> --- I attempted to re-test using KTD and got the same: no number pattern options (just -- please choose --). Without the patch, the numbering pattern options are there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #253 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- I was able to fix the numberingpattern issue by adding "[% numberpattern.label | html %] in the tt. However I still have an issue with renewals. when i renew a subscription and change startdate and number of issues for the renewal, it won't automatically calculate the prediction pattern which is displayed. Probably a JS issue which I still have to work on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #254 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 178142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178142&action=edit Screenshot Describes the current issue I have: the start date for subscription renewal is before even the start date of the previous subscription (seems beginning of the year). Doesn't really feel very right to me but that may be normal. The prediction pattern block do not update dates nor checkboxes when I change the start_date renewal or the number of issues for the renewal. When it is first loaded, not all checkboxes are checked... Here, I'd say that issues for the 03/01 and 03/02 should be checked, it is not... If I uncheck then re-check the permanent irregularities (wednesday and thursday) it is checked by JS though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177831|0 |1 is obsolete| | Attachment #177832|0 |1 is obsolete| | Attachment #177833|0 |1 is obsolete| | Attachment #177834|0 |1 is obsolete| | Attachment #177835|0 |1 is obsolete| | Attachment #177836|0 |1 is obsolete| | Attachment #177837|0 |1 is obsolete| | Attachment #177838|0 |1 is obsolete| | Attachment #177839|0 |1 is obsolete| | --- Comment #255 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 185196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185196&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #256 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 185197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185197&action=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #257 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 185198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185198&action=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi <amarangikarunathilaka@gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #258 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 185199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185199&action=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #259 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 185200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185200&action=edit Bug 17656: More meaningful messages in prediction pattern table Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #260 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 185201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185201&action=edit Bug 17656: fix issue_number call in showprediction.pl Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #261 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 185202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185202&action=edit Bug 17656: (follow-up) Fix typo for QA Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #262 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 185203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185203&action=edit Bug 17656: (follow-up) Update DBIC + fix missing C4::Serials functions needed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #263 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 185204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185204&action=edit Bug 17656: (QA follow-up) fix compile errors Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #264 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 185205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185205&action=edit Bug 17656: (QA follow-up) fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #265 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 185206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185206&action=edit Bug 17656: (QA follow-up) fix templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #266 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 185207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185207&action=edit Bug 17656: (QA follow-up) perltidy + small fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #267 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 185208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185208&action=edit Bug 17656: Update Schema - do not push -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #268 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Hello, I did a rebase + made qa scripts happy. Still have a small issue on subscription-renew.tt but the tidy scripts keeps making the TT invalid, I don't know how to fix this (and it still works so?...) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #269 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Maybe needs signoff is more appropriate since I had to make a couple patch to make tests and QA scripts happy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40159 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #270 from David Nind <david@davidnind.com> --- I've re-tested and happy to sign off. Things I noted: 1. When I do a renewal for a weekly subscription: . For prediction pattern it says Week(s) not published (dropdown list/button - does nothing) Check weeks in the above list in order to keep them unpublished throughout upcoming renewals (permanent irregularities). . The dropdown list is greyed out and does nothing, there is nothing to select, the list of publications in the table below is OK though, and works as expected. . For daily or monthly subscriptions there is something to check (days shown for weekly, months shown for monthly) 2. Something else I noticed is that if the serials haven't been received, then the publication list in the prediction pattern has the publication date for the original subscription, not what is expected for the renewed subscription. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #271 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to David Nind from comment #270)
2. Something else I noticed is that if the serials haven't been received, then the publication list in the prediction pattern has the publication date for the original subscription, not what is expected for the renewed subscription.
Hi David, For the point 2 can you have a look at this one and see if it solves the problem? https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40159 For point 1, can you explain in more details what the patch should fix and how? Best, Arthur -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #272 from Chris Cormack <chris@bigballofwax.co.nz> --- Automatic patch test results: â ï¸ The patch applies with fuzzy option (ignoring whitespace). This may indicate minor conflicts that need to be resolved. Details: Patch applies with fuzzy option (ignoring whitespace) This is an automated message from the patch testing system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185196|0 |1 is obsolete| | --- Comment #273 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190714&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185197|0 |1 is obsolete| | --- Comment #274 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190715&action=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185198|0 |1 is obsolete| | --- Comment #275 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190716&action=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi <amarangikarunathilaka@gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185199|0 |1 is obsolete| | --- Comment #276 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190717&action=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185200|0 |1 is obsolete| | --- Comment #277 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190718&action=edit Bug 17656: More meaningful messages in prediction pattern table Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185201|0 |1 is obsolete| | --- Comment #278 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190719&action=edit Bug 17656: fix issue_number call in showprediction.pl Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185202|0 |1 is obsolete| | --- Comment #279 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190720&action=edit Bug 17656: (follow-up) Fix typo for QA Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185203|0 |1 is obsolete| | --- Comment #280 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190721&action=edit Bug 17656: (follow-up) Update DBIC + fix missing C4::Serials functions needed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185204|0 |1 is obsolete| | --- Comment #281 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190722&action=edit Bug 17656: (QA follow-up) fix compile errors Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185205|0 |1 is obsolete| | --- Comment #282 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190723&action=edit Bug 17656: (QA follow-up) fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185206|0 |1 is obsolete| | --- Comment #283 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190724&action=edit Bug 17656: (QA follow-up) fix templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185207|0 |1 is obsolete| | --- Comment #284 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190725&action=edit Bug 17656: (QA follow-up) perltidy + small fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185208|0 |1 is obsolete| | --- Comment #285 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190726&action=edit Bug 17656: Update Schema - do not push -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #286 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Rebased and fixed minor tidy issue inline. Will try testing soon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #287 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
- check Wednesday and Thursday as irregularity,
After than I pressed the done button even if that's not necessary. And with the patches it did nothing in the UI but did this in the console: Uncaught ReferenceError: hidePredcitionPatternTest is not defined <anonymous> http://localhost:8081/intranet-tmpl/prog/js/subscription-add_25.1200000.js:8... jQuery 2 On a sandbox, it closed the button. ------- Also the dbrev is on the old format. https://wiki.koha-community.org/wiki/Database_updates ----- There are some minor QA script failures [FAIL] installer/data/mysql/atomicupdate/Bug_17656-add-permanent-irregularities.perl FAIL new_line_at_the_end_of_file Missing new line at the end of file, make sure your editor correctly reads .editorconfig ('insert_final_newline = true'). See bug 40541. [FAIL] t/Serials/IssueNumber.t FAIL forbidden_patterns forbidden pattern: Use https:// instead of http:// for URLs (line 16) FAIL test_no_warnings 'use Test::NoWarnings' must be present in this test file. [FAIL] t/db_dependent/Koha/Subscription/GuessEnddate.t FAIL forbidden_patterns forbidden pattern: Use https:// instead of http:// for URLs (line 16) FAIL test_no_warnings 'use Test::NoWarnings' must be present in this test file. [FAIL] t/db_dependent/Koha/Subscription/Irregularities.t FAIL forbidden_patterns forbidden pattern: Use https:// instead of http:// for URLs (line 16) FAIL test_no_warnings 'use Test::NoWarnings' must be present in this test file. [FAIL] t/db_dependent/Serials/SubscriptionIrregularity.t FAIL test_no_warnings 'use Test::NoWarnings' must be present in this test file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190714|0 |1 is obsolete| | Attachment #190715|0 |1 is obsolete| | Attachment #190716|0 |1 is obsolete| | Attachment #190717|0 |1 is obsolete| | Attachment #190718|0 |1 is obsolete| | Attachment #190719|0 |1 is obsolete| | Attachment #190720|0 |1 is obsolete| | Attachment #190721|0 |1 is obsolete| | Attachment #190722|0 |1 is obsolete| | Attachment #190723|0 |1 is obsolete| | Attachment #190724|0 |1 is obsolete| | Attachment #190725|0 |1 is obsolete| | Attachment #190726|0 |1 is obsolete| | --- Comment #288 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 192974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192974&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2026-02-11 - Arthur Suzuki <arthur.suzuki@biblibre.com> Sponsored-by BibLibre -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #289 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 192975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192975&action=edit Bug 17656: Update Schema - do not push -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #290 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Fixed all the point you mentionned Victor, also I've squashed the patch set to make it easier to apply. (In reply to Victor Grousset/tuxayo from comment #287)
- check Wednesday and Thursday as irregularity,
After than I pressed the done button even if that's not necessary. And with the patches it did nothing in the UI but did this in the console:
Uncaught ReferenceError: hidePredcitionPatternTest is not defined <anonymous> http://localhost:8081/intranet-tmpl/prog/js/subscription-add_25.1200000.js: 861 jQuery 2
Also the dbrev is on the old format. https://wiki.koha-community.org/wiki/Database_updates
-----
There are some minor QA script failures
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192974|0 |1 is obsolete| | Attachment #192975|0 |1 is obsolete| | --- Comment #291 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 192985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192985&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2026-02-11 - Arthur Suzuki <arthur.suzuki@biblibre.com> Sponsored-by BibLibre -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #292 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 192986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192986&action=edit Bug 17656: Update Schema - do not push -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #293 from David Nind <david@davidnind.com> --- When saving the daily subscription, I get this error (using KTD): DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'permanent_irregularity' in 'INSERT INTO' at /kohadevbox/koha/Koha/Object.pm line 174 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #294 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi David, did you make sure updatedatabase was run? It looks like the column was missing. Maybe there is a problem with the atomic update file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #295 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- there is still a problem when selecting "1/week" frequency, I'll try to solve that asap and will post a new patch as soon as I get it to work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #296 from Victor Grousset/tuxayo <victor@tuxayo.net> --- after a very quick look: the dbrev is missing the COMMENT and DEFAULT. And does the kohastructure.sql changes need the COLLATE? So that's a least that about divergence between upgraded and clean install. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #297 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 195373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195373&action=edit Bug 17656: (QA follow-up) fix DB update and weekly permanent irregularities selection -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #298 from David Nind <david@davidnind.com> --- Still getting this error when saving subscription (as in comment #293): DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'permanent_irregularity' in 'INSERT INTO' at /kohadevbox/koha/Koha/Object.pm line 174 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Output from running the database update - note no success messages (to me, it doesn't look like the new column has been added): updatedatabase DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/Bug_17656-add-permanent-irregularities.perl [19:33:49] Database structure: MariaDB [koha_kohadev]> describe subscription; +---------------------------------------+--------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +---------------------------------------+--------------+------+-----+---------+----------------+ | biblionumber | int(11) | NO | MUL | NULL | | | subscriptionid | int(11) | NO | PRI | NULL | auto_increment | | librarian | varchar(100) | YES | | | | | startdate | date | YES | | NULL | | | aqbooksellerid | int(11) | YES | MUL | NULL | | | cost | int(11) | YES | | 0 | | | aqbudgetid | int(11) | YES | | 0 | | | weeklength | int(11) | YES | | 0 | | | monthlength | int(11) | YES | | 0 | | | numberlength | int(11) | YES | | 0 | | | periodicity | int(11) | YES | MUL | NULL | | | countissuesperunit | int(11) | NO | | 1 | | | notes | longtext | YES | | NULL | | | status | varchar(100) | NO | | | | | lastvalue1 | int(11) | YES | | NULL | | | innerloop1 | int(11) | YES | | 0 | | | lastvalue2 | int(11) | YES | | NULL | | | innerloop2 | int(11) | YES | | 0 | | | lastvalue3 | int(11) | YES | | NULL | | | innerloop3 | int(11) | YES | | 0 | | | firstacquidate | date | YES | | NULL | | | manualhistory | tinyint(1) | NO | | 0 | | | irregularity | mediumtext | YES | | NULL | | | skip_serialseq | tinyint(1) | NO | | 0 | | | letter | varchar(20) | YES | | NULL | | | numberpattern | int(11) | YES | MUL | NULL | | | locale | varchar(80) | YES | | NULL | | | distributedto | mediumtext | YES | | NULL | | | internalnotes | longtext | YES | | NULL | | | callnumber | mediumtext | YES | | NULL | | | location | varchar(80) | YES | | | | | branchcode | varchar(10) | NO | | | | | lastbranch | varchar(10) | YES | | NULL | | | serialsadditems | tinyint(1) | NO | | 0 | | | staffdisplaycount | int(11) | YES | | NULL | | | opacdisplaycount | int(11) | YES | | NULL | | | graceperiod | int(11) | NO | | 0 | | | enddate | date | YES | | NULL | | | closed | tinyint(1) | NO | | 0 | | | reneweddate | date | YES | | NULL | | | itemtype | varchar(10) | YES | | NULL | | | previousitemtype | varchar(10) | YES | | NULL | | | mana_id | int(11) | YES | | NULL | | | ccode | varchar(80) | YES | | NULL | | | published_on_template | text | YES | | NULL | | | preselect_issues_in_collections_table | tinyint(1) | NO | | 0 | | +---------------------------------------+--------------+------+-----+---------+----------------+ 46 rows in set (0.001 sec) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195373|0 |1 is obsolete| | --- Comment #299 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 195383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195383&action=edit Bug 17656: (QA follow-up) fix DB update and weekly permanent irregularities selection -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #300 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- there was indeed an issue with the db_rev file, I've fixed that and it worked on my ktd (tried to setup koha on main, reset_all, then switch branch to bug17656, updatedatabase and I got the message that the column was added). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #301 from David Nind <david@davidnind.com> --- Sorry, not quick enough to retest, patch no longer applies: /kohadevbox/perl-git-bz/bin/git-bz apply 17656 📋 Bug 17656 - Irregularities in serial prediction pattern are planned only for current subscription • 192985 - Bug 17656: Keep irregularities during subscription renewals • 192986 - Bug 17656: Update Schema - do not push • 195383 - Bug 17656: (QA follow-up) fix DB update and weekly permanent irregularities selection Apply? [(y)es, (n)o, (i)nteractive] y Preparing 3 patch(es): ✓ Prepared 3 patch(es) Applying 3 patch(es): Patch application failed for attachment 192985 - Bug 17656: Keep irregularities during subscription renewals ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192985|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192986|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195383|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #302 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 195769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195769&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2026-02-11 - Arthur Suzuki <arthur.suzuki@biblibre.com> Sponsored-by BibLibre -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195769|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #303 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 195770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195770&action=edit Bug 17656: Update Schema - do not push Patch from commit dc275d0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #304 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 195771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195771&action=edit Bug 17656: (QA follow-up) fix DB update and weekly permanent irregularities selection Patch from commit 01ee837 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195770|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195771|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #305 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 195772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195772&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2026-02-11 - Arthur Suzuki <arthur.suzuki@biblibre.com> Sponsored-by BibLibre -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #306 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 195773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195773&action=edit Bug 17656: Update Schema - do not push Patch from commit dc275d0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #307 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 195774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195774&action=edit Bug 17656: (QA follow-up) fix DB update and weekly permanent irregularities selection Patch from commit 01ee837 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195772|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195773|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195774|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #308 from David Nind <david@davidnind.com> --- Created attachment 195864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195864&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2026-02-11 - Arthur Suzuki <arthur.suzuki@biblibre.com> Sponsored-by BibLibre Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #309 from David Nind <david@davidnind.com> --- Created attachment 195865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195865&action=edit Bug 17656: Update Schema - do not push Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #310 from David Nind <david@davidnind.com> --- Created attachment 195866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195866&action=edit Bug 17656: (QA follow-up) fix DB update and weekly permanent irregularities selection Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #311 from David Nind <david@davidnind.com> --- Have retested and added my signoff again - everything works as per the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195864|0 |1 is obsolete| | Attachment #195865|0 |1 is obsolete| | Attachment #195866|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #312 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196026&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2026-02-11 - Arthur Suzuki <arthur.suzuki@biblibre.com> Sponsored-by BibLibre Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #313 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196027&action=edit Bug 17656: Update Schema - do not push Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #314 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196028&action=edit Bug 17656: (QA follow-up) fix DB update and weekly permanent irregularities selection Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #315 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196029&action=edit Bug 17656: (QA follow-up) fix irregularity save on single and bulk renewal For cud-renew (single subscription renewal): - Save permanent_irregularity from the form submission - Recompute irregularity via guess_irregularities for the new period - Remove unused @irregularities variable that was dead code For cud-multi_renew (bulk renewal): - Stop overwriting permanent_irregularity with empty form data - The multi_renew confirmation form has no irregularity inputs, so the previous code was silently clearing permanent_irregularity on every bulk renewal, breaking subsequent renewals Test plan: Setup (run once): 1. Apply all patches in this series 2. Inside KTD: perl installer/data/mysql/updatedatabase.pl 3. Inside KTD: dbic --force --- Test A: single renewal preserves and applies permanent irregularities --- 4. Go to Serials > New subscription - Choose a daily frequency (1 issue/day) - Set 'Number of issues' to 7, start date: any Monday - In the prediction pattern, check Wednesday and Thursday as permanent irregularities - Save the subscription 5. Edit the subscription: - Verify Wednesday and Thursday checkboxes are checked - Verify the prediction pattern shows those days as 'not published' 6. Renew the subscription (Serials > Subscription detail > Renew): - Verify Wednesday and Thursday are pre-checked on the renewal form - Leave them checked and submit 7. Edit the subscription again: - Verify Wednesday and Thursday are still checked [previously broken] - Verify the prediction pattern for the NEW period shows Wednesday and Thursday issues as 'not published' [previously broken] --- Test B: permanent irregularities can be changed at renewal time --- 8. Renew the subscription again: - On the renewal form, uncheck Wednesday, leave Thursday checked - Submit 9. Edit the subscription: - Verify only Thursday is now checked - Verify only Thursday appears as 'not published' in the prediction --- Test C: bulk renewal preserves permanent irregularities --- 10. Create a second subscription with permanent irregularities (e.g. a weekly subscription skipping week 1 and week 3) 11. From the subscription list, select both subscriptions and choose 'Renew selected' (bulk renewal) - Confirm the renewal 12. Edit each subscription: - Verify the permanent irregularity checkboxes are still checked as they were before renewal [previously broken - cleared] - Verify the prediction for each new period shows the correct issues as 'not published' 13. Bulk-renew the subscriptions a second time and repeat step 12 to confirm permanent irregularities survive multiple bulk renewals [previously they were cleared on the first bulk renewal] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #316 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196030&action=edit Bug 17656: (QA follow-up) guard against NULL irregularity columns and missing enddate Three defensive fixes in Koha::Subscription: 1. irregularities() and permanent_irregularities(): split(';', undef) produces a warning under 'use warnings' and returns ('') — a list containing one empty string — when the column is NULL (which is the case for all existing subscriptions after the DB migration adds permanent_irregularity). The resulting empty-string hash key in guess_irregularities could cause spurious false matches. Fixed by returning an empty list early when the column is NULL/empty. 2. guess_irregularities(): called Delta_Days(..., split(/-/, $enddate)) without checking whether $enddate is defined first. Open-ended subscriptions (weeklength/monthlength without a computed enddate, or any subscription where enddate is NULL) would cause Date::Calc to die with a fatal exception. Fixed by returning an empty list early when enddate is not set. Test plan: --- Test A: no warnings on subscriptions with NULL permanent_irregularity --- 1. Apply all patches and run the DB update (perl updatedatabase.pl inside KTD) 2. Open any existing subscription that was created before this patch series (it will have permanent_irregularity = NULL) 3. Edit the subscription and view the prediction pattern - No Perl warnings should appear in the Koha/Plack error log - The prediction pattern should display correctly 4. Renew the subscription - No warnings or errors in the log - Renewal completes normally with irregularity set to '' (empty) --- Test B: no crash on open-ended subscriptions --- 5. Create a subscription using 'Number of weeks' or 'Number of months' as the length type (not 'Number of issues'), so that enddate may be NULL or unpopulated before the first renewal 6. Set permanent irregularities and save 7. Renew the subscription - Should complete without a 500 error or Date::Calc exception - irregularity is saved as empty (no end date = cannot compute which issue numbers fall on irregular days) --- Test C: normal operation is unaffected --- 8. Create a daily subscription (1 issue/day, 7 issues) with Wednesday and Thursday marked as permanent irregularities 9. Renew the subscription - Verify irregularity is correctly populated for the new period - Verify Wednesday and Thursday are still checked in the edit form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #317 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196031&action=edit Bug 17656: (QA follow-up) clean up stale export entry and import - Remove GetSubscriptionIrregularities from C4::Serials @EXPORT_OK. The function was deleted in the main patch but the export entry was left behind, and showpredictionpattern.pl continued to import it. Neither the entry nor the import caused a crash (the function was never called after the refactor) but both are misleading dead code. - Remove duplicate &subscriptionCurrentlyOnOrder from @EXPORT_OK. The bare name was already present earlier in the same list; the ampersand-prefixed duplicate was added unnecessarily. - Change &issue_number to issue_number in @EXPORT_OK. The & prefix on an export list entry is non-standard in Koha and inconsistent with all other entries in the same list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #318 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196032&action=edit Bug 17656: (QA follow-up) expand test coverage for irregularities The original test only covered a single daily subscription renewal scenario with a hard-coded expected value. Add coverage for: - irregularities() and permanent_irregularities() accessors with NULL and empty-string column values (regression test for the undef-split fix in this series) - guess_irregularities() returning an empty list when enddate is not set (regression test for the missing enddate guard) - Weekly subscription renewal: permanent_irregularity stores week-of- year values; verify the correct issue numbers are identified after renewal (weeks 5 and 6 of the year map to issues 5 and 6) - Monthly subscription renewal: permanent_irregularity stores month numbers; verify September (month 9) and October (month 10) map to the correct issue numbers in the renewed period The existing daily test is preserved and wrapped in a subtest with a descriptive label. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de --- Comment #319 from Philip Orr <philip.orr@lmscloud.de> --- running qa says: ``` [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/serials/showpredictionpattern.tt FAIL forbidden_patterns forbidden pattern: <script> elements must have a "src" or "nonce" attribute (line 8) ´´´ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196028|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196029|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196030|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196031|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196032|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #320 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 196149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196149&action=edit Bug 17656: (QA follow-up) fix DB update and weekly permanent irregularities selection Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #321 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 196150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196150&action=edit Bug 17656: (QA follow-up) fix irregularity save on single and bulk renewal For cud-renew (single subscription renewal): - Save permanent_irregularity from the form submission - Recompute irregularity via guess_irregularities for the new period - Remove unused @irregularities variable that was dead code For cud-multi_renew (bulk renewal): - Stop overwriting permanent_irregularity with empty form data - The multi_renew confirmation form has no irregularity inputs, so the previous code was silently clearing permanent_irregularity on every bulk renewal, breaking subsequent renewals Test plan: Setup (run once): 1. Apply all patches in this series 2. Inside KTD: perl installer/data/mysql/updatedatabase.pl 3. Inside KTD: dbic --force Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #322 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 196151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196151&action=edit Bug 17656: (QA follow-up) guard against NULL irregularity columns and missing enddate Three defensive fixes in Koha::Subscription: 1. irregularities() and permanent_irregularities(): split(';', undef) produces a warning under 'use warnings' and returns ('') — a list containing one empty string — when the column is NULL (which is the case for all existing subscriptions after the DB migration adds permanent_irregularity). The resulting empty-string hash key in guess_irregularities could cause spurious false matches. Fixed by returning an empty list early when the column is NULL/empty. 2. guess_irregularities(): called Delta_Days(..., split(/-/, $enddate)) without checking whether $enddate is defined first. Open-ended subscriptions (weeklength/monthlength without a computed enddate, or any subscription where enddate is NULL) would cause Date::Calc to die with a fatal exception. Fixed by returning an empty list early when enddate is not set. Test plan: Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #323 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 196152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196152&action=edit Bug 17656: (QA follow-up) clean up stale export entry and import - Remove GetSubscriptionIrregularities from C4::Serials @EXPORT_OK. The function was deleted in the main patch but the export entry was left behind, and showpredictionpattern.pl continued to import it. Neither the entry nor the import caused a crash (the function was never called after the refactor) but both are misleading dead code. - Remove duplicate &subscriptionCurrentlyOnOrder from @EXPORT_OK. The bare name was already present earlier in the same list; the ampersand-prefixed duplicate was added unnecessarily. - Change &issue_number to issue_number in @EXPORT_OK. The & prefix on an export list entry is non-standard in Koha and inconsistent with all other entries in the same list. Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #324 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 196153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196153&action=edit Bug 17656: (QA follow-up) expand test coverage for irregularities The original test only covered a single daily subscription renewal scenario with a hard-coded expected value. Add coverage for: - irregularities() and permanent_irregularities() accessors with NULL and empty-string column values (regression test for the undef-split fix in this series) - guess_irregularities() returning an empty list when enddate is not set (regression test for the missing enddate guard) - Weekly subscription renewal: permanent_irregularity stores week-of- year values; verify the correct issue numbers are identified after renewal (weeks 5 and 6 of the year map to issues 5 and 6) - Monthly subscription renewal: permanent_irregularity stores month numbers; verify September (month 9) and October (month 10) map to the correct issue numbers in the renewed period The existing daily test is preserved and wrapped in a subtest with a descriptive label. Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #325 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Needs to follow the new nonce pattern: [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/serials/showpredictionpattern.tt FAIL forbidden_patterns forbidden pattern: <script> elements must have a "src" or "nonce" attribute -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196026|0 |1 is obsolete| | Attachment #196027|0 |1 is obsolete| | Attachment #196149|0 |1 is obsolete| | Attachment #196150|0 |1 is obsolete| | Attachment #196151|0 |1 is obsolete| | Attachment #196152|0 |1 is obsolete| | Attachment #196153|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #326 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 207945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207945&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2026-02-11 - Arthur Suzuki <arthur.suzuki@biblibre.com> Sponsored-by BibLibre Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #327 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 207946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207946&action=edit Bug 17656: Update Schema - do not push Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #328 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 207947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207947&action=edit Bug 17656: (QA follow-up) fix DB update and weekly permanent irregularities selection Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #329 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 207948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207948&action=edit Bug 17656: (QA follow-up) fix irregularity save on single and bulk renewal For cud-renew (single subscription renewal): - Save permanent_irregularity from the form submission - Recompute irregularity via guess_irregularities for the new period - Remove unused @irregularities variable that was dead code For cud-multi_renew (bulk renewal): - Stop overwriting permanent_irregularity with empty form data - The multi_renew confirmation form has no irregularity inputs, so the previous code was silently clearing permanent_irregularity on every bulk renewal, breaking subsequent renewals Test plan: Setup (run once): 1. Apply all patches in this series 2. Inside KTD: perl installer/data/mysql/updatedatabase.pl 3. Inside KTD: dbic --force Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #330 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 207949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207949&action=edit Bug 17656: (QA follow-up) guard against NULL irregularity columns and missing enddate Three defensive fixes in Koha::Subscription: 1. irregularities() and permanent_irregularities(): split(';', undef) produces a warning under 'use warnings' and returns ('') — a list containing one empty string — when the column is NULL (which is the case for all existing subscriptions after the DB migration adds permanent_irregularity). The resulting empty-string hash key in guess_irregularities could cause spurious false matches. Fixed by returning an empty list early when the column is NULL/empty. 2. guess_irregularities(): called Delta_Days(..., split(/-/, $enddate)) without checking whether $enddate is defined first. Open-ended subscriptions (weeklength/monthlength without a computed enddate, or any subscription where enddate is NULL) would cause Date::Calc to die with a fatal exception. Fixed by returning an empty list early when enddate is not set. Test plan: Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #331 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 207950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207950&action=edit Bug 17656: (QA follow-up) clean up stale export entry and import - Remove GetSubscriptionIrregularities from C4::Serials @EXPORT_OK. The function was deleted in the main patch but the export entry was left behind, and showpredictionpattern.pl continued to import it. Neither the entry nor the import caused a crash (the function was never called after the refactor) but both are misleading dead code. - Remove duplicate &subscriptionCurrentlyOnOrder from @EXPORT_OK. The bare name was already present earlier in the same list; the ampersand-prefixed duplicate was added unnecessarily. - Change &issue_number to issue_number in @EXPORT_OK. The & prefix on an export list entry is non-standard in Koha and inconsistent with all other entries in the same list. Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #332 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 207951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207951&action=edit Bug 17656: (QA follow-up) expand test coverage for irregularities The original test only covered a single daily subscription renewal scenario with a hard-coded expected value. Add coverage for: - irregularities() and permanent_irregularities() accessors with NULL and empty-string column values (regression test for the undef-split fix in this series) - guess_irregularities() returning an empty list when enddate is not set (regression test for the missing enddate guard) - Weekly subscription renewal: permanent_irregularity stores week-of- year values; verify the correct issue numbers are identified after renewal (weeks 5 and 6 of the year map to issues 5 and 6) - Monthly subscription renewal: permanent_irregularity stores month numbers; verify September (month 9) and October (month 10) map to the correct issue numbers in the renewed period The existing daily test is preserved and wrapped in a subtest with a descriptive label. Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #333 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 207952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207952&action=edit Bug 17656: (QA follow-up) add missing nonce attribute to script tag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #334 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 207953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207953&action=edit Bug 17656: (QA follow-up) add POD coverage for undocumented subs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #335 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 207954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207954&action=edit Bug 17656: (QA follow-up) tidy calendar.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #336 from David Nind <david@davidnind.com> --- Something in the patches is causing the "Test predication pattern" button not to work. Clicking the button does nothing, and there is this error in the console: GET http://127.0.0.1:8081/cgi-bin/koha/serials/showpredictionpattern.pl?custompattern=0&firstacquidate=2026-10-10&subtype=issues&sublength=7&frequency=2&numberingmethod=No.%20%7BX%7D&lastvalue1=5&add1=1&every1=1&setto1=1&whenmorethan1=99999 500 (Internal Server Error) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #337 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 208766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208766&action=edit Bug 17656: (QA follow-up) Add missing includes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207945|0 |1 is obsolete| | Attachment #207946|0 |1 is obsolete| | Attachment #207947|0 |1 is obsolete| | Attachment #207948|0 |1 is obsolete| | Attachment #207949|0 |1 is obsolete| | Attachment #207950|0 |1 is obsolete| | Attachment #207951|0 |1 is obsolete| | Attachment #207952|0 |1 is obsolete| | Attachment #207953|0 |1 is obsolete| | Attachment #207954|0 |1 is obsolete| | Attachment #208766|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #338 from David Nind <david@davidnind.com> --- Created attachment 208767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208767&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud@biblibre.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Nind <david@davidnind.com> Rebased - 2026-02-11 - Arthur Suzuki <arthur.suzuki@biblibre.com> Sponsored-by BibLibre Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #339 from David Nind <david@davidnind.com> --- Created attachment 208768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208768&action=edit Bug 17656: Update Schema - do not push Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #340 from David Nind <david@davidnind.com> --- Created attachment 208769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208769&action=edit Bug 17656: (QA follow-up) fix DB update and weekly permanent irregularities selection Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Philip Orr <philip.orr@lmscloud.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #341 from David Nind <david@davidnind.com> --- Created attachment 208770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208770&action=edit Bug 17656: (QA follow-up) fix irregularity save on single and bulk renewal For cud-renew (single subscription renewal): - Save permanent_irregularity from the form submission - Recompute irregularity via guess_irregularities for the new period - Remove unused @irregularities variable that was dead code For cud-multi_renew (bulk renewal): - Stop overwriting permanent_irregularity with empty form data - The multi_renew confirmation form has no irregularity inputs, so the previous code was silently clearing permanent_irregularity on every bulk renewal, breaking subsequent renewals Test plan: Setup (run once): 1. Apply all patches in this series 2. Inside KTD: perl installer/data/mysql/updatedatabase.pl 3. Inside KTD: dbic --force Signed-off-by: Philip Orr <philip.orr@lmscloud.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #342 from David Nind <david@davidnind.com> --- Created attachment 208771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208771&action=edit Bug 17656: (QA follow-up) guard against NULL irregularity columns and missing enddate Three defensive fixes in Koha::Subscription: 1. irregularities() and permanent_irregularities(): split(';', undef) produces a warning under 'use warnings' and returns ('') — a list containing one empty string — when the column is NULL (which is the case for all existing subscriptions after the DB migration adds permanent_irregularity). The resulting empty-string hash key in guess_irregularities could cause spurious false matches. Fixed by returning an empty list early when the column is NULL/empty. 2. guess_irregularities(): called Delta_Days(..., split(/-/, $enddate)) without checking whether $enddate is defined first. Open-ended subscriptions (weeklength/monthlength without a computed enddate, or any subscription where enddate is NULL) would cause Date::Calc to die with a fatal exception. Fixed by returning an empty list early when enddate is not set. Test plan: Signed-off-by: Philip Orr <philip.orr@lmscloud.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #343 from David Nind <david@davidnind.com> --- Created attachment 208772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208772&action=edit Bug 17656: (QA follow-up) clean up stale export entry and import - Remove GetSubscriptionIrregularities from C4::Serials @EXPORT_OK. The function was deleted in the main patch but the export entry was left behind, and showpredictionpattern.pl continued to import it. Neither the entry nor the import caused a crash (the function was never called after the refactor) but both are misleading dead code. - Remove duplicate &subscriptionCurrentlyOnOrder from @EXPORT_OK. The bare name was already present earlier in the same list; the ampersand-prefixed duplicate was added unnecessarily. - Change &issue_number to issue_number in @EXPORT_OK. The & prefix on an export list entry is non-standard in Koha and inconsistent with all other entries in the same list. Signed-off-by: Philip Orr <philip.orr@lmscloud.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #344 from David Nind <david@davidnind.com> --- Created attachment 208773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208773&action=edit Bug 17656: (QA follow-up) expand test coverage for irregularities The original test only covered a single daily subscription renewal scenario with a hard-coded expected value. Add coverage for: - irregularities() and permanent_irregularities() accessors with NULL and empty-string column values (regression test for the undef-split fix in this series) - guess_irregularities() returning an empty list when enddate is not set (regression test for the missing enddate guard) - Weekly subscription renewal: permanent_irregularity stores week-of- year values; verify the correct issue numbers are identified after renewal (weeks 5 and 6 of the year map to issues 5 and 6) - Monthly subscription renewal: permanent_irregularity stores month numbers; verify September (month 9) and October (month 10) map to the correct issue numbers in the renewed period The existing daily test is preserved and wrapped in a subtest with a descriptive label. Signed-off-by: Philip Orr <philip.orr@lmscloud.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #345 from David Nind <david@davidnind.com> --- Created attachment 208774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208774&action=edit Bug 17656: (QA follow-up) add missing nonce attribute to script tag Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #346 from David Nind <david@davidnind.com> --- Created attachment 208775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208775&action=edit Bug 17656: (QA follow-up) add POD coverage for undocumented subs Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #347 from David Nind <david@davidnind.com> --- Created attachment 208776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208776&action=edit Bug 17656: (QA follow-up) tidy calendar.inc Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #348 from David Nind <david@davidnind.com> --- Created attachment 208777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208777&action=edit Bug 17656: (QA follow-up) Add missing includes Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org