https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26232 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26232 --- Comment #2 from didier <didier.gautheron@biblibre.com> --- Created attachment 108433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108433&action=edit Bug 26232: Test for empty smart rule fine grace period -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26232 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26232 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108434|0 |1 is obsolete| | --- Comment #5 from didier <didier.gautheron@biblibre.com> --- Created attachment 111034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111034&action=edit Bug 26232: Empty smart rule fine grace period Staff can create smart rules with empty (undefined) fine grace period. In Overdues.pm undefined firstremind means 0, do the same in Circulation.pm. To test: 1. Apply these patches 2. Run: kshell prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26232 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26232 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26232 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112403|0 |1 is obsolete| | Attachment #112404|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 112427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112427&action=edit Bug 26232: Test for empty smart rule fine grace period Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Current status: Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26232 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- I cannot recreate the error adding rules via the stff client, but I believe the change makes sense -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26232 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26232 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- a bunch of failed tests on 19.11.x: $ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 38/47 # Failed test 'Item can be issued to this patron' # at t/db_dependent/Circulation.t line 3005. # Structures begin differing at: # $got->{PATRON_CANT} = '1' # $expected->{PATRON_CANT} = Does not exist # Looks like you failed 1 test of 2. # Failed test 'CanBookBeIssued | item-level_itypes=biblio' # at t/db_dependent/Circulation.t line 3007. # Failed test 'Item can be issued to this patron' # at t/db_dependent/Circulation.t line 3040. # Structures begin differing at: # $got->{TOO_MANY} = 'NO_RULE_DEFINED' # $expected->{TOO_MANY} = Does not exist # Failed test 'No confirmation needed, AllowNotForLoanOverride=0' # at t/db_dependent/Circulation.t line 3046. # Structures begin differing at: # $got->{current_loan_count} = undef # $expected->{current_loan_count} = Does not exist # Failed test 'No confirmation needed, AllowNotForLoanOverride=0' # at t/db_dependent/Circulation.t line 3057. # Structures begin differing at: # $got->{current_loan_count} = undef # $expected->{current_loan_count} = Does not exist # Looks like you failed 3 tests of 6. # Failed test 'item-level_itypes = 1' # at t/db_dependent/Circulation.t line 3063. # Failed test 'Item can be issued to this patron' # at t/db_dependent/Circulation.t line 3082. # Structures begin differing at: # $got->{TOO_MANY} = 'NO_RULE_DEFINED' # $expected->{TOO_MANY} = Does not exist # Failed test 'No confirmation needed, AllowNotForLoanOverride=0' # at t/db_dependent/Circulation.t line 3088. # Structures begin differing at: # $got->{PATRON_CANT} = '1' # $expected->{PATRON_CANT} = Does not exist # Failed test 'No confirmation needed, AllowNotForLoanOverride=0' # at t/db_dependent/Circulation.t line 3099. # Structures begin differing at: # $got->{PATRON_CANT} = '1' # $expected->{PATRON_CANT} = Does not exist # Looks like you failed 3 tests of 6. # Failed test 'item-level_itypes = 0' # at t/db_dependent/Circulation.t line 3105. # Looks like you failed 2 tests of 2. # Failed test 'CanBookBeIssued | notforloan' # at t/db_dependent/Circulation.t line 3108. t/db_dependent/Circulation.t .. 44/47 # Failed test 'Item needs rentalcharge confirmation to be issued' # at t/db_dependent/Circulation.t line 3488. # Structures begin differing at: # $got->{current_loan_count} = undef # $expected->{current_loan_count} = Does not exist # Failed test 'Item needs rentalcharge confirmation to be issued, increment' # at t/db_dependent/Circulation.t line 3492. # Structures begin differing at: # $got->{TOO_MANY} = 'NO_RULE_DEFINED' # $expected->{TOO_MANY} = Does not exist # Looks like you failed 2 tests of 2. # Failed test 'CanBookBeIssued & RentalFeesCheckoutConfirmation' # at t/db_dependent/Circulation.t line 3494. # Looks like you failed 3 tests of 47. t/db_dependent/Circulation.t .. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/47 subtests Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 768 Tests: 47 Failed: 3) Failed tests: 39-40, 45 Non-zero exit status: 3 Files=1, Tests=47, 20 wallclock secs ( 0.06 usr 0.01 sys + 15.52 cusr 1.96 csys = 17.55 CPU) Result: FAIL please fix if needed -- You are receiving this mail because: You are watching all bug changes.