[Bug 26647] New: The Cancel button in holds table should be translated in context for Swedish.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 Bug ID: 26647 Summary: The Cancel button in holds table should be translated in context for Swedish. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: timothy_alexis.vass@ub.lu.se QA Contact: testopia@bugs.koha-community.org In Sweden Cancel should be translated as "Ta bort" (which means 'Remove') rather than "Avbryt" in the context of Holds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |timothy_alexis.vass@ub.lu.s | |e Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 --- Comment #1 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 111415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111415&action=edit Bug 26647 - The Cancel button in holds table should be translated in context for Swedish 0) Apply the patch and add a hold on an item. 1) Install Swedish language, sv-SE and change interface language to Swedish 2) Modify sv-SE-opac-bootstrap.po and add this: msgctxt "Cancel hold button" msgid "Cancel" msgstr "Ta bort" 3) Go to the Holds table at /cgi-bin/koha/opac-user.pl#opac-user-holds 4) Confirm that the button is translated as "Ta bort" 5) Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs Signoff |Failed QA --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- It worked, but the msgid and the msgctxt in my sv-SE-messages.po seem to be inverted? 169 msgctxt "Cancel" 170 msgid "Cancel hold button" 171 msgstr "aaaaaaaa" (don't mind the aaaa, I put something silly just to make sure I noticed if it worked, hehe). It should be msgctxt Cancel hold button and msgid Cancel. But it works, so I'm not sure. I think in your holds-table.inc, you should write it in this order [% tp('Cancel hold button','Cancel') | html %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111415|0 |1 is obsolete| | --- Comment #3 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 111465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111465&action=edit Bug 26647 - The Cancel button in holds table should be translated in context for Swedish 0) Apply the patch and add a hold on an item. 1) Install Swedish language, sv-SE and change interface language to Swedish 2) Modify sv-SE-opac-bootstrap.po and add this: msgctxt "Cancel hold button" msgid "Cancel" msgstr "Ta bort" 3) Go to the Holds table at /cgi-bin/koha/opac-user.pl#opac-user-holds 4) Confirm that the button is translated as "Ta bort" 5) Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- (In reply to Caroline Cyr La Rose from comment #2)
It worked, but the msgid and the msgctxt in my sv-SE-messages.po seem to be inverted?
Thank you Caroline. :) Correct patch is now attached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The Cancel button in holds |Add translation context to |table should be translated |cancel hold button in OPAC |in context for Swedish. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111465|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 111546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111546&action=edit Bug 26647: Add translation context to cancel hold button in OPAC 0) Apply the patch and add a hold on an item. 1) Install Swedish language, sv-SE and change interface language to Swedish 2) Modify sv-SE-opac-bootstrap.po and add this: msgctxt "Cancel hold button" msgid "Cancel" msgstr "Ta bort" 3) Go to the Holds table at /cgi-bin/koha/opac-user.pl#opac-user-holds 4) Confirm that the button is translated as "Ta bort" 5) Sign off Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111546|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111563&action=edit Bug 26647: Add translation context to cancel hold button in OPAC 0) Apply the patch and add a hold on an item. 1) Install Swedish language, sv-SE and change interface language to Swedish 2) Modify sv-SE-opac-bootstrap.po and add this: msgctxt "Cancel hold button" msgid "Cancel" msgstr "Ta bort" 3) Go to the Holds table at /cgi-bin/koha/opac-user.pl#opac-user-holds 4) Confirm that the button is translated as "Ta bort" 5) Sign off Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Same issue in German - will be happy to get rid of a little more jQuery :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.06 released in| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- doesn't apply cleanly to 19.11.x, please rebase -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org