[Bug 6115] New: Acquisition reports : date filter & sorting don't work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 Bug #: 6115 Summary: Acquisition reports : date filter & sorting don't work Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Reports AssignedTo: gmcharlt@gmail.com ReportedBy: paul.poulain@biblibre.com QAContact: koha-bugs@lists.koha-community.org * the filter on dates don't work * when displaying by day or month, it was 100% alphabetic, april was before january for example. Adding the month number before the month name to get proper sorting -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gmcharlt@gmail.com |paul.poulain@biblibre.com --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> 2011-04-07 13:41:12 UTC --- Created attachment 3793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3793 proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff Severity|enhancement |major -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 Frederic Durand <frederic.durand@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic.durand@univ-lyon2. | |fr Patch Status|Needs Signoff |Failed QA --- Comment #2 from Frederic Durand <frederic.durand@univ-lyon2.fr> 2011-04-08 12:44:01 UTC --- This patch working for sort grouping by month (march is getting before april). But not for day of week : 4-Friday is coming before 0-Monday. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3793|0 |1 is obsolete| | --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-05-23 12:59:25 UTC --- Created attachment 4231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4231 proposed patch (updated) For an unknown reason, it seems that monday (0) is moved AFTER other days (1-6) Fixed by adding +1 to weekday, to have it between 1 and 7 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Failed QA --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-07-06 16:07:42 UTC --- Saturday is coming before Wednesday in the column headings - but is right in the row headings. marking failed-qa -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> 2011-07-06 16:08:02 UTC --- Created attachment 4567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4567 columns sorted wrong -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-07-06 16:08:17 UTC --- Created attachment 4568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4568 rows sorting right -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4231|0 |1 is obsolete| | --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-07-19 15:53:55 UTC --- Created attachment 4669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4669 proposed patch (updated again) nasty bug : the ordering was done on $column instead of $colfield. It was not visible in all cases, well spotted nicole ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4669|0 |1 is obsolete| | --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2011-07-22 08:25:56 UTC --- Created attachment 4714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4714 proposed patch (updated again) oups, i've uploaded the previous patch (without the fix). Uploading again. Please sign-off this one -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-07-22 08:26:43 UTC --- diff between the previous one and the correct one: - $strsth2 .= " ORDER BY $column"; + $strsth2 .= " ORDER BY $colfield"; -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 --- Comment #10 from Nicole C. Engard <nengard@gmail.com> 2011-08-05 00:04:52 UTC --- Created attachment 4851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4851 before patch I'm not sure I like the change this patch applies. The reports are in order by date just fine without the patch as shown in the attachment. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 --- Comment #11 from Nicole C. Engard <nengard@gmail.com> 2011-08-05 00:05:24 UTC --- Created attachment 4852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4852 after patch after the patch it's showing the month number which is kind of distracting ... or am i missing what else this patch is doing? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-05 09:28:02 UTC --- Created attachment 4856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4856 wrong order screenshot Nicole, here is a screenshot with the problems (it's for weekdays). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-05 09:31:09 UTC --- Created attachment 4857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4857 wrong order screenshot Here is a wrong screenshot based on months Nicole: after investigating, it seems that the problem is visible only under certain circumstances. I think -but am not sure- if your datas alway have closedate ordered like basketid, then the result is correct, but it's by chance. My test DB contains : mysql> select closedate,basketno FROM aqbasket; +------------+----------+ | closedate | basketno | +------------+----------+ | 2011-06-20 | 1 | | 2010-07-20 | 2 | (basket 1 closed after basket 2) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_4 |master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Does not apply --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-21 05:26:18 UTC --- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: BZ6115: Acquisition reports : date filter & sorting don't work Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging reports/acquisitions_stats.pl CONFLICT (content): Merge conflict in reports/acquisitions_stats.pl Failed to merge in the changes. Patch failed at 0001 BZ6115: Acquisition reports : date filter & sorting don't work When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4714|0 |1 is obsolete| | --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-26 17:23:31 UTC --- Created attachment 6930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6930 BZ6115: Acquisition reports : date filter & sorting don't work * the filter on dates don't work * when displaying by day or month, it was 100% alphabetic, april was before january for example. Adding the month number before the month name to get proper sorting * removed many commented warn & lines -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6930|0 |1 is obsolete| | --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-27 23:26:05 UTC --- Created attachment 6939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6939 BZ6115: Acquisition reports : date filter & sorting don't work * the filter on dates don't work * when displaying by day or month, it was 100% alphabetic, april was before january for example. Adding the month number before the month name to get proper sorting * removed many commented warn & lines Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Signed Off --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-27 23:28:09 UTC --- Testing results 1/ Date filters work well 2/ Grouping by month/day of week/year produces a well sorted list -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #18 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-18 12:50:48 UTC --- QA Comment: Looks good. Lots of warns removed. Has a solid signoff. patch_status++ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6115 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #19 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This fix was included in the 3.6.x branch prior to 3.6.4. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org