[Bug 7083] New: Show creator name on list of public lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7083 Bug #: 7083 Summary: Show creator name on list of public lists Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/virtualshelves/shelves.pl OS/Version: All Status: ASSIGNED Severity: enhancement Priority: P5 Component: Virtual Shelves AssignedTo: oleonard@myacpl.org ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org The list of public lists in the staff client should show which patron is the creator of the list. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7083 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-10-24 15:52:49 UTC --- Created attachment 6039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6039 Proposed fix Show the name of the patron who created each list on the list of public lists. Also: - correcting unescaped ampersand in the template - making conditional a check on a variable that doesn't always exist, causing noisy errors in the log ("Use of uninitialized value $sortfield in string eq at C4/VirtualShelves/Page.pm line 335") -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7083 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7083 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6039|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@enger.priv.no> 2011-11-04 15:41:42 UTC --- Created attachment 6207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6207 Fix for Bug 7083 - [SIGNED-OFF] Show creator name on list of public lists Show the name of the patron who created each list on the list of public lists. Also: - correcting unescaped ampersand in the template - making conditional a check on a variable that doesn't always exist, causing noisy errors in the log Signed-off-by: Magnus Enger <magnus@enger.priv.no> After applying the patch a column for "Created by" is added to the display of public lists, and the errors in the log are silenced. On the "Your lists" tab, the link on the list name now has an escaped ampersand. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7083 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7083 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7083 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Does not apply --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-12-07 13:54:37 UTC --- Applying: Fix for Bug 7083 - [SIGNED-OFF] Show creator name on list of public lists error: koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt: does not match index Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... error: Entry 'koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt' not uptodate. Cannot merge. fatal: merging of trees bf768d4642523bde5041af12d0403bec35148bb2 and 07a8614703fa983c030071c562ba07d3467f8448 failed Failed to merge in the changes. Please send a rebased patch. Will continue QA after it has arrived. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7083 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Signed Off --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-12-07 13:56:00 UTC --- (In reply to comment #3)
Applying: Fix for Bug 7083 - [SIGNED-OFF] Show creator name on list of public lists error: koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt: does not match index Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... error: Entry 'koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt' not uptodate. Cannot merge. fatal: merging of trees bf768d4642523bde5041af12d0403bec35148bb2 and 07a8614703fa983c030071c562ba07d3467f8448 failed Failed to merge in the changes.
Please send a rebased patch. Will continue QA after it has arrived.
Sorry, this seems to be my problem. Looking further now.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7083 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-12-07 14:01:32 UTC --- QA: Small change in code and template. Looks good. Marking Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7083 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-08 10:50:20 UTC --- patch pushed, please test Chris_n this is an enhancement, but don't change the workflow, change only for staff, so OK for 3.6 imo -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7083 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-18 15:21:15 UTC --- seems I forgot to merge this patch. Done, it's really pushed now ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7083 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This fix was included in the 3.6.x branch prior to 3.6.4. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org